From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A3E1A9F91 for ; Mon, 20 Jul 2026 01:10:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784509808; cv=none; b=S3sAxxN/EEjrdRJUoNeT0UJir00ymVsM9Qdn0doLYIZ5qhday02DgDH8OjFfEWRsmtakT+W5w/bweqb/p+NJpATJ7cTUXdv/aUBcx9vtQ1aBWPQINh5HJNnubobesHPtwk/TwHQwlf35clKgsonhBxYrY8VL8EHuSwnHVx7OeEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784509808; c=relaxed/simple; bh=hDiOy+/M4OfbO5Y+OUa4JeHIlcDyUf3B6CeACEejA1o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Uv2DmRrelydoyRpSTamhfHwf0Es+fQvosF7PhxTUEevslk6hbYV59MSBPRhGJr7Xmat6Y+S/Kq/rOX8KCi2hMqg6+EBKOESwtEJsA6tuNydr0LT9DxqFvD52YmdV1HbvAl3kYDNUuLMws/OTfxBG3WJkJwBrF3vTPZbmEMSjz4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AxmZcS5X; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gogdtSP2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AxmZcS5X"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gogdtSP2" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNuMrd942429 for ; Mon, 20 Jul 2026 01:10:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OVqOUuBVtydQxQUla2vfU1Oku0cw1BoRtkOvkgKRR7s=; b=AxmZcS5Xwpz//RCl BcSCobVgIdL5tCaLK5EJ6MXNjnGU0FBlmbWodP9Ej/8g98kCYdmMOsQAyPD86w7e 1KGKN7K2nUhG5XjgwOfRWjtdmt0ZgOY7nyDdEU7TdXPkP8jDn0rmgk0VeWB1wyud 2MO2MF/m7NlhntB3Tu+VzLXyQie9Yzv99/o8F+VBP4hSEXSDZkm6On31J/FSnpio LkfkNbO8Rz5ZXNRwysQpLQXfGeDc6VMCMimUAdU7LZ0xHo7yoJf4UFEXdql3+YQO fHpzUqMlpP5KCvLB1SBbx1OHGObum4Fz1aZ93QGXJfrxWxSQ0tawjA3/7ADs4Ro2 JF8zdg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2c6bue7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 01:10:06 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ccd1958e8fso87394355ad.2 for ; Sun, 19 Jul 2026 18:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784509805; x=1785114605; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OVqOUuBVtydQxQUla2vfU1Oku0cw1BoRtkOvkgKRR7s=; b=gogdtSP2Y+jeO1lzRNi3hsN2Bz194kJ4HMrJ08oV9Ff8S+bdkMaR0+/TYHer60pEm1 6Vc1kkFv9Ob7rlVzmGgcqzwQbiqxjwrAfuAfkEKETIa5AU6BmjHyvmcZQHRHKmk0AEKd g1oPQMnF7798L03W2lG9AiH3ZqQDoHjG2rpV4WATubx0nGxXBx1+Aj46Tk+pwkcY6kJg YS0tb7u474K2bZ4JRIds5vSLQe7FWjlpoOMB3u8/LbaIHfDCosF6egg4FjkvXO+Pz7Iz VmX+u02BUKAoSdoHzA4HWAVhGWQj+9IHwrSe/iccm/TkSfCUo8qOCGHBRbhIK6VGNivZ NGXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784509805; x=1785114605; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OVqOUuBVtydQxQUla2vfU1Oku0cw1BoRtkOvkgKRR7s=; b=fIe1edOruDWRQjjQImjB+AvvkcaH+/lMNI6nQP27Re02qVCi0lAkpA7KG9G5zuwpFW vwW1bdr7xjZjawn2mmM5MJZpleOD8hwVjDFGZ8FXdr5yDqaZlB6g0KyF+nhvT1c+lzUS lSoYlFzevHGp/lOnAydooQmv0VtlSJWD4zhGtnqX8r5mpTXQF5RAyvWBwoA/6GI1Ar+K hGynNFvClm0jJsXkqI5ZHWnq8QndZn42ifl+rBsj3OYS80G/pMpRy82DRwYoBsOS5B2x 4vruSXqXPUtw7W2gBcq9sg6w13vc+7NVI/Ef3fdryH0fxJ/D1S0iyExqVkL6o+KjKx4T BG1w== X-Forwarded-Encrypted: i=1; AHgh+RpHGUlI+Q4LN3wxIagjtjK04NEvYDdknwMMmMOWSBGQcyDu4LCACDwYbKaQ37ETJNRmz8GiCufV/QS2tcY=@vger.kernel.org X-Gm-Message-State: AOJu0YyTmyZnv2NFM3VvhvlvFWVE6d+DZW2wxoREMLKrYgZwDNL2d0dy w/3iFXKnhVebNfHtIVqzzGx46DyymeapBsZ/CYSq+/U7qjny0bprfz+HDZcr2GA50xpZ7v8jL3n rq9II6fWKT6G3uQNwWjBPZKeoNazxJngZOl5+yRy30J/FxN3yiWwJDzh+63slv2h315w= X-Gm-Gg: AfdE7cl9kW3wZmlJj1Rn/zRzZJOb7+/FFebDtqTvp4eNM043bhrnZOR6OALdOq61nBi cAK8caciwQK4/EvXy+CpOrFEULbNAiI6G3Y8HF18tVpLUfBBISzvJFHk7E20O+yMpYFIVLD2weO Ji/RpFrz0e9ClozzonYqlNQR6m7YuzAeGXi6+YE8k43GJI09yk8/OzTQPL/NviSRgumZpuSNHHn 19hY3T+AgYjb645W2ebar5pFtoGV2SRnGtEkTyFjZu3uCUPffSy1nTiq5T8Xk1HE6C0MbWdaaJa JEMTsHETbbO8rOaemMWcLlTkM4WngQnFly34GDndaNl0dVw9rrcigTZ3U6yPznQOSbBqCBKw8L6 SQo9XvjuFzBUGFYgn X-Received: by 2002:a17:902:d2cc:b0:2c9:97a7:f548 with SMTP id d9443c01a7336-2cf34a49278mr136309935ad.46.1784509805180; Sun, 19 Jul 2026 18:10:05 -0700 (PDT) X-Received: by 2002:a17:902:d2cc:b0:2c9:97a7:f548 with SMTP id d9443c01a7336-2cf34a49278mr136309295ad.46.1784509804384; Sun, 19 Jul 2026 18:10:04 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf347166e6sm46987155ad.59.2026.07.19.18.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 18:10:03 -0700 (PDT) Date: Mon, 20 Jul 2026 02:09:59 +0100 From: Jonathan Cameron To: Jorijn van der Graaf Cc: David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Siratul Islam , Luca Weiss , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: magnetometer: add QST QMC6308 Message-ID: <20260720020959.3d5e38cf@jic23-huawei> In-Reply-To: <20260714202842.340293-2-jorijnvdgraaf@catcrafts.net> References: <20260714202842.340293-1-jorijnvdgraaf@catcrafts.net> <20260714202842.340293-2-jorijnvdgraaf@catcrafts.net> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: SJbQ6RKACYUk994mGWUUI3vOpLMZ0bbA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDAwOCBTYWx0ZWRfX4LUar3u6g562 AnWwWzL9aiQiJJ6Gslfg4RlR/uvt97gXmWcdiJVSJSxndsi/BWdQwJSoGVz/AUpit4hrlVPiMad B3VKg9eQdB5+VUT0ZoFVHViEJ9miOI5EcCwxsua+N2XVN4lBXyRIFXo1+9dD4ZU4BXW78bUxOfm Er1D1QjfSXlcFwUX7+X7Yx2JXKiYfOjNJhIsaYhm5puTdleyCZdnGSMy/qXt+t4GZGroRqM+wdj IvFbe+Ss7eXEjKc0Wuarn6aOIImBX+Vrq+AvCsCqemetZhmuSPFrgRTjx0P1YWrFt+cQ9HUwDaD 1kvIYBV8bS0uYuLWsFItPm1zpxjLQK1XdWwV+j2MRLCSay316AA1eg+Evf9r1sSl9rqlxMOCpLA Jkl2UeMZxuVDrydByjgfGLLJlSMFS4vTRW+ywVrREex3b3BkwMTU20BZ27/aMOxeaO9ajCSR2Sk jfCMfPPiKCZK+XGsNig== X-Proofpoint-ORIG-GUID: SJbQ6RKACYUk994mGWUUI3vOpLMZ0bbA X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDAwOCBTYWx0ZWRfX3/N2jDgrLNx3 O1/+ifwzzm+hhZ6vQDozlDIfeqImYObk3dsIqb4DK8w2qSADghDODge3p5JroSlwnh0eAK9qoVl 1XCwE+NYXFpfTbiUHMQuqCT6J25oOEI= X-Authority-Analysis: v=2.4 cv=CJQamxrD c=1 sm=1 tr=0 ts=6a5d756e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=gEfo2CItAAAA:8 a=s-49AVHpAAAA:8 a=GYSh3LzNAAAA:8 a=XZePDpeZXBMwPD_SGuQA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=sptkURWiP4Gy88Gu7hUp:22 a=tmfrqOOcxroFHF4kknLN:22 a=lWcdFasyL5yHfcDTNXXo:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200008 On Tue, 14 Jul 2026 22:28:41 +0200 Jorijn van der Graaf wrote: > Add device tree bindings for the QST QMC6308, a 3-axis AMR > magnetometer. It is an I2C device in a 4-pin WLCSP package with a > single supply and no interrupt pin, at I2C address 0x2c. Hi Jorijn, As below. Don't think we care about the package (and manufacturers often decided to release in more packages if large customers ask for them). I'm not sure what AMR means, so please spell that out. A few really minor things below. > > Assisted-by: Claude:claude-fable-5 > Signed-off-by: Jorijn van der Graaf > --- > .../iio/magnetometer/qstcorp,qmc6308.yaml | 48 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml > > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml > new file mode 100644 > index 000000000000..ced839d2aac3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/magnetometer/qstcorp,qmc6308.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/magnetometer/qstcorp,qmc6308.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: QST QMC6308 3-Axis Magnetic Sensor > + > +maintainers: > + - Jorijn van der Graaf > + > +description: | > + QST QMC6308 3-Axis Magnetic Sensor on I2C bus. The sensor comes in a > + 4-pin WLCSP package with a single supply and no interrupt pin. Not sure we care about the package, but the rest is a good description. > + https://qstcorp.com/upload/pdf/202202/13-52-15%20QMC6308%20Datasheet%20Rev.%20F(1).pdf > + > +properties: > + compatible: > + enum: > + - qstcorp,qmc6308 Unless you plan to soon add other devices, can use the more compact. compatible: const: qstcorp,qmc6308