From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AB423B61B for ; Mon, 20 Jul 2026 01:52:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784512328; cv=none; b=S1rpkrkaTBP4GY7dfFAWscXtYwdfCIEhM4Xs9ESyqCA/P0K/5YljElsgoHkp4MPPU/Hcoq7q5Rvx3UjQfbs9JYPU9N7lWAgyofGbgG1giId/oLvPTd/XhWsKp6Mp/dqkacmtrPLawFJArWE9HVIzTgNqdfE9uOC9CUFMKKrjte0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784512328; c=relaxed/simple; bh=xNXV7CHiESp8Y3L4f5TERtE95DGHMAcJJRNNeGDpW5M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hlYl5upvoHDgL05YqM6piqz8gLzzRSyE3US8U3EpVZsfcTAQZWIRnQdiMGHV9wkv0xx+Qvs3DuowsITBq1P2+kgcT0zJSm9SNvE+/Z6EX7TPMHfc7qRcEvwrb2RJxF6ltQxvTb4XCWE2p1s5xdOGyYrkFZORAmrG5y0IVz0/OdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=osy6rR5y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WQoLRE1z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="osy6rR5y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WQoLRE1z" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66JNsFaq755937 for ; Mon, 20 Jul 2026 01:52:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= llldCrhMZsUoapQDDMXWdEP1Jj61RZlmintU0Qnmlas=; b=osy6rR5ywB4Cr3a1 Iw95ZF8oWf02fjzoER1AmERjZ5yQjk7TXKfybjRmiWH8Pz4EVWfvaatisa1TOEee 7nBzC7+MVqjIIw/lMLGgywdKlj58T0aQLkeCz8ClmWpszR8fDkTxHsy8ub5O/F9I K38J7MRKTUqJpVayckp6aQYpMq/64R3rAUFWDNE2jAaGXqJss4z5nap33RAjwlDK PJRjU0no6Apwjseebh51cLEfA/V9Xxld1xhO9GBh/Lijn0w1EzMhkmc9PaTsDtDJ OytVizGUdX71mquqEDMMkb/p7/o8z+VQBhp4xKSuhJQt9yM/xEYmPKxiVF2YquX8 vJlMiw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2bnkwf1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 01:52:05 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84a06bc82easo13900887b3a.2 for ; Sun, 19 Jul 2026 18:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784512324; x=1785117124; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=llldCrhMZsUoapQDDMXWdEP1Jj61RZlmintU0Qnmlas=; b=WQoLRE1zYlmBE1nrQ1+MnlFzvn12tNJv8ZMD4qRG+3fQ0dyMcTD+XOOS3jNSx2TbDc +g/s0XSWCxlrwomfQw69dhjl99iPYSouwk/ivpC8FgKVaYTZJSyMEUwsqE0yIWSKJ841 hQDv/4+g5l8ORZhysinJSwqaDGygrG7FqHkMXBav5mfv2zkU6H+T1r3ufplNaZr0l/mh 8ZZZE47TxMJmwAz+wlWvh/A50mYG+X5Zhwb6OU+KnBQKB/S2aYdMsrmXHL2gCqJ96PhK X7JlAysIMiEVU7ZSuB97GoU0lpeOsPivNrEhsKu/mP1ff4FLmtOO22DiIIinfj9+2T6V 0d0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784512324; x=1785117124; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=llldCrhMZsUoapQDDMXWdEP1Jj61RZlmintU0Qnmlas=; b=MJO3MUs1QYYTNqHJh0fqeEK1f851YYDebNL51QOvMZYMuavyGTxLdyRXMFT1yPe5SI 9zx52KtkquIfN5fJ86rCel1DFrXp2Zew3YYpkxSvqV9FT5Vil5lpY8WqunQulj7E9kEN mHNsaHm0pEDv5r/3KB/yLETjNLGnvdFIWuo3h39A9UiYfxQ5NeFezQWBa9Fq1Xuyy/BY 9OOsevrrYutTkau8sCClMTKdR8xVx6ZIhKVITyZKoodLbxe0lP19Nu+Ov2bpkT7ZqTmh Oul7yykE9d83Vo7GvAcphG8I+x4wd5AnwspgU8vk0+/T5AfCdUk9IkNL/aLwrWO9GodD q1rg== X-Forwarded-Encrypted: i=1; AHgh+RoxdTl+Xa5XG0dbjt8HKjSDauv8OSEGZwi+eg4DifRAcXI9zr06PfVmh3I6ghrORVl3aXYDqNFCfrUcOfk=@vger.kernel.org X-Gm-Message-State: AOJu0YwiAiNfu+JUEn2MPSHMvgD8IFUFOPlkLbRS1yib8CClVfwwU/fO yYEyhycrEOXQ9iqCdH5Y5PjNa1jHEohxHBi7JDqOV4TE8uG3dDJUN+JIlYstkoazJpjYwZbdZ7M rc17B1kaysDi90ZC8PxLeI+IVugxRyzFoa3cYAOVv7Yqe8+cvT7mZWeha6e3rux1M9sk= X-Gm-Gg: AfdE7cmMtAwB7YYVyUkPMr+NA4TeQ7qZ/oKCAheAePRDEEjyybJsqwWi1qbk6DkyCU+ Riv3aNg99Ju8PmAYCDsJlYmXI7L3l1uoC188bZqLiiSEW+tyaTc6g6zzjdUree4/YSCCPZvApKK xnNoiIYxqgra5EBCRLLmdnX7A7++lsDZMF/xFBnG3b9UxLZrthvEj2lxhvooPob0WmwBO2Y5ohQ cZIQdZErbz1lMKFMQumqbyV5lzXvkooBX6TCdZlkiM9Lidrnfij4aEII4pFEVdcs9yM9cpHo1uC slNJ/qAcLHJHkcK5hPBbX3Q4SHZzUYexvcDfBKqkoljB/Zd54wbJEXKzz+NSN2C7EUpcFGq9+tx nduIwE4AJD2HanumF X-Received: by 2002:a05:6a00:400f:b0:846:2f3c:3f68 with SMTP id d2e1a72fcca58-84c295116efmr11503036b3a.57.1784512324392; Sun, 19 Jul 2026 18:52:04 -0700 (PDT) X-Received: by 2002:a05:6a00:400f:b0:846:2f3c:3f68 with SMTP id d2e1a72fcca58-84c295116efmr11503013b3a.57.1784512323856; Sun, 19 Jul 2026 18:52:03 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af3176asm4746440b3a.34.2026.07.19.18.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 18:52:03 -0700 (PDT) Date: Mon, 20 Jul 2026 02:51:59 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: OrangeBlack0765@outlook.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] iio: light: tsl2583: migrate to sysfs_emit() and sysfs_emit_at() Message-ID: <20260720025159.284acebd@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Guq5aPs_FEAhU6JqMR3SjaLMwnQhOv0v X-Proofpoint-ORIG-GUID: Guq5aPs_FEAhU6JqMR3SjaLMwnQhOv0v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDAxNyBTYWx0ZWRfX3W/+VKIUBn2c gdS5dmEc9w9A5yNwnylCkPeII6XBkW3Gmv/z0Y2Rzrd0bkYkIcpzrrl+ZmJl8gffMtTj0/xIK+8 /odtLQ8yFM1a2oLbHbqOZq+vR9JVk/x9J77AKG2MUneqtJeNIuGYhesCepZcmZCbr6JODy3EPmF ahOhYXtnomYXmdN6Z3JkcuROxmpv25BEppMQmI2kYruds3Y4Rdix/1auD7FM9pZuCPvqz/Z7T2K 0ZKbln5vdq7e0P1pEbbsAJbjI8Sz5GjuHcvbdnrqBEZb4vmnQm7Ga9XTgPZaN657r8oNz5BisTt zJCUEgAbOmOS8EUnL3Fl+Qt/41YafywSArowPNTTLbOcGFF9s0g+5aBr6TSN7Nb3YyHHHy8AAby MfhvBJ+r79mw6k0Lu5YN6owkQA1geMrGtpwaupYtkOtXTdjxG5yruDcRyFUEIRjCZQ6T3EcW8GC BB3UFSIXlYqqIGg6DBQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDAxNyBTYWx0ZWRfX1fMpMyNpClE+ ibVjDkNJx37Hr3YOw/PKniBG8B5dmjudKK86J/O7peY+1XsEp9dVINRsH2jDtwk0dsa++zUjHgU jR4VON67+SWaxPG2YIwyjkwpw7uNOu4= X-Authority-Analysis: v=2.4 cv=YsQ/gYYX c=1 sm=1 tr=0 ts=6a5d7f45 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=QyXUC8HyAAAA:8 a=UqCG9HQmAAAA:8 a=NZmT1WVQbrE6cRaTRNQA:9 a=CjuIK1q_8ugA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-19_08,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200017 On Thu, 16 Jul 2026 23:12:15 +0300 Andy Shevchenko wrote: > On Thu, Jul 16, 2026 at 09:04:35AM +0800, OrangeBlack0765@outlook.com wrote: > > > Replace sprintf() with sysfs_emit() for single-value sysfs show > > functions, and use sysfs_emit_at() for lux_table_show() which > > concatenates multiple values. This ensures buffer safety and > > follows the modern kernel sysfs API. > > Now it looks good to me. > Reviewed-by: Andy Shevchenko > I applied this but for some reason seem to have failed to send an email to say so. It's on my testing branch. Thanks, Jonathan