mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lei Huang <huanglei814@163.com>
To: mchehab@kernel.org
Cc: johan@kernel.org, hverkuil+cisco@kernel.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lei Huang <huanglei@kylinos.cn>
Subject: [PATCH v2 00/17] media: s2255: Coding style cleanup
Date: Mon, 20 Jul 2026 10:54:29 +0800	[thread overview]
Message-ID: <20260720025438.207149-1-huanglei814@163.com> (raw)

From: Lei Huang <huanglei@kylinos.cn>

The previous coding style cleanup series failed during
integration by the Media CI robot because it depended on the
"media: s2255: Rename CamelCase goto labels to snake_case" patch,
which had not been merged independently in the linux-media community.

To resolve this, the goto labels rename patch is now included as
patch 1/17 in this v2 series, followed by the remaining coding
style cleanups. This ensures the entire series can be applied and
integrated cleanly as a single unit.

This series applies a series of coding style cleanups to the
s2255 USB video driver (drivers/media/usb/s2255/s2255drv.c) to bring
it closer to the Linux kernel coding style. The changes address issues
flagged by checkpatch.pl and general style review:

  - Rename CamelCase goto labels and remaining identifiers to snake_case
  - Remove unnecessary spaces after casts and parentheses around
    conditions
  - Use consistent braces on all arms of if/else statements, and remove
    unnecessary braces from single-statement blocks
  - Replace NULL comparisons with ! notation and bare 'unsigned' with
    'unsigned int'
  - Fix alignment to match open parenthesis and add spaces around
    multiplication operators
  - Parenthesize macro arguments to avoid precedence issues
  - Fix block comment style to kernel format
  - Add blank lines after function/struct/enum declarations and after
    variable declarations, and remove extra blank lines
  - Remove unnecessary return statements from void functions
  - Remove unnecessary debug logging and out-of-memory messages

No functional changes; the driver behavior is unchanged.

Lei Huang (17):
  media: s2255: Rename CamelCase goto labels to snake_case
  media: s2255: Rename remaining CamelCase identifiers to snake_case
  media: s2255: Remove unnecessary spaces after casts
  media: s2255: Use consistent braces on all arms of if/else statements
  media: s2255: Replace NULL comparisons with ! notation
  media: s2255: Fix alignment to match open parenthesis
  media: s2255: Remove multiple blank lines and before close braces
  media: s2255: Add blank lines after function/struct/enum declarations
  media: s2255: Add spaces around multiplication operators
  media: s2255: Remove unnecessary parentheses around conditions
  media: s2255: Parenthesize macro argument to avoid precedence issues
  media: s2255: Add blank lines after variable declarations
  media: s2255: Fix block comment style to kernel format
  media: s2255: Remove unnecessary return statements from void functions
  media: s2255: Remove unnecessary debug logging and out-of-memory
    messages
  media: s2255: Remove unnecessary braces from single-statement blocks
  media: s2255: Replace bare 'unsigned' with 'unsigned int'

 drivers/media/usb/s2255/s2255drv.c | 413 ++++++++++++++---------------
 1 file changed, 205 insertions(+), 208 deletions(-)

-- 
2.25.1


             reply	other threads:[~2026-07-20  2:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  2:54 Lei Huang [this message]
2026-07-20  2:54 ` [PATCH v2 01/17] media: s2255: Rename CamelCase goto labels to snake_case Lei Huang
2026-07-20  2:54 ` [PATCH v2 02/17] media: s2255: Rename remaining CamelCase identifiers " Lei Huang
2026-07-20  2:54 ` [PATCH v2 03/17] media: s2255: Remove unnecessary spaces after casts Lei Huang
2026-07-20  2:54 ` [PATCH v2 04/17] media: s2255: Use consistent braces on all arms of if/else statements Lei Huang
2026-07-20  2:54 ` [PATCH v2 05/17] media: s2255: Replace NULL comparisons with ! notation Lei Huang
2026-07-20  2:54 ` [PATCH v2 06/17] media: s2255: Fix alignment to match open parenthesis Lei Huang
2026-07-20  2:54 ` [PATCH v2 07/17] media: s2255: Remove multiple blank lines and before close braces Lei Huang
2026-07-20  2:54 ` [PATCH v2 08/17] media: s2255: Add blank lines after function/struct/enum declarations Lei Huang
2026-07-20  2:54 ` [PATCH v2 09/17] media: s2255: Add spaces around multiplication operators Lei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720025438.207149-1-huanglei814@163.com \
    --to=huanglei814@163.com \
    --cc=huanglei@kylinos.cn \
    --cc=hverkuil+cisco@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®