From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C483B71B0 for ; Mon, 20 Jul 2026 07:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784531546; cv=none; b=KhB8IluV75XxpfwTzMD4KoyUUoP2aFzkNVx496euhBzHiyuWkULDeurBEmgDLvoNErAawrdF5CZf9dxPr+zFxmsyxv9/9YrcK7EiiZzo4Rq5oeesCHFLvpIBbJMXV0z5+xsk20+u1ojwrpe8cYPd74JlTmFzrvnQj2JAaxnC8oc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784531546; c=relaxed/simple; bh=EXCjve+H7kwZBpRpsb4Py+6z5Qb+Fk2NdZFptofcy8w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eBWaalvY2ngYS2Bh4GQmJrl9AiQUyQZx0lzPPbaxzfsEvJ4yxmBJJ8Gk1D8z/XbCYju2LtJvxNwHr7t8LSWzULvbTrzfsplIowr8Kgi8qKXgKtqZKPrIHuA/hlhpiw5+H/AZ6a+22pmUv/L5sIV9RZQRWUyc6Hs0E1rhNfNsM5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.198]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4h3Wsl6N9czYQtgd for ; Mon, 20 Jul 2026 15:11:55 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id 1D17040664 for ; Mon, 20 Jul 2026 15:12:21 +0800 (CST) Received: from huaweicloud.com (unknown [10.166.163.161]) by APP1 (Coremail) with UTF8SMTPA id cCh0CgCX829Syl1qcOqKBw--.35642S3; Mon, 20 Jul 2026 15:12:20 +0800 (CST) From: Kemeng Shi To: maz@kernel.org, tglx@kernel.org, jason@lakedaemon.net, lpieralisi@kernel.org, radu@rendec.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kemeng Shi Subject: [PATCH v5 1/4] irqchip/gic-v3-its: Fix memleak in its_probe_one() Date: Mon, 20 Jul 2026 15:12:12 +0800 Message-Id: <20260720071215.50705-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20260720071215.50705-1-shikemeng@huaweicloud.com> References: <20260720071215.50705-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:cCh0CgCX829Syl1qcOqKBw--.35642S3 X-Coremail-Antispam: 1UD129KBjvdXoWruF4xXFW5Cr17Cw1xXr43Jrb_yoWDCrX_C3 4fWan7GFWI9r18GwnrJw4fZFyDGa1v9F18ZF4Fy3Z8tryxZw1kCFZrWas8AF4UWF4jva4f AFZY9r1Ikr1IyjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6xFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGwA2048vs2IY02 0Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1l84 ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY1x0262kKe7AKxVWUAVWUtw CF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j 6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64 vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0x vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUfDGrUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Fix collection leak when its_init_domain() failed in its_probe_one(). Fixes: 4c21f3c26ecc2 ("irqchip: GICv3: ITS: DT probing and initialization") Signed-off-by: Kemeng Shi Reviewed-by: Radu Rendec --- drivers/irqchip/irq-gic-v3-its.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 291d7668cc8d..d721b6101e0a 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5326,7 +5326,7 @@ static int __init its_probe_one(struct its_node *its) err = its_init_domain(its); if (err) - goto out_free_tables; + goto out_free_col; raw_spin_lock(&its_lock); list_add(&its->entry, &its_nodes); @@ -5334,6 +5334,8 @@ static int __init its_probe_one(struct its_node *its) return 0; +out_free_col: + kfree(its->collections); out_free_tables: its_free_tables(its); out_free_cmd: -- 2.36.1