From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928E53B7747 for ; Mon, 20 Jul 2026 07:20:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.194.254.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532029; cv=none; b=gH/LlS4IqqA1GzyYgm/LL1bT6XYu+gj8/nFfsrKSGaXA9gjDDMtpMOHknqPwHX7oyEQZNA78iXXswBP+yCfZYhqhuzY8b7uUmEmqzlFf0l1+aCtmBGNBPALGQp6uQr4NDLOdXGS5zryEZoZB76tfWRHAS1PX9WFMuknLbEkeq58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784532029; c=relaxed/simple; bh=sM/p5FyUXpwYz4sUVk5Vsp4NlwnYDwfyC7JyTLIKVjs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fo6T5y67DmWQEcJYx3znFuoeVYkdKmdKzsGOwrEJRsPnx+wbtBryxk41JdcbKUumFE/ycvFwB+g0cJnyF1izMXr3h0v86APm/NAkLqrKaDqV5odfQIDnxg7M5HktScm2sCjZH9VGiMC3YsNlwT2aKAn3lLSjME48XdIk7QtQKuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=Dz9YWgNu; arc=none smtp.client-ip=18.194.254.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="Dz9YWgNu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1784531966; bh=tIQC72hPohO5MdyCEUkKF6Dc4FUOXarb7A6cgM6I2Gs=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Dz9YWgNuU5hTFfr+kd5ANon8Ltov2+KZuagz/4NFE/aDYLnlSjq78A1yhhy3U6n6E WWW8k57bAG5koPNzvqyy0sikyNxZvRi4IJbWiMbWCMsbH3228Nbgu2DyF3IUTaKBG0 0PyXeov/GLjdKmTngCTGSdendWYLYLn3gAkr8LLI= X-QQ-mid: zesmtpgz7t1784531949t87c9e98a X-QQ-Originating-IP: skF274xtqZxCW0zkSPWvhaZPU8kqux4Sd3OnVjdaCTc= Received: from uniontech.com ( [113.57.152.160]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 20 Jul 2026 15:19:07 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 3588568058455700877 EX-QQ-RecipientCnt: 8 From: Yichong Chen To: akpm@linux-foundation.org Cc: chenyichong@uniontech.com, david@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mike.kravetz@oracle.com, muchun.song@linux.dev, osalvador@suse.de Subject: Re: [PATCH] hugetlbfs: release subpool on fill_super failure Date: Mon, 20 Jul 2026 15:19:06 +0800 Message-Id: <20260720071906.1388412-1-chenyichong@uniontech.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260719225438.041287a56c87effe61796483@linux-foundation.org> References: <20260719225438.041287a56c87effe61796483@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:uniontech.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: NPkjkILWyNMcQcxblSPVW6k7LLoYITpO19mVcVtZ/9At4+EdSXVR1dSV XUk9Y43Z4n3ADzKG8qafLAzi0F30FKM9o0cKOIyBFVIy1usnuCmrTwnNge4jn+ewN0mLKet 06nFO99/IRr6PKOQQGElaw+u30QvRkiXgJWh7bMIwetZMX4fAzpOyuT4S1eYefrC4z7uJgD MEXMJJ6DfGSD4trF5FDV9QeNg26s5oT/fpVR13eFpiVotk2sy26WQe7altxQzN4tYElNNXJ JvsYY7d7+5/dKiJ2EnNd+wSB9Yl0zsGP8CDfk2Babg/H5vwN3ymWRjm5JZwzkC3EocRSy/y 9vXNMcfyT9P2v+YbcX5ETyIfwfOpNsoivpuCoUsjIXDVV50CE/8Z3D72Ecqu1ogSk3n5Aw3 PZKZTjm++qSNB9sR7tXkqmUfaxsjZpm0u+pLgca5sXWTJck0xumGknyI+YtNkDbMqNDMZvw fKzHclLQ+wXcSJUeTyjJBDPLEFHIDIWNQcPtA8UcaBpH+zjUoCwqpU1HKY7LjsaxwqRd10b leph3G4mxFhoUFSmpCvgsj8f5DNAF+jHDKSpTW6L8+NgYMUf2qdIsHU2SyUxavF9esGJ+Mt ULqtyTVWYYc6uBumWkE4GSzAbt31ztDsNW0PPqqAldcA+1zA8/W4ZaafMdl44xgI9zzNcLx cQ0ER19gCN9YGHutkMBsPLl0hiv9390VusZiuLbeqZ9kPgsr3DsmWgW6SWFIlS49N+ka3Xa mXDS73KEUDDxwT80Fd3D6CNzT34/wZdbvAgeslTK++W57KzUiUQeU0HeIhrBd3M+diiVzeT 7/CBkyJK7FwfwcxEeLOJNy3cNjvdlw5z5xYlezuOoAhQMR/euge+jgTZ/EV5AT25qM5JRIb I9e0DL/DxVsQ5QF+skWY0Z2djrqH3b7dUVkPoOiJ4IeDjL+Ug/Kq3axfrAU1ep/KtatXrgR 8hOi2D4gTc7GLKiUWs9sCt9Butrb6m7rn0bVLbSkjmYyHfso7Zn4QSWVMLciq+2j4GuD8cX 4ax6eku520yM5ouXXk75HSvlyRItxCfRQeyX8joiwAba35LPqP5F7CD0E/aDKI4eTJBSCw1 FFGGLoWT/9bLEWgiZw6G/E= X-QQ-XMRINFO: MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A== X-QQ-RECHKSPAM: 0 Thanks, Andrew. Yes, moving the NULL check into hugepage_put_subpool() makes sense. I'll send a follow-up cleanup patch for that. The Sashiko comment about unlock_or_release_subpool() also looks like a separate pre-existing race to me, so I'll look at that as an independent fix. Thanks, Yichong