From: Pan Chuang <panchuang@vivo.com>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING
LIST), linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 4/7] soc: qcom: Remove redundant dev_err()
Date: Mon, 20 Jul 2026 17:59:10 +0800 [thread overview]
Message-ID: <20260720095920.542801-5-panchuang@vivo.com> (raw)
In-Reply-To: <20260720095920.542801-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/qcom/qcom_aoss.c | 4 +---
drivers/soc/qcom/smp2p.c | 4 +---
drivers/soc/qcom/smsm.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 259c41f0c34e..a6b673cd7678 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -602,10 +602,8 @@ static int qmp_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0,
"aoss-qmp", qmp);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret < 0)
goto err_free_mbox;
- }
ret = qmp_open(qmp);
if (ret < 0)
diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c
index af0ceeaf6e07..6f07fef40ce8 100644
--- a/drivers/soc/qcom/smp2p.c
+++ b/drivers/soc/qcom/smp2p.c
@@ -720,10 +720,8 @@ static int qcom_smp2p_probe(struct platform_device *pdev)
NULL, qcom_smp2p_intr,
IRQF_ONESHOT,
NULL, (void *)smp2p);
- if (ret) {
- dev_err(&pdev->dev, "failed to request interrupt\n");
+ if (ret)
goto unwind_interfaces;
- }
/*
* Treat smp2p interrupt as wakeup source, but keep it disabled
diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c
index 021e9d1f61dc..396025074e1e 100644
--- a/drivers/soc/qcom/smsm.c
+++ b/drivers/soc/qcom/smsm.c
@@ -451,10 +451,8 @@ static int smsm_inbound_entry(struct qcom_smsm *smsm,
NULL, smsm_intr,
IRQF_ONESHOT,
"smsm", (void *)entry);
- if (ret) {
- dev_err(smsm->dev, "failed to request interrupt\n");
+ if (ret)
return ret;
- }
entry->domain = irq_domain_create_linear(of_fwnode_handle(node), 32, &smsm_irq_ops, entry);
if (!entry->domain) {
--
2.34.1
next prev parent reply other threads:[~2026-07-20 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 9:59 [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 9:59 ` [PATCH 1/7] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-20 9:59 ` [PATCH 2/7] soc: ixp4xx: " Pan Chuang
2026-07-20 9:59 ` [PATCH 3/7] soc: mediatek: mtk-svs: Remove redundant dev_err_probe() Pan Chuang
2026-07-20 9:59 ` Pan Chuang [this message]
2026-07-20 14:32 ` [PATCH 4/7] soc: qcom: Remove redundant dev_err() Dmitry Baryshkov
2026-07-20 9:59 ` [PATCH 5/7] soc/tegra: cbb: " Pan Chuang
2026-07-20 9:59 ` [PATCH 6/7] soc: ti: wkup_m3_ipc: " Pan Chuang
2026-07-20 14:17 ` Hari Prasath G E
2026-07-20 9:59 ` [PATCH 7/7] soc: xilinx: " Pan Chuang
2026-07-20 15:50 ` Pandey, Radhey Shyam
2026-07-21 5:49 ` Michal Simek
2026-07-22 2:23 ` Pan Chuang
2026-07-24 16:38 ` (subset) [PATCH 0/7] soc: Remove redundant error messages on IRQ request failure Nishanth Menon
2026-09-01 2:09 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720095920.542801-5-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®