From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66CB83DB31A for ; Mon, 20 Jul 2026 10:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544044; cv=none; b=KyCsPGUFRme1G2ZDA2mH/1vBYQtVdDeo+5V+twm/Y1YnqeJ7WEvIODeiFtivrj+eHaOU+B1j6vZ0Sp0J71WMHhD3a4ksWr/7hgmU7fIEMqlFqXfxIlBFlFnVAvBGJ1PT/GAyhPANRcB2FkzTiJqDKm6nVOGlzy6MhVmz2yPdi68= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544044; c=relaxed/simple; bh=UnAsh3CjibL9YdkOiPk87mzPv+ZX5WAu6yNK19PE3Es=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Sl3vtgY8DfzTiYUG9xrRr+1fHKmtIroNfKQ2eQ8GJ7pXEdTSr8ZhkJzCMa6qrH0tluwaPgvXKUvmOCRKXwFXeLa2ZOay/RH7FTIVC2pWmFYzeyc0OyGBc3VIUMlD6GejlvyuyDi0ssRzB87o/7EMNZ2eglNRPFnwZFWAvIyXOuw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2cc97653887so108682975ad.1 for ; Mon, 20 Jul 2026 03:40:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784544041; x=1785148841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ECUv2OBEiZbNwjfMV3/65e/S6w3Th/UZLtjgLjuN8Rg=; b=AS6XqTttG1RMJTzEkpXdMHGa8RAIabf50Lwhs+dstLSxTlB1Fqe8oXQUk+qjTZ8U4A gWY+bZvhqaF63AaQDqeLLa89O4DPDVggX4/8zCZejJk0VrSGXWbvDgF/b4W9PcDGfVmx W1czhbJvmytpUFEuHHcdtHq4gKQir1SLTRvzUFJO/v5ks2v2S3/Z6dCzXV9zu5foW57t prxIFB9BXhIVOODjZrWTsXyrxVyreNys6h+yhecaOGUOVKeZoYdGAn9CoKwph5dylMCJ M0NleuiBStJUabiuJpGnKYYvlKoljryjrPtj7Xs7JpF8/3XyJ7LRsAZ6aZqWx6xHHpe+ yctQ== X-Forwarded-Encrypted: i=1; AHgh+RqPiXSJWS+8ZfgArPhfVnzJ9hKuT5PPtOI1Wr9bXzphPo62oNRgtyQ7kjhKxLs62voI7LuT2dNMQnojUuU=@vger.kernel.org X-Gm-Message-State: AOJu0YxDdtXG0bp4P06NP6+MfKccljrH1rddVnNDYYK1OtTBHaYAibQd qnLMpOot9WVYq1XEFEHIHwTxP3xMT99ZZqYUqfq8Mc4mM1Yp7aKUkYU= X-Gm-Gg: AfdE7cltBp7SnhspfovsFiaXwbHhvUzW2hkNveMkli+B327B1QIRyafH8lcEZB34npD 4k777JXutOtgIHj8RGbgMOFZ5A+9AxXIhPZygvp25O7ethJpjMYTNRV4CjTMvqI2PmKqZk/rXBA Q4272VoR/ejUeJoKUXONJJKUHOoDNnKUgVe0L0ChlPL13g2fY7SiM6mjtoKlgx1ooO78H4VbPp8 HRsGcoM5/sNnnW0b6ZadmWVsZpZUSBZr18pfXcWmO7SUutlyWRRGR0LFV1GyQ5k1wOTWwZD3Dz4 wGOYt7xWVCDmsRCI9mCTEFXS3FowgqA8o8Az3PLi2hSP9h8hveWMCH2U17tmTz6zL68rbjprHib JcYRpaoW0dUYTy8+R5GiPqJWzwaB5TPrqGIlywjY/bUlk0rFjey/FgXGoVluSb/YEsP1+fBUeXQ PyfFUnYDZQf4GAIk+ZqYZJPn9MjfPojUgX/07m5P85Ku5t1OdwSt0We17+pmDPnawmq8clfBLjo So5RMYwlcdmCOndsU65bTiDsJ4j X-Received: by 2002:a17:902:f70d:b0:2ce:bb47:6f3c with SMTP id d9443c01a7336-2cf349c262emr151302235ad.34.1784544041432; Mon, 20 Jul 2026 03:40:41 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-16-100.dynamic-ip.hinet.net. [61.228.16.100]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344f61ffsm54900325ad.33.2026.07.20.03.40.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:40:40 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: Andy Shevchenko , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v15 3/7] spi: pxa2xx: overhaul teardown and suspend sequence using pxa2xx_spi_off Date: Mon, 20 Jul 2026 18:40:25 +0800 Message-Id: <20260720104029.13740-4-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720104029.13740-1-fourdollars@debian.org> References: <20260720104029.13740-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When removing the driver or suspending the device, the clock must not be disabled while shared interrupts are still active. Gating the clock before waiting for in-flight interrupt handlers to complete results in race conditions where the handler performs unclocked MMIO accesses, causing PCIe Completion Timeouts. Overhaul the remove, suspend, and runtime_suspend paths to use a strict synchronized teardown order: 1. Disable hardware interrupt generation at the controller level. 2. Mark the device state as suspended (suspended = true) to prevent subsequent interrupt handlers from attempting MMIO reads. 3. Call synchronize_irq() to wait for any active interrupt handlers to drain completely. 4. Gate the clock via pxa2xx_spi_clk_disable(). Additionally, commit 29d7e05c5f75 ("spi: pxa2xx: Avoid touching SSCR0_SSE on MMP2") documented that disabling the hardware block via SSE on MMP2 SoC platforms corrupts the RX/TX FIFO. Instead of calling pxa_ssp_disable() directly, use the helper function pxa2xx_spi_off(), which respects the MMP2 platform quirk by bypassing SSE register writes. Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx.c | 49 ++++++++++++++++++++++++++++++++-------- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index d4a9a48c2624..64b5ec744756 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1495,16 +1495,24 @@ void pxa2xx_spi_remove(struct device *dev) spi_unregister_controller(drv_data->controller); - /* Disable the SSP at the peripheral and SOC level */ - pxa_ssp_disable(ssp); + /* Disable SSP interrupt generation on hardware level while clock is active */ + pxa2xx_spi_off(drv_data); + + /* Mark as suspended to prevent further IRQ handling */ + drv_data->suspended = true; + + /* Wait for any pending interrupt handlers to complete */ + synchronize_irq(ssp->irq); + + /* Release IRQ */ + free_irq(ssp->irq, drv_data); + + /* Safe to disable the SSP clock now */ pxa2xx_spi_clk_disable(drv_data); /* Release DMA */ if (drv_data->controller_info->enable_dma) pxa2xx_spi_dma_release(drv_data); - - /* Release IRQ */ - free_irq(ssp->irq, drv_data); } EXPORT_SYMBOL_NS_GPL(pxa2xx_spi_remove, "SPI_PXA2xx"); @@ -1518,10 +1526,11 @@ static int pxa2xx_spi_suspend(struct device *dev) if (status) return status; - pxa_ssp_disable(ssp); + pxa2xx_spi_off(drv_data); + drv_data->suspended = true; + synchronize_irq(ssp->irq); - if (!pm_runtime_suspended(dev)) - pxa2xx_spi_clk_disable(drv_data); + pxa2xx_spi_clk_disable(drv_data); return 0; } @@ -1529,6 +1538,7 @@ static int pxa2xx_spi_suspend(struct device *dev) static int pxa2xx_spi_resume(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); + struct ssp_device *ssp = drv_data->ssp; int status; /* Enable the SSP clock */ @@ -1538,14 +1548,27 @@ static int pxa2xx_spi_resume(struct device *dev) return status; } + drv_data->suspended = false; + /* Start the queue running */ - return spi_controller_resume(drv_data->controller); + status = spi_controller_resume(drv_data->controller); + if (status) { + drv_data->suspended = true; + synchronize_irq(ssp->irq); + pxa2xx_spi_clk_disable(drv_data); + return status; + } + + return 0; } static int pxa2xx_spi_runtime_suspend(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); + pxa2xx_spi_off(drv_data); + drv_data->suspended = true; + synchronize_irq(drv_data->ssp->irq); pxa2xx_spi_clk_disable(drv_data); return 0; } @@ -1553,8 +1576,14 @@ static int pxa2xx_spi_runtime_suspend(struct device *dev) static int pxa2xx_spi_runtime_resume(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); + int status; + + status = pxa2xx_spi_clk_enable(drv_data); + if (status) + return status; - return pxa2xx_spi_clk_enable(drv_data); + drv_data->suspended = false; + return 0; } EXPORT_NS_GPL_DEV_PM_OPS(pxa2xx_spi_pm_ops, SPI_PXA2xx) = { -- 2.39.5