From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AEF73DDB19 for ; Mon, 20 Jul 2026 10:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544054; cv=none; b=O33ogvhMGCRTSGI3l0HEA+rfKDMvovgU+M+jGpkNvkjRKiUJmUI4fUKD73Zvb5TVONLzDLEse3uvBaq3f83QJue7u5CD6FKIFBmKn/Q9vigpJdM5b5PBELDBDe/tyKjYlyE71rYWvtN1EGWDyjcvsYhPKsUYxEdAFj5N0ePoAfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784544054; c=relaxed/simple; bh=1VOB5qihoLYvUrKgDurvNJnb5E6H9r/MCX/C1s4p2D8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CmmArjPtjKKyTLIEzyHYqyMCKNEqx7nS780juVYDZUP2kMnaCXsQJY6fL/JEdpkYPmPSZx2o3lLxUsSkGoWer5IPWDY6NOXJqR0h6PRF0byxrFvr4xy5YCzy7GRyUbSbEIg/96csUG7UyexXOsOMWV/5MQ0yaZITadHFFkz3gTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ced3386430so62751045ad.1 for ; Mon, 20 Jul 2026 03:40:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784544051; x=1785148851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5cHJ+v/E14jZBDLKhft+LTxzEaKtkH3VvD3xnlIFMVc=; b=StfGof2j1RYtnADd7fO3b4km3yIjri6cgK1BF6W/QvxjbP+sqLJEtnVPP+KHQC2xOS 7gA4N4f17CBA3DZIzvIaTU1zsB4jueFYe4zw97DUO4KvZEaPmbAmN63tclryhSxwlaz5 F+YFIpgLRQNj36p19J6M+68JHxPNf42Av0UruJsa7Kyz9KPASpTyK/Tp2OnLc4sd78st RPm95nTxHa03CReCanbJCGetv+wGby7xk5VIJ5lqnLK7mGbs2qb9rFj/WxP5LJ/iAkAQ mmE7JQADJeRaJ2q5y8oJsN6u83kjw2jU48sNDwj6Kas7+3Ab0Koxyes8MidHrdP/Fu+m H/fg== X-Forwarded-Encrypted: i=1; AHgh+Rr3UVGHGUeG26ksVcx8iiaYNhe1AO3/BjL8MnR5Pl2zb6sMTZS5W2MB2UKYyDt1s6gtq8rIvjV2cii2020=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn2jlSta2IHj37/DrvXzYxfWhPww2Z8h6u983G9lJ6PM6nZEvj WOc1KJN6S0wWq0DNrUj5GRZKZaA/VRatJIACtXm254jYQwHoA0b5jCI= X-Gm-Gg: AR+sD13VTHbgBed3k1c+3bd1CJqRUjYkQ//+s6G2X9cj/jNovocbBLmZQyMgEoe0Hj8 H/vRFZt5qw0HPsV3C43KKTQoBNIAJhGv8CdYEvlVfkZu18aAWUdpRbzb9k+uONVfBxVcZyQVJyp ErCQFD1YhBFUT9tm+M15UFgo4meEiRQnrgO7rcFzA0hvjCu+pkJC4XDC0A6F6WkodRZ2CjrCS5g U+as7XHSWBA7pRauLqzgRW30f3HXpRWIHXuv4Lp0ascg4rNxbdzjg3QCmexPZKTFqesxvBC2afn Jk64vxZv/NvPnsD2vDTPvYUHJ2Ab6AlTx5graCm4Gon/06ikKZ9+r2d6SDM77ugvcIN4JWoX0bG oMQ9ly97MuGr/UtMiijFbVzHJyYMdUNR709BE+xPIQLu86cN8YUpVGtcJVNS926gxWpdgADCZAK 3ek3HuntcG8widdmkoZbc11wZXfovXGFj64xscFALQ/arMktLzWX5DSOLPtphER6w13lB5oQ4+l hz6W7bsuVcH+pXzew== X-Received: by 2002:a17:902:e80a:b0:2c9:fc14:588f with SMTP id d9443c01a7336-2cf3494afc3mr150265455ad.29.1784544051064; Mon, 20 Jul 2026 03:40:51 -0700 (PDT) Received: from penguin.tail0a1999.ts.net (61-228-16-100.dynamic-ip.hinet.net. [61.228.16.100]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344f61ffsm54900325ad.33.2026.07.20.03.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 03:40:50 -0700 (PDT) From: Shih-Yuan Lee To: Mark Brown Cc: Andy Shevchenko , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Shih-Yuan Lee Subject: [PATCH v15 7/7] spi: pxa2xx: rename local status variable to ret Date: Mon, 20 Jul 2026 18:40:29 +0800 Message-Id: <20260720104029.13740-8-fourdollars@debian.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720104029.13740-1-fourdollars@debian.org> References: <20260720104029.13740-1-fourdollars@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the return value variable name from 'status' to 'ret' in the pxa2xx_spi_probe(), pxa2xx_spi_suspend(), pxa2xx_spi_resume(), and pxa2xx_spi_runtime_resume() functions to conform to standard Linux kernel coding conventions. Signed-off-by: Shih-Yuan Lee --- drivers/spi/spi-pxa2xx.c | 62 ++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 56e434f6e794..612361ffe6dc 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1313,7 +1313,7 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp, struct spi_controller *controller; struct driver_data *drv_data; const struct lpss_config *config; - int status; + int ret; u32 tmp; if (platform_info->is_target) @@ -1372,8 +1372,8 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp, /* Setup DMA if requested */ if (platform_info->enable_dma) { - status = pxa2xx_spi_dma_setup(drv_data); - if (status) { + ret = pxa2xx_spi_dma_setup(drv_data); + if (ret) { dev_warn(dev, "no DMA channels available, using PIO\n"); platform_info->enable_dma = false; } else { @@ -1387,16 +1387,16 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp, } /* Enable SOC clock */ - status = pxa2xx_spi_clk_enable(drv_data); - if (status) + ret = pxa2xx_spi_clk_enable(drv_data); + if (ret) goto out_error_dma_alloc; drv_data->suspended = false; - status = request_irq(ssp->irq, ssp_int, IRQF_SHARED, dev_name(dev), + ret = request_irq(ssp->irq, ssp_int, IRQF_SHARED, dev_name(dev), drv_data); - if (status < 0) { - status = dev_err_probe(dev, status, "cannot get IRQ %d\n", ssp->irq); + if (ret < 0) { + ret = dev_err_probe(dev, ret, "cannot get IRQ %d\n", ssp->irq); goto out_error_clock_enabled; } @@ -1477,23 +1477,23 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp, drv_data->gpiod_ready = devm_gpiod_get_optional(dev, "ready", GPIOD_OUT_LOW); if (IS_ERR(drv_data->gpiod_ready)) { - status = PTR_ERR(drv_data->gpiod_ready); + ret = PTR_ERR(drv_data->gpiod_ready); goto out_error_irq_alloc; } } /* Register with the SPI framework */ dev_set_drvdata(dev, drv_data); - status = spi_register_controller(controller); - if (status) { - dev_err_probe(dev, status, "problem registering SPI controller\n"); + ret = spi_register_controller(controller); + if (ret) { + dev_err_probe(dev, ret, "problem registering SPI controller\n"); goto out_error_irq_alloc; } if (is_lpss_ssp(drv_data) && !platform_info->enable_dma) pm_runtime_get_noresume(dev); - return status; + return ret; out_error_irq_alloc: free_irq(ssp->irq, drv_data); @@ -1504,7 +1504,7 @@ int pxa2xx_spi_probe(struct device *dev, struct ssp_device *ssp, out_error_dma_alloc: pxa2xx_spi_dma_release(drv_data); - return status; + return ret; } EXPORT_SYMBOL_NS_GPL(pxa2xx_spi_probe, "SPI_PXA2xx"); @@ -1542,14 +1542,14 @@ static int pxa2xx_spi_suspend(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); struct ssp_device *ssp = drv_data->ssp; - int status; + int ret; - status = pm_runtime_resume_and_get(dev); - if (status < 0) - return status; + ret = pm_runtime_resume_and_get(dev); + if (ret < 0) + return ret; - status = spi_controller_suspend(drv_data->controller); - if (status) + ret = spi_controller_suspend(drv_data->controller); + if (ret) goto out_put; /* Disable SSP interrupt generation on hardware level while clock is active */ @@ -1582,19 +1582,19 @@ static int pxa2xx_spi_suspend(struct device *dev) out_put: pm_runtime_put_noidle(dev); - return status; + return ret; } static int pxa2xx_spi_resume(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); struct ssp_device *ssp = drv_data->ssp; - int status; + int ret; /* Enable the SSP clock */ if (!pm_runtime_suspended(dev)) { - status = pxa2xx_spi_clk_enable(drv_data); - if (status) + ret = pxa2xx_spi_clk_enable(drv_data); + if (ret) goto out_put; } @@ -1639,8 +1639,8 @@ static int pxa2xx_spi_resume(struct device *dev) drv_data->suspended = false; /* Start the queue running */ - status = spi_controller_resume(drv_data->controller); - if (status) { + ret = spi_controller_resume(drv_data->controller); + if (ret) { drv_data->suspended = true; synchronize_irq(ssp->irq); pxa2xx_spi_clk_disable(drv_data); @@ -1651,7 +1651,7 @@ static int pxa2xx_spi_resume(struct device *dev) if (!pm_runtime_suspended(dev)) pm_runtime_put_noidle(dev); - return status; + return ret; } static int pxa2xx_spi_runtime_suspend(struct device *dev) @@ -1668,11 +1668,11 @@ static int pxa2xx_spi_runtime_suspend(struct device *dev) static int pxa2xx_spi_runtime_resume(struct device *dev) { struct driver_data *drv_data = dev_get_drvdata(dev); - int status; + int ret; - status = pxa2xx_spi_clk_enable(drv_data); - if (status) - return status; + ret = pxa2xx_spi_clk_enable(drv_data); + if (ret) + return ret; drv_data->suspended = false; return 0; -- 2.39.5