From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 229E53FC5A6 for ; Mon, 20 Jul 2026 12:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549812; cv=none; b=FGi0Gv4ckiKNsgqw34LbMV5rCluo+XnYGEv2UDMI6wKU/QqI/S01+QcYSL4zEOql3B9DYkaJySvHJTAtWTW4vosr87bds+mt6ocvT4VoBRpjcP427o1RZaSVHwm/Bsrg/4lGYRYmLsMay3u1Yb5CqWvmdw8ESg/aI5F3hjZmQcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549812; c=relaxed/simple; bh=GNBE2liKm+5zfWQReyex3ayP0llhtabHxVp/9yZvKas=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IcyRLbjMeKsP6Y1k0BfTUXuVreJZe+LiuyNxr0dNgIioKMlTMNzKrYEZYvyet8D5SLSYjHU38cl8zsaAZ9X0IgooKm1NB2UFHAb51W9pbH+VHmLbQ3s2zCvBSPUFLEvjHzHGGuwq5yvSLhk3bzTtDsqBwG+mlffYrbcNHsVH658= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GYORA8pM; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GYORA8pM" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f7444576cso790315f8f.0 for ; Mon, 20 Jul 2026 05:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784549803; x=1785154603; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7/LTElIKYlWpTL73YwXYvJE766LImzThDSV5rDtI7NY=; b=GYORA8pM/IKUnD+g9xwC67LWFvvB7lM3eS5mqxTYnhRHt/0eCTbLlxta7uGCIljK1Y CxcsRuzsDF7TLvr4jUDCQ0hZe07+5mcXaMa4MkDvNieUoqdb5mGnrILCX5FHQ8rF2SY2 5Ss/xJe7H2WDUGOi5DDIBUkj8QCa8ExSZv8kISq70XsIU5J/iz/MLvhgTGhp4MLY5nQ7 I1cV0EJqo9nS/EGPoH7bfXcaPaM8720QyJ2chJgxwwItVeVj4VMGhTd9RK9lAArT8Vyf GmYbnnUhjOybZcwZaCdXhkr916nnKSs53JebGmamJxQm2/BIeg4PxjCpthqUvmN1/dO3 0Utg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784549803; x=1785154603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7/LTElIKYlWpTL73YwXYvJE766LImzThDSV5rDtI7NY=; b=mxD+NjP3hCZDz1eqQMMV577kx7sa6e5PMm0Df0Pxdy3Dv0f4GdVXWkN5Qx6pFWySUt 3XMriLudE3Uqr1U3Ky3VBHvMSwJ7Y/gA57fMo+l8FhuoQnRMbuJJriu/+Lyz2AK+tCVx 3cPRKT7ADmMI2x380FUPXgcJ7de5CEGv/jJZNAjP7gWhlCwmq7X66y2sIqnDVsr/hjW2 S1BPdtPKM2ZswSeXRFtenquMOaPlmJmazXi4f5rkVEuBwEh8UwBQPIOO1rA2OObMWhB8 bskVhFYkt4nNWsVQnf4W7Vhgnh8IPh3/r7Hr2m3HnkXPSRzCAddDQb8+cuGzzL/xUh73 71NA== X-Forwarded-Encrypted: i=1; AHgh+Rp1bFBPi8dYGDVVwWvp80D5Hnk2Fevne4dvpQRz5L1WNqLKLt+hwOB/98uPTeewraDSGReBzgh4lZMlvxc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+wKbCCGKJj86kAmuQsu8uIIj/hcrQU0uk3PctNyVFZ1VK3Y8s DcEL5Yv7z5irUu1Cg1rbHVb3X0eJzrAHAdKc3OXKXW5pSPFVc0zEtXfSS+ExVf5S6p8= X-Gm-Gg: AR+sD10Wj1tXnAV/gbM7H6x/Mi8yh3OrfQyWZrjKS2En5hsxmBgAg43tXClc+P0SyxA pbUXdlqTSNExWIhsOp/cDe31tA/o0CmS9beP9+zrwBHL3mJmLZJ29AuC5utg+SGrb8sk9P/hxLJ iVxUc8P3+ehWO5B09123pr9spPKIPBMbLRAdf+Bam+hXdPTmRPEiG4w9qebNYtonC7PmC8+HAYO JJvHB5uTbb10d42J+K4krOwOm6Y34CgwreGsV6doTZmxyEr9Yypj710gTHR0xCo8GnRwmvI3vxM WhJxx+NhXYjeruiZg1oVXz9NjfjBMwyGAOsoD5dOwI2emyOu6w6s/6G+M+mYnkIVqrVzo6/0SWk 0Go5opNibktCKFm62v6as6Fi2r7xNxMWmtj0er8lSCVQynGiC9i6AwXyfT4Qanucpkv4rjm+R8c kwlcE5oxnQ X-Received: by 2002:a05:6000:471d:b0:474:57f0:49f8 with SMTP id ffacd0b85a97d-47f622fecf2mr14974421f8f.4.1784549803601; Mon, 20 Jul 2026 05:16:43 -0700 (PDT) Received: from zovi.suse.cz ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ed1911sm31424338f8f.22.2026.07.20.05.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 05:16:43 -0700 (PDT) From: Petr Pavlu To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen Cc: Aaron Tomlin , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] module/dups: Use strcmp() to compare module names Date: Mon, 20 Jul 2026 14:15:29 +0200 Message-ID: <20260720121621.750661-5-petr.pavlu@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260720121621.750661-1-petr.pavlu@suse.com> References: <20260720121621.750661-1-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use strcmp() instead of strlen()+memcmp() to compare module names in kmod_dup_request_lookup(), since all strings are NUL-terminated. Signed-off-by: Petr Pavlu --- kernel/module/dups.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module/dups.c b/kernel/module/dups.c index a62619ec057e..43cec4cec4fd 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -70,11 +70,9 @@ static struct kmod_dup_req *kmod_dup_request_lookup(char *module_name) lockdep_assert_held(&kmod_dup_mutex); list_for_each_entry(kmod_req, &dup_kmod_reqs, list) { - if (strlen(kmod_req->name) == strlen(module_name) && - !memcmp(kmod_req->name, module_name, strlen(module_name))) { + if (!strcmp(kmod_req->name, module_name)) return kmod_req; - } - } + } return NULL; } -- 2.54.0