From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E27446BF1 for ; Mon, 20 Jul 2026 17:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784569210; cv=none; b=hY1Ad+JfeB5KnSbQ3CUquqB19qlN9SdCObrxjpR+jR5gmUcAy7Uo7xagaFI14SHIxEIA3cy7JFYnpuJkL3/Uua91ynDk1hZRQbBc4yfDlb0lZ67pmsoNGdPSSBhgdFQz70kbxbFJT9xI0lixnOTi1MseQXN/QGnapbpDJtIEsbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784569210; c=relaxed/simple; bh=2kAYaaLwIlYcH2buJ96Y0ZdmhoMc4tJxYfECPM7dRIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=umwTRdik3RJUjvo1klZwsKhRWnCL0uZ/R/y4+NaVtV+7VbL+z05z/jlFj1XZcwJPLPOkSBwXwC8C65JwYN9gwsgEH0jGd+ppcE5hx9nVTRkjIbdLfNrCyXYzWXrbPO7YK+iGbtsCq97K1pb8OJ3fdq9vI+ZMoMi5COpv9usCVik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c1ucvpKj; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c1ucvpKj" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47f752b3423so1193534f8f.3 for ; Mon, 20 Jul 2026 10:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784569206; x=1785174006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2kAYaaLwIlYcH2buJ96Y0ZdmhoMc4tJxYfECPM7dRIc=; b=c1ucvpKj3y+PVBPyxovaW8gBX1nuO6G8lNjv7EROySilXb4ih3cIi6lwP5dqMnX8PK +dhWOmxmKKMeVcfwEdQy6aMnAv0MDCqAgp0enlsZe/dBxXV+SEuC8EeOG8qBedZURX19 l4Ns6GGLy3XU/vgWOabnqzRh1JT53ibQC/9M/BpTyjv5dU8xIzASQwV54oyIuIlZw0g/ N9A79L2T20ENlNHddj9aYad1LGrFY2aIt4+gbzXsIFti8eJd9cF957h9Gz7dk34kmoyM 8WBMlTLNgvNPX927gAzuEN8cXDpohlo8k48zG34SbY47rgeprUOrgEBgkXRDNs4+eUW8 /DxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784569206; x=1785174006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2kAYaaLwIlYcH2buJ96Y0ZdmhoMc4tJxYfECPM7dRIc=; b=nJeH0uEudQLzs8kg0xGd4VHa9d4BhVZ6KfhMRzPHiFdYeq4zuC0O6KxT4lUPS/i4LI iLtnDKS+4NWDtAgKvHYhyUDN7d4Xtw9Z1uQg1penr0+hDKQE4mFAqh2coBSqw71dnZkr 4uF9rkUcWFt3RniF4nfczgHpxefP14NJzMGcn/8Eoa4qqGi1g6Q5clP1hhYx+6RUngtN t/mX0jZJSGLp8TTEzRWLu2yu/T4QySXiN/EwZriJaNu2jhYn+QCRTAmDA59HHBjJz1r6 kyznNqjCwP5NfjvVZLuoMLcYfnzF0kgXMThu8yMTP60OPgBfSPmuP0kWwUfP7t8OqJyu xU4g== X-Forwarded-Encrypted: i=1; AHgh+RoHr4v4P85DjaOPOlX25Tk8IFVNv9PpBPREL4JEXARta7HChtIPk47jxM+Ba2rSp0YxSO18603pV+3OT98=@vger.kernel.org X-Gm-Message-State: AOJu0YyMoqJsCHZNsI9sH9Ah1YcQ7CO7+eIFqqGsaB5kJuPmCKjLJnhn hJHBvdNcrYGYFcOJo3TSbditEWLMkI0mLWLbQYaLRbfTY+pDkBEZKIVy3ywV4gUD X-Gm-Gg: AR+sD11Qjjs9FjAcWt/K9FloHVyifib382lMzwkGxBlE3PTcL6qDPKXxQGg3QI9KDjE oKhBhX/WIBUjWTpX1r3irW32zM53n6HeseFidpPti5s7XW/p8ruKS6W0HGfUSOcdFNIRhwvIbxZ TOGxCe+k+G9Ye/COcVurL7Jv+TJqnEO2mocHRAUfQUldMngDzA5CrPIum1wOlXgDxwjo/J8gTft 7EpzgevsrWKDUA9fbWSwi4f9sDc9nh74qIFXMULsK+MODBm3+CKocHZNeGnt25Y6f7zK7rUvo99 CUABdygEYLXOTo9A/PXwjwg+0Z2dhEORwswt3ky0M2C0YZsiqFpYwt/maIVle3bV+4xTlEf+ehm KrpJdu/dLD1rzoivsVRagfq1JxEtMKRl4lUZZV9HuT1Dx9fCVNoFiF35ucnGMqJD8BfxtZsDKFc bvZDNfKFtlp5zSLJ6mFuWTtAd/y+RVVHocKOEKIg== X-Received: by 2002:a05:6000:186d:b0:47f:7b88:1843 with SMTP id ffacd0b85a97d-47f7b8818b9mr3851758f8f.38.1784569206196; Mon, 20 Jul 2026 10:40:06 -0700 (PDT) Received: from localhost.localdomain ([2001:b07:5d3a:fe75:4352:bba7:6d7f:5f92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm33703136f8f.21.2026.07.20.10.40.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 10:40:05 -0700 (PDT) From: Fernando Rimoli To: Jakob Berg Jespersen Cc: Sakari Ailus , Mauro Carvalho Chehab , Daniel Scally , Hans de Goede , Tooraj Taraz , "Joseph V . Lavigne" , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Fernando Rimoli Subject: Re: [PATCH RFC 2/2] media: i2c: ov5693: fix horizontal flip polarity and Bayer phase Date: Mon, 20 Jul 2026 19:39:52 +0200 Message-ID: <20260720173953.126255-1-fernandorimoli11@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720-sp7plus-ov-flips-v1-2-5f345b0673de@berg.pm> References: <20260720-sp7plus-ov-flips-v1-2-5f345b0673de@berg.pm> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Tested this ov5693 patch on a Surface Pro 9 (Alder Lake IPU6, ov5693 front camera). I reproduced your 4-state flip/image matrix on the SP9 via raw V4L2 (capturing SBGGR10 straight from the ISYS node, so libcamera's rotation handling is out of the path and I could drive HFLIP/VFLIP directly). Unpatched, the matrix matched yours: the correct image is at HFLIP=0/VFLIP=1, and the state libcamera actually uses to undo the 180-degree mount (HFLIP=1+VFLIP=1) comes out horizontally mirrored. With this patch applied, the correct, un-mirrored image moves to HFLIP=1+VFLIP=1 (what libcamera requests now yields the right orientation). That confirms the inverted-HFLIP / correct-VFLIP conclusion on a second IPU6 platform. I did not separately validate the Bayer-phase column offset (my simple debayer couldn't isolate it), so this Tested-by is for the HFLIP polarity behaviour. Tested-by: Fernando Rimoli