From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0D244E053 for ; Mon, 20 Jul 2026 19:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576373; cv=none; b=LgU+dCsuOP2aZAeyadM6HuiwkKqF6uWIvdVGrlJ52V7E8ycDF6ONY9Uwya/Eui5onsu4CkaWQt9wgryVJvG/GpvkdPV+OlSvV8DFqC926wjNKFtzrMRMJ81HhkGAGIFLXBbbS3Ufo+H0GgbcNahENjh+wxndAiX9kutWv622DFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576373; c=relaxed/simple; bh=E8m3m8XTS5TIoPN9299SRPXn/mLhXEctm+wdxmEAGyA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=siTkCgwnnT+QeyrE4GfjcCuvoWuVfIhMJgqixqHXs8lHUe8LKG9rJ7PuXxfr4eBk727wT6bhEATLCN7DY5yFX5WBiW+KqkcZq5NPrr7q7BYHFbVPt9yFrOnLqyTAutIOdUuMrqh6IpPkyWK3rUqABLDNhxjPGxFMrQ9Jm+ekvik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i0Iswoh3; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i0Iswoh3" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca12086c06eso8757987a12.0 for ; Mon, 20 Jul 2026 12:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784576370; x=1785181170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JpGuakV6/SQbZZ9011+gRtKsdWAwPDNjjQWuQfdvvoI=; b=i0Iswoh3ci5nQV+u7TDyOKtHPb5fURk0kOLXDygVTDd3/ZmUAtcM0sxmn+T2rM4Ktb G4+oheM37lFeXPdDHR8lIp0IeMke6JLZve2g1T/z0J9SfTnibysH6SJYD8cUKSYI84k8 a6b/L0gboiFMJaj0Otfn1hEr6s3zgKGbWsT2ATEExdJ8v76j5XaQUeC1MRxnRwLX3BDa RUZaWZkNCvqbB7OKKVy6LEuze+iQkOfjd6bly6LaIt9oF3xbHYCNRTT/mP8hKjKaSGnp yF3x7DuQe4YCmcvpu5Mc61jGh1TjjoVCfwFCwYMMujit8eSItKASFEHXS/I5P5ZStb95 R8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576370; x=1785181170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JpGuakV6/SQbZZ9011+gRtKsdWAwPDNjjQWuQfdvvoI=; b=M8nES78ux25tecH42TLkiqpnymAIN0xYS2adQK29NPvsT714r0L38kreRmhtULvB4G 7Z1nWAmsFfF8iIQYbkaVnenzDl1gFFbITEpVlNHLO0I4WFiNI8/uSazOrLfkdi0utLpV 3TSRJ84rdhPWl3RgN9Hw3144PiNI3g/WQlL0M9yOdMCyQYbRnYgyf3erQQzv3Y8nAiLM FZhHaXf7yvMMtK/gw4OPFUZMc3zuLqcIR1juOMFzZa0g76piPAo2E+FfNwXbxEnH0xkK mZDo2Sxjg7LCI3q7t9HX456I7mEwSdf/3sUTVhg/4i+MD30kj6sEzGO89qcfHxZXYaFr Ef2g== X-Forwarded-Encrypted: i=1; AHgh+RpkMN3UktGQJD4xMlEN/FSohnJyKgF7fbR9WPm5k+ilvmLF3fw3/uc7IcypErtnT7RTnQCmgEGs5RWK4aE=@vger.kernel.org X-Gm-Message-State: AOJu0YweZsdX+iiC/0KCN+CzSacOqueVo9//5P4CF4E/JaxmtqDIceWn CdqjC8GBrSgB5Z8P738TPNIWXGEGntPOx4fJgiz+JL6/rODy2GxN12LziIRbY5rklg== X-Gm-Gg: AfdE7cm/4FbYjiXKaYNb8FrQc2uiUXSHcb1Ju5fOE7rKQTrkJJH9FV06rikeIsh8vDj CGRnL8iLO4XKmZKQLCzz1zsqSxES0Hob9U3Z9Gj5bf9kKvWv6ECx5GH0lRAvSL3z1XUCWGGsr83 1xBHbUYJEXvKT9xgAWHqG3cjzvg9sDiEj5Q5xAkPqiBf6wdeGBh6POLnPuhAKtCP2lp0KP1hFCr y8kp/TbFaekwE3mwE8Kb6nw5U6gc5tTq17pB4jimVM179UoRIWeJheHSo106EwyNsOvwkTFqnSV 8xTxsA6Q/JpDqOU1jiqryo6BulWpu4cpJjd/DJbG3Pd9051bjQJJOygSSY26JZ8AaUX1NYAPWPD +R3pXRbfcaTLx8C8amlsFgh1mQCtduhhTD3toh4yyezhPOijpsjqENLBwMr25B5KhB0RaatuIW7 E9k4KBF4cgE7ITrnvqhthLKys60E2vmJJCnKRKpv9f X-Received: by 2002:a05:6a20:9397:b0:3bf:6c08:fb94 with SMTP id adf61e73a8af0-3c3ada37416mr16404386637.54.1784576370328; Mon, 20 Jul 2026 12:39:30 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.64]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29ffb13sm33935340c88.6.2026.07.20.12.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:39:29 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 3/3] iio: light: gp2ap002: Fix regulator leaks in runtime resume error path Date: Tue, 21 Jul 2026 01:09:11 +0530 Message-Id: <20260720193911.74919-4-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720193911.74919-1-nikhilgtr@gmail.com> References: <20260720193911.74919-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If enabling vio fails, vdd is left enabled; if re-initializing the sensor fails, both regulators are left enabled. unwind previously enabled regulators on failure, mirroring the error handling already used in probe. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam --- drivers/iio/light/gp2ap002.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index 96dab4d1d8ac..b6dde3dce39a 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -678,7 +678,7 @@ static int gp2ap002_runtime_resume(struct device *dev) ret = regulator_enable(gp2ap002->vio); if (ret) { dev_err(dev, "failed to enable VIO regulator in resume path\n"); - return ret; + goto out_disable_vdd; } msleep(20); @@ -686,13 +686,19 @@ static int gp2ap002_runtime_resume(struct device *dev) ret = gp2ap002_init(gp2ap002); if (ret) { dev_err(dev, "re-initialization failed\n"); - return ret; + goto out_disable_vio; } /* Re-activate the IRQ */ enable_irq(gp2ap002->irq); return 0; + +out_disable_vio: + regulator_disable(gp2ap002->vio); +out_disable_vdd: + regulator_disable(gp2ap002->vdd); + return ret; } static DEFINE_RUNTIME_DEV_PM_OPS(gp2ap002_dev_pm_ops, gp2ap002_runtime_suspend, -- 2.39.5