From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f228.google.com (mail-pg1-f228.google.com [209.85.215.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3DAD2FFFB5 for ; Mon, 20 Jul 2026 19:49:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576949; cv=none; b=RWkPs3h9B1YMjHdBSysCMaztokqcLqJhKkJ8YdDKTq1f/Wm1gdhS3BJD9i/RL/Zs2yKZrtql7klTIUMOZUXW4J1q1aDM5/olrAcS6fwG4LtjeV9Ago17lsNoQfBiyc4te75xUIsuK6XhFmK6ysmt7NfaZD3xZJUueEht/nlLfM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576949; c=relaxed/simple; bh=ILZ1OXSqpg0YJAMnH1L7KR62EaBTj6ncEaDP3DDL3YQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hOE5oe3vfG0lvLB2tr666aLFBGnYRiHmZ/wbj1cUrEQncxAx5JYuTIAxQFySpMuQIPzbMNU5NzTVUndsa1Ykw2ctatlOMrGpgxzvMbfukKI3Gv740yxDmulMR4H4OTgLCVzkk3/NlFTw9nlW0Dw6H2YiHh2I/mm590Jmd4mOOws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=cARFAA1W; arc=none smtp.client-ip=209.85.215.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cARFAA1W" Received: by mail-pg1-f228.google.com with SMTP id 41be03b00d2f7-c999f162c9aso6563882a12.3 for ; Mon, 20 Jul 2026 12:49:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576947; x=1785181747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tRt6BPmnSIJVDlX+Tp6C58k9HWDHbAncJG4jnoURZe8=; b=FaouaFcSVsYlEt3YTdHqLSJdya5ldRN17qsD9gUTYI2kq3tfSuta2nDn7FEXCjGlqG 3wceMLuDbPPdtAtFjBvDaaJKa0mzeqNG6P1illeSGzR0pnY5EhhA2x1WqAC1cDcCHfUT 0f4OneUnrKOe3G0ZuB2JWPKk6x+/du3qLmyLNoHQdDQsN2rVbfL9cIrIdJn3AYC2LPkw xvYZWdZ/fND7ijs92tnjsl33NeSsxu/lTMjOP0dJdmKjrSYb13BVodYnB0qasazcYDTx Gxj6RyOhNKb/ryZlGM2CsWvwU12KtZsKdHgl71YnMMJxjK+vKhslt9e5bXoLfhv+3Pye BUyQ== X-Forwarded-Encrypted: i=1; AHgh+RqYlfmJ5oJDCNackQSuyYNAWkj7qEryOSQngEP2DnriTUa1iM8opjFqu6FWbCKgY74plImNNXFfJMqnnkg=@vger.kernel.org X-Gm-Message-State: AOJu0YwNVFAoQYwp0VeaO/PlwIZxZ5sXGsGX3WPkzsuqAvw/Nhwg+z/x jarRfdcSlsvfc+/wSU63y3SFmg6ivXygYGVY9i1brlpGVQDLyYd7hpJ3CgXM/1K+5nIPZ0qcfa/ Ptlf3iopZ+lOQCgJk02Uqtx5+98Po75OdZBmQWoeLLopm5+jDq0ZZyjfwM1+1mD/xEhH9NqmAPO sEqePapgUiiOGQFani1n4IL0gJ1OgVtiwjyUbPCjU1p1uMZvvwbG3u+1CPeYYi2VHO2yNr5yL9I /I21IfiIx+QD/LCVuIQ6kvnDg== X-Gm-Gg: AfdE7cn778bGrLMoMKy3wUDqJCpRNcWHYkxrcw/Id5qlamhbLzJa5Jl+NPDqFmjU0RE 04sqs9CAA/cAIyOLlMhicQowSeK9AjXEfxEEbmZD8AO+qe8B2T8lB5hLi7ra6B/wnnuk5SWC9jP XeCNSK1ao9YjUZmi0ktJkUCUDhFGrTJPVtj84XumfdzFSoNhw5Gxsj8oANKeDgOzsRYzvVt+3DQ j6uydx110Izcjf9gHSm+LEzGieDsYbG6iQwAUXiQ5RC1r5nCs1taxS0RnyiJLpK3fAcZhIEZJFV t4wU5Zcf49JJgFD9+muZNtsffIN525aaPQ/IXcUdP/bj8gSLIGExO4WZvcmxTCzSlpLLPen54Ub ntl6eGGkIw9PsrYP4POBkZtEYEPfygrOJwFKlPhuxcrqBACis7o5/n1YxpAEznhxtnSrtSii9d+ kSVGcuTX3Xpy3/n7YLEgJnXIARukt0O8e89I9Exig= X-Received: by 2002:a05:6a21:60c4:b0:3c0:9c1a:8936 with SMTP id adf61e73a8af0-3c3ad9ec55fmr16845980637.62.1784576947142; Mon, 20 Jul 2026 12:49:07 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 41be03b00d2f7-cb517f8f217sm559549a12.4.2026.07.20.12.49.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jul 2026 12:49:07 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c158b6e31aaso448817266b.0 for ; Mon, 20 Jul 2026 12:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784576943; x=1785181743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tRt6BPmnSIJVDlX+Tp6C58k9HWDHbAncJG4jnoURZe8=; b=cARFAA1WyyW/L+HMoKQcCEDUN8lrDoldF4n4CQ514Dmmg5M5fhe50t9m8JPKY/uKya PfVjTc+yl/PaisioXJCFp36+XG4Hci6mj8mozeAWmKcujb4A4a0plN5VZszXv7PRT9lL crYmjek3Dr06l+cIl+aZc34y7O3w9Q+Z5gXjs= X-Forwarded-Encrypted: i=1; AHgh+RqQMWmZWWwmSjTbbcdOo22EAviyvBJJq8ZDKyFD+rQI2kaMxdteEjCcEwPpFdYckLLzXR+fDVC0ldTCg+k=@vger.kernel.org X-Received: by 2002:a17:907:9816:b0:c12:58c0:db2 with SMTP id a640c23a62f3a-c16922d74c7mr845558966b.18.1784576943712; Mon, 20 Jul 2026 12:49:03 -0700 (PDT) X-Received: by 2002:a17:907:9816:b0:c12:58c0:db2 with SMTP id a640c23a62f3a-c16922d74c7mr845558666b.18.1784576943308; Mon, 20 Jul 2026 12:49:03 -0700 (PDT) Received: from bld-bun-02.bun.broadcom.net ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1705912972sm506543066b.14.2026.07.20.12.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:49:02 -0700 (PDT) From: Arend van Spriel To: bogdan.nicolae@gmail.com Cc: Arend van Spriel , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Bogdan Nicolae Subject: Re: [PATCH] wifi: brcmfmac: cyw: clean up PMKID and cookie code Date: Mon, 20 Jul 2026 21:48:57 +0200 Message-ID: <20260720194900.2356442-2-arend.vanspriel@broadcom.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260714150423.53960-1-bogdan.nicolae@gmail.com> References: <20260714150423.53960-1-bogdan.nicolae@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On Tue, 14 Jul 2026, bogdan.nicolae@gmail.com wrote: > [PATCH] wifi: brcmfmac: cyw: clean up PMKID and cookie code The code itself is correct, but there are process issues that need to be fixed before I can accept this: 1. This is a resubmission of the patch sent on 2026-07-09 [1]. A resubmission must carry a version tag: the subject line should read "[PATCH v2] wifi: brcmfmac: ..." not "[PATCH] wifi: brcmfmac: ...". 2. A v2 submission must include a "Changes in v2:" section below the --- line documenting what changed from v1. 3. The From: address (bogdan.nicolae@gmail.com) does not match the Signed-off-by address (bogdan.nicolae@acm.org). Please use a consistent address or add a second Signed-off-by for the sending address. 4. The patch addresses two independent issues: fixing the packet_id in brcmf_cyw_mgmt_tx() (SAE auth frame TX) and fixing the zero-init and PMKID copy in brcmf_cyw_external_auth() (auth completion). Please split these into two separate patches. Please send a v2 addressing these points. [1] https://lore.kernel.org/linux-wireless/20260709122315.11400-1-bogdan.nicolae@gmail.com/ Regards, Arend