From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910C432470E for ; Mon, 20 Jul 2026 21:51:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784584316; cv=none; b=AuhErIEjTVrhCgKoyuqW0HhLh7Uq3YNSDqWIhOd1AL1mRqbHVYLK2YYZZGEG8WjL5Fq6XDywLcl6D2i4syAYecTUojVvuqrIMZXSfS6Nq0MGDjPEOtbQ5dNRJ5pOyBPv8isTj3mexlifvrWwFQ/ERHwm70Typjmr/S812Z3yYNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784584316; c=relaxed/simple; bh=LCoMmseJW73FYUbNbON3s4KciuV0rvGX1oNTSLPhE3Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DyjJBCEwQZ1NgGWylEu7EWPE2+AJNtUtgtbBpfdcSpvISYWnKQYMLGySEgHu7aGjfN4224WvLIMT+wOs2XC8ZaGXU7+h3UXoaQvvMcoAKSsfxrkIqDMFUOjdyV+f/rl2CwF7hmMfITDlpK0xwKO5QxTusekqN2WaMu2clJh6gPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PPbtBSxg; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PPbtBSxg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784584313; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YSp2bjmUTFzp0IbxCyAWq1OLo28SH+leDwAT8SY17rQ=; b=PPbtBSxgu5BJw5LbWyDE4e5/GPGi9heVxm+zN8Jyo1E9M47k6ppbmsRIaWqCtgTot8nFXV JW6uIpQqWje7sccG6Q9o1y9c4T7YWcFglXGEF5Tpg+o1lWrGOTZC2RDoEPXkAeaPhm8oqN Zt8YcqUawHNbYYvWnkjb5bUY1ydaIIM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-ovSgWrIrMkaUmMkekNLOwA-1; Mon, 20 Jul 2026 17:51:49 -0400 X-MC-Unique: ovSgWrIrMkaUmMkekNLOwA-1 X-Mimecast-MFC-AGG-ID: ovSgWrIrMkaUmMkekNLOwA_1784584307 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 75A2D1944D42; Mon, 20 Jul 2026 21:51:47 +0000 (UTC) Received: from GoldenWind.redhat.com (unknown [10.22.88.114]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CAFBD1800765; Mon, 20 Jul 2026 21:51:44 +0000 (UTC) From: Lyude Paul To: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Faith Ekstrand" , "Dave Airlie" , "Leandro Ribeiro" , "Maarten Lankhorst" , "Luca Ceresoli" , "Kees Cook" , "Marco Crivellari" , "Simona Vetter" , "Pekka Paalanen" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Danilo Krummrich" , "Daniel Stone" , "James Jones" , "Lyude Paul" Subject: [PATCH v3 0/3] drm/nouveau: Fix WARN_ON() from missing blend modes Date: Mon, 20 Jul 2026 17:36:15 -0400 Message-ID: <20260720215058.398210-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Recently a change went into the kernel to ensure that drivers which expose color formats which have alpha channels. This would cause nouveau to hit a WARN_ON when setting up cursors, since they do support blending - but we never bothered trying to hook up the controls for it to nouveau. This fixes the issue by ensuring that nouveau always exposes a blend mode for any planes with alpha channels, regardless of whether or not we have control of the blend mode hooked up. If someone wants to add control for this in the future as well, it should be fairly easy to hook up with this. Previous version: https://patchwork.freedesktop.org/api/1.0/series/170773/revisions/1/mbox/ Lyude Paul (3): drm/nouveau/kms/nv50-: Add .blend_modes to nv50_wndw_func drm/nouveau/kms/nv50-: Introduce nv50_wndw_default_state() drm/nouveau/kms/nv50-: Unconditionally create blend_mode prop for wndws drivers/gpu/drm/nouveau/dispnv50/base.h | 6 ++++ drivers/gpu/drm/nouveau/dispnv50/base507c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/base827c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/base907c.c | 1 + drivers/gpu/drm/nouveau/dispnv50/curs507a.c | 3 ++ drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +++ drivers/gpu/drm/nouveau/dispnv50/wndw.c | 40 +++++++++++++++++---- drivers/gpu/drm/nouveau/dispnv50/wndw.h | 11 ++++++ drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwc57e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwc67e.c | 1 + drivers/gpu/drm/nouveau/dispnv50/wndwca7e.c | 1 + 12 files changed, 64 insertions(+), 7 deletions(-) base-commit: b0a652436b892eb9a036a031b33099dca036faaa -- 2.55.0