From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D76E36895D for ; Tue, 21 Jul 2026 02:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600454; cv=none; b=a/QSrtRUt9UshgBzjgf2d3fvuy/PlmuQSJz2fCMX4n8VjzK2gPkj6O+/YHx8vLOB3Fz/q+Cnpv+kQzzVUMOSF0Yi/vOj0bWHyC6ORBRfJRGidYmM1F6egqnwYhP4ZzwQgYt6Un4Y1P9P8BK7X9or2ooibSt6qgaJeRB+ayQbSTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600454; c=relaxed/simple; bh=bVPxoi85jbZFO9af2Hg2HjePj0L5XNSg5j6catQYaJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tGqFW9RPYykxaDAHajA4kxKa0P9CH1IzDglz2Me8NBPOk0Qy7sDcJ+PB6K4WbHFtuiZ4mBqW9gEk0UQ2pvePyUbGyWSjLk3jPUJEWrFKdnq5eMG+FL70rUacoKu7ms/tx8eOE+F0KYgNenOFDwIUkPkoKKz8COdqfsPlA2UIFCg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UVYP/Soi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JVR/r5Q5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UVYP/Soi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JVR/r5Q5" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCS5F4107054 for ; Tue, 21 Jul 2026 02:20:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=UVYP/Soi5A18CJYF y0YOOIM5zVWptpkmiEtjoeiT8rWrqEfAXaP71wFjAU+mJfK3K58nV4jUpxTQMqsh YwmDC5PlodIvdYrg+FW8YHiq7y3VDxPziXotDmRDsBUZhaOIKYnIPufkF7WWqxsg tZCkTh+9ojPvH7xOeHyt53CyKCMW3QbUbNEnekooqSOMS3hUzLssWYpMqIrR7FpW YDsLD7emYg1EvNLLG9ehCNrGAlZF2CzHGuz6/6ZCyTooFmhShvsYhpp+kXqPR15/ uDWcj5PhE5GSW+1nli9YJsOf+xIMDr0HyHNFNeUPu/rMAHEH9Ux0Kzja/l8RthHN fDR9Xw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhvqn8kg3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:20:52 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb711c88f2eso1203430a12.2 for ; Mon, 20 Jul 2026 19:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600452; x=1785205252; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=JVR/r5Q5RQUqY5kyqS1phcx/5Ls75Y8duF93i/6sjYT1DXHEa+pPmHPWiRaZhyWMHm uJO2eFKW8/SZsWz7/EyDGPusqrCGlHeD0lTwlA3y9PVMBcPJ5BITZUTeD7DpoJ/ciI9L vLaM5vnAEdOwihZZ2SuoeWHW3OCCCbpQmmu3Zgy4AXQOQ/qLifeN+dixrpOWQ8/76GAc OAq2+edgLCrYertkJQQE5CVBpaMHH26WRxLwF8QZXie+qYXYZNgu3z+xR3Fu2GlY523p hD54zdaax7pVf2yXFmB3BPOZyJ/YaIvO3/pH8Xi9wNfM/hne+6Tza9741GHQHyX28ca3 8JTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600452; x=1785205252; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=R4w71PDJUefUAWB5mwBO3ki8tx0w6CREfdqyJsQOO1dEvEiqho+f+LBphm7iGWn02e /o4lB29pzZ1/S5LuJT86zi0ePFfC+jHv0GBx0TdiR1fqemzZfZEtOi9c48fj0XaCKs21 zOCDpSDO89zIPIQkVnGSHXGxUdFzzjeuDg2I5W+kldU3ngUbOncwx+dohUFkRlX6pU8o samNXY6SR+hcLffNPVKj8kO/EhCMjhwMx6+gWqQRGUf1NqWXr4lRetiK62rr90G6bwFO ZEQEVbrSL3y3/w50GYeIdmvkZ+V/bXeeqV78CyTpxkdRgnw0SfmfG2JwzuufWhtPa6+i ynlA== X-Forwarded-Encrypted: i=1; AHgh+RqG7WXvM3EL0s1XQHbNt/MsRNu4GJDux1ZB/EO+VcVb902IJqONRZIDODcmZqn9u5mP337EhltiQStgRKw=@vger.kernel.org X-Gm-Message-State: AOJu0YyY4BIjV6RTAq0j2EPM3xux/uy4CQiz/8A+xR0jDs1EqrPp3GyL rnixRObhbUKWsuLCX6ezIDVpSpS/EUt99eLThaa/2L9Ik9a+Pac3uww0Fh0/Ksr+MOR9fb6XwSq il+YVkIb5imZmcSSkiGgO6iF1j6S9Dw19rSKSlEozL6V93mRbkPHXI1VBPl2GIojsx1U= X-Gm-Gg: AfdE7cm2HVGnoSguk0lNQmCBuoV4d67h4GK8RDwXrskfg0GV5BVFaz+zMg5D1kFTEab m3jq0FoAodBgJFplAmC2gDMMJBO7jCvgC9Quh8vgBTM3kOfd+JeLMEiQLZR3O5IJf8kNzE30KBH MkSrVZEMi9mwhY5uO00W0jkwkKsFSR2EjOBmQH45reGg8aOwP8WOYGF50pCBuY1aBGpbHAeyPMl ahHpCtKrUlsrM3B/NF0M4BosUC2CfswUa2+zS2HlVOBGygnXYmRHWYtbJlEjiO/MSir01z9WdrD mjDl8IYpNkCf4Z2/lJpTyyNuVPo4Se3iqVo80VNxbwJuJmh4zvMIPosl3VfXcwJ09gvj75cNiNS 0hOpR5qMqTjv8ml4LUbVAHbtRZaO3+P/cPg== X-Received: by 2002:a05:6a20:da14:b0:3bb:2883:a723 with SMTP id adf61e73a8af0-3c3ad973dc7mr18538268637.35.1784600451665; Mon, 20 Jul 2026 19:20:51 -0700 (PDT) X-Received: by 2002:a05:6a20:da14:b0:3bb:2883:a723 with SMTP id adf61e73a8af0-3c3ad973dc7mr18538236637.35.1784600451208; Mon, 20 Jul 2026 19:20:51 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:20:50 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:35 +0530 Subject: [PATCH v4 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260721-iris-code-improvement-v4-2-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1345; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=Uq29RriGWpbhBmOAxORGoqBD0WkHutgpBJXYyBKyE+o=; b=XTLDYCz/Ni0F951fPaZ23QYLoqV1QXGrdTx7wwBwLGxBNSb2Y+LYzJlzVrKFarQ0ylG0gxr6T SPUSSWFZLPQCrlT6KOxd8n9SSrfKriYnUkvpQdv9RhL0rKN1CJ7YOrO X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX6sXxd0PJAtg5 L8v6CHiY6kLeItNm8+8bvzPhdfnK3wp2O5W5EyNy5Fptli6cUwkfiVdt9kpZgxUvTxPNEiSbnAD VsfeWY4wCfsm7WZCfAXpufCXD19dtz6Vd/g6IXt9k7xw31hgarRcfygS6IPFW2UXiokVm31I/Re ceOH5y4Cr0aT3PvEoRq+TqWU/NRpzE+U1C/UKAAujlYjCfzBd8xfMuWqgbuW0J5tLTRURgHpMc3 wxAv9J4IO+1KnRnRR9kfGkOwjgifuSUXENirzACnrYVMB8SZEyWyIA089PhcMT4TmMiJNxV59v4 l/6dsGsMRM1tWjos2SZU7jUR8VPtfy+voBu/ko1fexVNbuDmmAUwnDr+adonB3JXXgKEy1ulnK5 pJQrAse6NRaFkGvX6nIRFQ7g4J5BqNDFuVHOW9gKBY7Hn3hWpC/0gTmvQStWm44JxayQgv0nOoQ g0JobcJ1aNB1SJ6D1hw== X-Proofpoint-ORIG-GUID: N3m-O3fO3ocSpAEGL0N79KW_gu0TeCOR X-Proofpoint-GUID: N3m-O3fO3ocSpAEGL0N79KW_gu0TeCOR X-Authority-Analysis: v=2.4 cv=M5F97Sws c=1 sm=1 tr=0 ts=6a5ed784 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=iF4bBz5rOIv4ZkufqEYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX0oPQqRCycN+9 dpZ7/Jk38IFqOl9WVXTOcrMarVrkVdJEED54z1VY8v37a+O6Xl0AF/FCQy531yZ7qpgnG91FDf2 38wrkXj+8WdlQkWf9YzknCAy1wwpNdo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal The state‑change debug log in iris_inst_change_state() always prints the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub‑state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index d14472414750..e991f34916ec 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; change_state: - inst->state = request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state = request_state; return 0; } -- 2.34.1