From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389DD36895D for ; Tue, 21 Jul 2026 02:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600459; cv=none; b=qAMp7lLjl4Mvg3YrGNkzS+sWpw5kPOiV4LiAoMa8l2KKlntKEkewU2Glk65/uL9LT0DauX7X+Gb8BfsVvXsf315xteHIPtfvmdWsBGHXxwhqjbI0Y6GnJBr0xs/C/VrZjcXjX54qyqE9fXJ2bJRkvMZ+WPR2gxIu55o0mOYlmFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600459; c=relaxed/simple; bh=XrExrogGyNY8zefzhUS+pWbzmqCVYgThgf2zASOamL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QgPgOGFosI0qphht62JIHQHlJ84xUdFiS0hOq+unky6/hXMscYcck7pHQx2rMyNSo/hVVrTUAr8IMLI2jcx3XtKQ9FxWQxvXSSkdRqdxBoZHEne5QBwMA30ib3ebbgh9HRJef3WSZyZ9A5r9LXp6sc3zTL0irpzXojhpMbwgdrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iyVCAaFW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UiygL9kz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iyVCAaFW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UiygL9kz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCZsi3588316 for ; Tue, 21 Jul 2026 02:20:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=iyVCAaFWYdZ7TVPm HVk1jhPHRX4qIaysp57+ZPjKVBTt86SgHWrC/tr5knUQa3C0IFvuvQUmA72fphi+ Uri9/cdGzel1p8C5Po+qUkHva+WS7TNtkhjmvthdmPeknZIr3MenjXHQ2wJntolu Pexwr4lUipnIQyBJUMdgpmD8pXkCsujVY2n3/LyCxOAQLK3OJEc4TnY3OVA3C7L+ Yb71MvLRltbZSIGEuGc5wz6DOR0ACbCd+Itfjsmn30eCHdPFTGE9XE2fUT95KiNW kw7/s/70RRGqLPJoZTgzX7U0K20VwoS4W95BhI+9voalAOCjHPcbEXhBX8B4Q+6K aqnf6Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs53ykq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:20:57 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c892143db7fso6438644a12.1 for ; Mon, 20 Jul 2026 19:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600457; x=1785205257; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=UiygL9kzgXHExAjIY2fEOOwZ7dPGKPjVc7+r/GECEZpPq11bgOQ7RkyZa5Czrmy5Fi 4Z/4OS5U7QEj/ZcNgpLHi7hqkLSVwODx+2OR/lNbgxU32pGlgHMLU7cumj4aVWy2OqqM zQYPG+wZbiU+w/JUV2acoEX4SxAQvzqsUfheLkbazFl1fn01XrD6ZOe/Rqj10B1/WaN9 1FjumCJSiQ9O76r5huLSChey4mSvPRR2u1zA14PENMYAsFItn4VPtydQwkCeuHhC6Xlq MrSZvX7oRVCkNRQ6E2aRHbrRM5bg/8nXmFO3MCwgjUNaCF89Vb2uTse4kF+qsYDxTxTz Io8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600457; x=1785205257; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=ZcDjsjrcvgsQJ9vMsgmMKx0ZKAiiAs9Ivr95fUrEsxwb5fp7OsSSXrWazDOT3vH78D /6J0LYmPiw+L2JUkJnQhYu16TYC+c/vy8E6TfVT7QR15hjMk5SqGiOSOg/dJOpE2cxK8 Wv8zyIJ5NF4ofmsGiJj4rcyL0O34TPkNgD+1sm+ZSQANyVkqsKy3AxCE1yGjeDz5vTwK tD8YbRrgaxdEntaLUodZhr6DrvR5nc0+krUpRl7XL6e99t+sAKSvyLw+y/lmoRBwyL52 knLFHAHu98F3JNmpio+2h+NlmLnslW8bFAiORMkXlHKWyCi7Tg9tKQ12MMUVTWoBJK/t PN9w== X-Forwarded-Encrypted: i=1; AHgh+RoDBVSYkMsZreTJ+JTshezSKxNGZhPLptPwVmdqeBuNIfZXV5LK56PQCMgbIG3tY7hVv+A1xdUCg2c9ZZg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5eOqty2TS+aDIMIJO5uYI4laYHm8OvSCDJJ6vmPCObZV/ovZ9 Z1ttv+6DyYXtt+IlRU4vIjAe7iHSFybsNcfTrK0rSMkbEbizz61zqHcAauQxYorRsstwVd2KudU j1UsM9fkwyWpzWa/GjlAQHz7rQKaUi9LkkERUXJgOEx+lz3givqJQNqnK8pluYAvVRcwrWVqvRl 0= X-Gm-Gg: AfdE7ck5M3k6e/xT+X2JQnSdjygKiQt7OJyxaT7/JmdIGRMbW8Fgv+y4GMrnucl0fX8 KnpFKDAY9JNpSRmXObmDYivuCcUestPky117k7PGYvnyTThOusHLy79g8kchrF6bZd5VEWMSyST Xdrp5+k/Mos7QwEYVMywZN1QcSrPXOK8cdPvlUgUuqSUNjHB+8Lx5JoNv8+/qEog1g/b1hk9SYw Le28BTmDgrBKAnJ1oqj0KIuVqfRYNWoBd4hbNtc6ds7MWv6DGGLRf45ANSfINSrZSLLsHRcEuQj p07F90qubE8c1ekFjfXaqc8+dlv9BtZau4zsZXR0w1z9OD7m5V645pc/HVObxGuQ59OhEWck4zw Px3JIa5lpNGyTfTPoSVa+VgpG0hwBw44KIQ== X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18354269637.53.1784600456836; Mon, 20 Jul 2026 19:20:56 -0700 (PDT) X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18354222637.53.1784600456428; Mon, 20 Jul 2026 19:20:56 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:20:55 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:36 +0530 Subject: [PATCH v4 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260721-iris-code-improvement-v4-3-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1251; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iUPNcmr9LcDxjiMweUrnUvGUJcwSJce63MellJNuucw=; b=TRScXKpClXiG8jp38leP5YesLIDnBJ2yezJTPZCidndYva2SQvbwWcaFo/W9j9ejxhCybxjYq D/SXwxbbsHdCrbrvl88VnUTMHQVqMA9hUIPth3+E589wDPG4Ef1uBLB X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX7pt2Suwy9syt Aw/11UR0bwp5zmca2ZGGrz6UuZWzioH//2DI65FE1OUlFPqfmI5WJzW+RI1KVaA5JLZLQcvau1u m40dkaYLjq7nqXV+anCNzMG8CSFSCJE= X-Proofpoint-GUID: AIU1WEJCRGosyWwLJE8vmje1vLFZnvvv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX0+18WrLFKmwl +PQJipTUyA7t+hGtHjSZ2NtWqwBO8aL9zbab/aT3z96RxyGmA1MlTDfng+VO/rT2pEQh+IbQPnI /jgc+slGR+0XOh5MF94q531ShZjIOPBayS0k7Hwm0QE3vWCRt8/MBHunK7duuKqbp+1f/g8e8Yz rm/LfiQI2LyNdlD7l2deaFNumK8RUG61B8+Yk/ErIeu5sQ05DfDK5fXBBRaVYph0fHbITg7a780 qb7jHmRCfAUj0jjApoQ5ofH/FgnNB2LN6un8yCkVA7j6MFM0hZO6w1aEG5mQIlYZ4UN2vG/HQaw 6fN0YqXufLAN7mUR5m0lwYcCwrSPX2DB/KREqKsvY9ql05K62Hio7Zsfeuftx3NMY2ocji3y7YY XbWQE0p4kFhzOo+DHh8z2jTzA7cqVqzLh8Vbekaven6g9KXanrgPJr62aVJSabrIYnJzuj32iGn cjpFfN60BykBMO5NOdQ== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5ed789 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=qiYeaxkneK40FgSAABkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: AIU1WEJCRGosyWwLJE8vmje1vLFZnvvv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal iris_allow_cmd() incorrectly checks a sub‑state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/platform/qcom/iris/iris_state.c index e991f34916ec..5552725c614e 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd == V4L2_DEC_CMD_STOP || cmd == V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state != IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } -- 2.34.1