From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1294534AE for ; Tue, 21 Jul 2026 09:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627640; cv=none; b=HTky/4CNO+anlYHhEbqlRLnFJ500kP4NshVUEpM1WP7iIeyV5T43qRdQmV/TVzETSHbkErPPicJW4ugu0CrFV69lIF1jZDrvnir0ORDDaXP/c6g+0ysiYgE0LdTl+hCTuNVCZ1krMuRTONeDGB99dC/veOv72wEaw1G+wf7A3dE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627640; c=relaxed/simple; bh=h/I5qtQCyzhc0DcHlJvNKASagwuTPEwMjUgB/gz6q4Y=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=nbj5emXs6MuISMYzM8B6c5H+pHwsvk+E0RmLvhj6GvGQffonxR6r9dfiv7mh2qySuwKNevhaRJnw+nlWOoO+ovQJZ++tH3LdgtLwTOr3zU45ASg4RCYpV/YY5NbXDvf85LFuxsoFDlIJLvdpM0OKdbFY6AS/uubVqyXwNXPMnlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bxjqEHp/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Aisp2oeH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bxjqEHp/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Aisp2oeH" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L8q58f526992 for ; Tue, 21 Jul 2026 09:53:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=s0Ad/kTqFIEVVHlyxWbVsM ZZs2OLjnk7ipym+9asjYY=; b=bxjqEHp/JB3PChbSsUhCCjsZVSN3i9MN+EwqhO b8zqhIMFsrN8iB54J/1Bvh9F5afhslJkpWLJSwatPS9LGMJGm5nu8c/2iPsnOaPP ex6OlJBkcEgy6MDvKECWACjh3Y6+ZSMrGmQ/+lrXgLP0qx56Z2Jlk1O+jlLXQq0s 0jbsoue9jia7XxylrGw2cApsGMt8yEjFLg6sDURWZjEFejFi1Iu/5uargKSeBd7e ucLPkZh42A7i4kM0lcvBcwoJXehRVTv97PCulRj5rxWfMRcBuDbbyWTvdk9oIs7H q5wDyaZz8nx1ZKOc6g8bgo2aGQ5gjJI9zoo9O29ycJXqRQdQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1se1f2j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 09:53:58 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38e8e864ef0so1764809a91.0 for ; Tue, 21 Jul 2026 02:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784627637; x=1785232437; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=s0Ad/kTqFIEVVHlyxWbVsMZZs2OLjnk7ipym+9asjYY=; b=Aisp2oeH5vlx10bnD9ajf92dkssWeDTD/uUQ+g6613P2GUDDBFBL44YvLmBQ8bu2LD PQqwgzkpdrGTEcxLvEXKdQ50ONIFfHkCLa/uslCL+MAhqh5Z4mRrRqrkrH3HbrawQTE0 yZI+Q0HSQWnZ/UA8JGi3jKufxuuGJ3YFIOfVMZhyW0GUvsLhMR6OyqkCFmNCWaQV1XT7 BfW5vp0o0EvwHsx34ycHqJTTedSXzQJaUC02yiN7J2D33diQv0iTN+yTZuFxj3dozLtB XSr/GmvdRiWt/oSipcUbqr6WQvdfsQ2fpIk2HXF5K+dZrGFbgJo+W7A0uAiNkrcE0anE OBOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784627637; x=1785232437; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=s0Ad/kTqFIEVVHlyxWbVsMZZs2OLjnk7ipym+9asjYY=; b=dtW2eq1YPl0XQCqyh1P/zOzGXbfX4XTuxllkV9DPhHcTYSR6X9RAwzKmTHkQvnv6FU jmgzmxCD4YoID119nZThpj7EXrdjrMepPkE8lxmzNSKhifwUzP8+6NqvrP7aTxjzorPY x740cDCIyOQfVzcPK4zaMi6F75kXff9djG9hkCc9ZVzRwQ53YA/LR68s2JaKLYSk6LBK u5+P+ATxcn6JBz+NAjm0yjAEIHERN7oHyayCpLPIrfcVvbvklD0V6T7Zc2Yh4Nu5h/O/ G57C83EhpGkk4YLT6TH4aFv103fAl+ldP3THwZCrybf6AtgGachRpRY4pmdRL3OCAhO5 aHhQ== X-Forwarded-Encrypted: i=1; AHgh+RrMnRuCIJ3nbyFIlHSKI5nYbmun9E7l4CdBdedIGMj0IinAwWscCc7W68FP2tpzBn1uq3jyzsttKyf59RU=@vger.kernel.org X-Gm-Message-State: AOJu0YygXD+MPjPGWwdF9cnC+cWqhGuo0ChCWCQXfwA6/GcJZeQZO7ZJ 8ocH0GbY1Yv/sqVLhfyEgN53HS5Vluf+1HaJ8FsLCUus63dxGpT42Z36NkKkebSRfq7EFBx5BJJ KpgCDFG9aOvvvIoScRlJfRX7rXizsIhZBcF3ETC1frPrauT/ujPkAQvAADFHISghrYEQ= X-Gm-Gg: AR+sD114ljkVfAVtjlh+XVVo4Gr/oUUpjhBd9mpIUZJuAGBvvLfX3McLKMYIOU/kksv DypDmHKGXcb7oozE0IxKRO97/M6Vkq7s41VAX1KCjL+7aeOfj9NQWMxdV69ju/ixXhPuGHELsE3 HR8+YQmM8kVs7nYTCEcIh+egDKusIIz74ERUatDDLOAUM1W1lNG6XbqyQ5KOcpopS4rlrWxYYD6 UiMBZ34zQHIKGEX1iUDKgzBTlUu+vc1Ut7v7QA8lZF2VXaBze6u23H+U4xGLHPGhMtDY2MhVbuc gOlmzyWzxz5GIfDYj59r7bf6JjKJuQm+q90lJbSVyYQ4stgamc6hqiKZ0T5gGG2WnP/1lMYk929 euM5KMnm77XJ04sSE6N9IssM3AnKbDx8= X-Received: by 2002:a17:90b:5251:b0:38e:76f8:fcc6 with SMTP id 98e67ed59e1d1-38e76f91cacmr8851081a91.32.1784627637198; Tue, 21 Jul 2026 02:53:57 -0700 (PDT) X-Received: by 2002:a17:90b:5251:b0:38e:76f8:fcc6 with SMTP id 98e67ed59e1d1-38e76f91cacmr8850991a91.32.1784627635789; Tue, 21 Jul 2026 02:53:55 -0700 (PDT) Received: from hu-sachinku-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e92064c77sm1285462a91.1.2026.07.21.02.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 02:53:55 -0700 (PDT) From: Sachin Kumar Garg Subject: [PATCH v3 0/2] media: qcom: iris: add multi slice support Date: Tue, 21 Jul 2026 15:23:31 +0530 Message-Id: <20260721-iris_multi_slice-v3-0-adc61a687e7e@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAJtBX2oC/23OQQqDMBAF0KtI1o2YRBPTVe9RRDQd64CaNlFpE e/eKJQu7GbgL+b9vxAPDsGTc7QQBzN6tEMI4hQR01bDHSjeQiY84TJRTFJ06Mt+6kYsfYcGaCZ TxXNV6UwKEt4eDhp87eS1CLlxtqdj66D6QSnPj9DMKKOaG8GVZBrq5mK9j59T1Rnb93E4G9+iH 61774NnvpV8t6k/JKcJ1VmW1KyBWuj6SBbrun4AjTLhgQYBAAA= X-Change-ID: 20260716-iris_multi_slice-5647287a9563 To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Kumar Garg , Vishnu Reddy X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784627632; l=3281; i=sachin.garg@oss.qualcomm.com; s=20260211; h=from:subject:message-id; bh=h/I5qtQCyzhc0DcHlJvNKASagwuTPEwMjUgB/gz6q4Y=; b=OIHB7iJJH/bsljDJ31qY0FyhTE4wdmTMhwPPlBzDfsxFUf1wlPmdbAmTh0s06wJQEF9X+4hLp RfhJsRzSt37AIOLyNreinrweTbtZK0OHlU1r5pmJzvbcpAq1oQ3rQOH X-Developer-Key: i=sachin.garg@oss.qualcomm.com; a=ed25519; pk=KcRhp4CP9cR1V2tg6xSNRnB2STYaU0vVigdUF4Actu0= X-Proofpoint-ORIG-GUID: barPzn_yQRqx1ygf7iloTm9CVGSxtr1K X-Authority-Analysis: v=2.4 cv=TIZ1jVla c=1 sm=1 tr=0 ts=6a5f41b6 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=AsnL8gqb6cm0EwA9_ewA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEwNCBTYWx0ZWRfX1Lp1J3xhewSa 4ygnC9OWgYjkgf/OmCp2to4doGj/MU+gMwxTrzlaMDsbqc/lMfioS7kLQrq65iWKvMQ0e1G42h2 fz6wZvUWzDNBhuON24YEWHbAmsE6lGc= X-Proofpoint-GUID: barPzn_yQRqx1ygf7iloTm9CVGSxtr1K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEwNCBTYWx0ZWRfX9P2FtSnxgSLp z5ZsyuJW3pDwC91baqTC5V2bXxor4P2FiAOsi0DLAYC1Sswmd7692l2I5HNEh0nSPcXYjPFjxSd guEizAA4Pugv2CGov1rTsB4wyBMkbrxIUEsC8iq576CtYE/6w06adSNdE3rTYUtZyTXrFbW93UE znUJEdq/Dc79eMK0JoEB9DLbVL7Fmr+G1kSQbdtW8x4b84j0JTcJ0wiS0tN0kMSv2us06QuutCB OTgASW/SCD1PRqXeUOsLzEtIWx8mtZyS47GjRmXd+nfPIdAyIpr7SLDCB/AOAoVZ2VzWZJR04vr iuj4OiGFmWdJq5r0X3+Unn8BwEfNzRlbrw/nPQwv+5X8aKoFMUgfJwG9uDHV3uMOLrmR0S2XDsG iz7Y2fUyAzAMoJ9E7TPGNA/K4c49LkQq5ZXi4kFsbkjEBpc74iOclP++u7jkOygRqtJXz3rX5Q+ i+qiewNA081QeSzl07Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210104 This series adds support for multi-slice encoding in the Qualcomm Iris driver. Multi-slice mode allows encoding a single frame into multiple slices, which can improve error resilience and enable parallel processing. The feature supports two slice modes: - MAX_MB mode: slices are created based on macroblock count, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_MB - MAX_BYTES mode: slices are created based on byte size, controlled via V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MAX_BYTES Clients can enable slice mode using the V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE control. Patch 1 is a prerequisite fix: iris_set_stage() currently always selects STAGE_2 work mode for encoder sessions, but CBR rate control requires STAGE_1. This is fixed by forcing STAGE_1 when BITRATE_MODE is set to CBR. Patch 2 adds the multi-slice support itself for Iris HFI Gen2 based targets (qcs8300, sm8550 and other SM8550-derived targets). Support for HFI Gen1 targets will be added in a follow-up series. This series has been verified with GST level testing. Command used: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12, \ width=1280,height=720,framerate=30/1 ! v4l2h264enc output-io-mode=4 | capture-io-mode=4 extra-controls="controls,video_bitrate_mode=1, \ slice_partitioning_method=1,number_of_mbs_in_a_slice=460;" \ ! filesink location=/opt/test_enc.h264 Changes in v3: - Patch 1 (force stage 1 work mode for CBR RC): cache the computed work_mode into inst->fw_caps[STAGE].value so buffer-size and clock-frequency calculations stay consistent with what is actually configured on firmware. - Patch 2 (multi-slice support): - Use inst->hfi_rc_type instead of the raw V4L2 BITRATE_MODE value when validating/deriving slice parameters, avoiding a mismatch between V4L2 and firmware rate-control enums. - Round up (instead of truncate) when computing the minimum MAX_MB and MAX_BYTES slice size floors, so the hardware's max-slices-per-frame limit is never exceeded. Changes in v2: - Added a prerequisite patch to force STAGE_1 work mode for CBR rate control on the encoder, required for multi-slice encoding to work correctly. - Addressed review comments on the multi-slice patch (updated commit subject and description). Signed-off-by: Sachin Kumar Garg --- Sachin Kumar Garg (2): media: iris: force stage 1 work mode for CBR RC on encoder media: iris: add support for multi_slice in iris encoder drivers/media/platform/qcom/iris/iris_ctrls.c | 87 ++++++++++++++++++++++ drivers/media/platform/qcom/iris/iris_ctrls.h | 1 + drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 33 +++++++- .../platform/qcom/iris/iris_hfi_gen2_defines.h | 2 + .../platform/qcom/iris/iris_platform_common.h | 12 +++ .../platform/qcom/iris/iris_platform_qcs8300.h | 9 +++ .../platform/qcom/iris/iris_platform_sm8550.h | 9 +++ .../media/platform/qcom/iris/iris_platform_vpu2.c | 9 +++ 8 files changed, 161 insertions(+), 1 deletion(-) --- base-commit: 42f83a32259a82c4481d3cccf560c3bfeb32c892 change-id: 20260716-iris_multi_slice-5647287a9563 Best regards, -- Sachin Kumar Garg