From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A351746A5FD for ; Tue, 21 Jul 2026 18:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658288; cv=none; b=Xi14yky3TDHgd7WFrNyAZUad/tUO8qbOiBiFR4/mR4BkPNETs2GbMfkp5Lfv0d9kMhsw/HejX92sRgFlI1usbrQ423BuSGFJvK+fmrt10NFs3iGzOeO4vmQC57c2IJfaEvkOk/2tb01fLQrTuU+hfva6f+oQG+qOisk+QXPwBmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784658288; c=relaxed/simple; bh=DAsAkRrlrjB+LjOM1hc9zi+WIM7VFhwalTrcnp+qYgQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hch3z6/s4JC/rBx014BaWXcMedNp+FDn0c1auvGZAt455EV5bUvNZtn++CyKl56J0VasuwwTp15XcPeszSt9UR/f+j9FZx1HOxb77XzNMH7B1XCcCdTKOCzr0dIHltazRqG+98ipf6KN/I13HrIHYu2Tn1RHpCUzKo0fO2Xg7mo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WHWxDExS; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WHWxDExS" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4954c0833b4so28779225e9.1 for ; Tue, 21 Jul 2026 11:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784658283; x=1785263083; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6h1vgoNij8ASaqzGn9OonNwFVqwllRJ2VF0KwZtNt30=; b=WHWxDExSzm73kAY5nc8HSrCMVg8ZOab8YdgnlfASl4yYX6NDo97qFyrWyfFAemJGTr smddeM+tBspYHYaJI6gmjG1qxDqJH5SQgMIaIylT11573Oi7Cz+QDX1hmmiMj0aKadCA rF7jWI4BG7YJFsrZcst6bA4b/BWEQ/kk7FOzEsKvXSzH/5AsRCvwmSL8AEJ9YXzItjvp s9nU357KeR1UVqJ4cMBT4610ISQ7a6dnmnnOycx6k/IzogxNNZMYYk9oECNdixSVNhgm SczcfuOTlQ/OUUiNkQ1dBNIGhiW4VTjgV5UxIpJMtJTs6iNkMSxQCba44DrPQ3WUYsLX rz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784658283; x=1785263083; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6h1vgoNij8ASaqzGn9OonNwFVqwllRJ2VF0KwZtNt30=; b=eENLtmbd/tL3DLIxCu4Mb9Q/sqo4SKiwWzUVvzRJheHNRDq6QlVbZKgvIUoPoj3tbU +fFRmIS+zPm+R9rVzZrHpExOdhFnREdYc/7QmVNd3JcHHW2U+s7iLypE4YgOqgNzs7I2 yXjsznTffiUSk+Yh7Hq+vAKPMKyKiCxUzxvAMT1zDvuU42a6Ef4dCs0LzXsFWswaeLl7 RJxS3MHfbJE9lk6DfIiL5QvE9/SicOt6YWWwEJ40yA23yomUL6YbfQ5+b1N+Nrqf81+K t4Dwok25nBdSlUy+3vhFSq9zLzbv7agYCJzs1YLbN0Q2hzexpNwdgWdturSnnHxve9LJ xEHA== X-Forwarded-Encrypted: i=1; AHgh+RpD8Fa/zXLi9if5mIfPEhgT7/IKmhXVpgkIhgriOHzVkD78zofLON8YQX9K3SdN96ed2un1iBx+8VJcteY=@vger.kernel.org X-Gm-Message-State: AOJu0YxKVJyVk2lwK2vcEuLv0WM4GkLVlBWBafFHXVgD9gsSMAKSSI+F H0ZF9pZnGsSI75TKEwz2N8WUJNEYahbxPzPFLtp/Xysfmwvz03GnZ91p X-Gm-Gg: AfdE7cnY1DqW5xLYwRBELlfkb8Mzhkzs5OCCdco0hRlN+BpZfHAz32LJNPe7DycqxHt OG9n624BkKfcS6re3a8nW9mKSunlF9/YqQ7BeFs+qcdc1NT1puQuU/aKwBGVNDouQNqFPI8nlem BE4dQpdLTgrlNuxvFR4zepWq8kLv9VybElKM9I5LVtRakLNnLNS5hPrbu70q1c9K/lwGILwxHML XILfI1LR5SbU0JI7kIulaIJ5X32ch7/xCdIXZVeUssVIHK8xoKC0JGg7KajlPOIRum64CCUbvBa B0t2o5mPsGQ04bEYisinD4jzEwm+/dmlnjn+/Rsk5uFjlDkUcao33Ab8qBTiofniiAyGM2RHxk+ 9fVthYT7e6zUV6CzG+cOAS6UuGxgCLuwX9/eWa05sdQ4X61JPx+02hPf0xKjCn71ZJtL9DUOsTr 0gbqU90KI4jKJJoIZIDTWWDuwB/eyhExh4GTBGWtS58OZdZ2NyUbZ+4n4BhZgdjKT+1okKiyp60 p5NUe0+8brlKUb6PWthutGOXjFS3EpE/cty4DsTSKOsQ7CBjGempEk03iwmIHpohWq4XtogxWBD kQxGWy/KtBqU1vVDcqgIhAOwIvSGC9PF7DcNt//V7x/kiZkUuzw1ch3L782EFcXShp3OEzrY72y 45IXI9upJs/CnzAM= X-Received: by 2002:a05:600c:1d1e:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-4954a3f39ffmr209579125e9.14.1784658282775; Tue, 21 Jul 2026 11:24:42 -0700 (PDT) Received: from [192.168.1.187] (ip-86-49-244-181.bb.vodafone.cz. [86.49.244.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63eddd1csm40835081f8f.29.2026.07.21.11.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 11:24:42 -0700 (PDT) From: Joshua Crofts Date: Tue, 21 Jul 2026 20:24:39 +0200 Subject: [PATCH 2/2] iio: dac: mcp47a1: add support for new device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260721-mcp47a1-add-support-v1-2-da045a2567e3@gmail.com> References: <20260721-mcp47a1-add-support-v1-0-da045a2567e3@gmail.com> In-Reply-To: <20260721-mcp47a1-add-support-v1-0-da045a2567e3@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784658280; l=7331; i=joshua.crofts1@gmail.com; s=20260530; h=from:subject:message-id; bh=DAsAkRrlrjB+LjOM1hc9zi+WIM7VFhwalTrcnp+qYgQ=; b=rg7LCJjs3WYqnvTRZbGWbpuzWuXCuFPMBOxlvzHl70WuOt/TBUviI8b29HN6djik++z2nz7uI RdhAYvFRiK+AJG9gzJsxEGgK3JvrikUPoluKsnTDMr3+0vSSsKPuHWY X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=RTDOoVwgeL4oFdASj9U+cxJuIjXuXk73zkjnGOJKbEo= The Microchip MCP47A1 is a 6-bit volatile Digital-to-Analog converted which communicates via I2C. Signed-off-by: Joshua Crofts --- MAINTAINERS | 1 + drivers/iio/dac/Kconfig | 11 +++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/mcp47a1.c | 193 ++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 206 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b44693593b94..9b124bbdd6ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17704,6 +17704,7 @@ M: Joshua Crofts L: linux-iio@vger.kernel.org S: Maintained F: Documentation/devicetree/bindings/iio/dac/microchip,mcp47a1.yaml +F: drivers/iio/dac/mcp47a1.c MICROCHIP MCP9982 TEMPERATURE DRIVER M: Victor Duicu diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 17529509da9d..a7f5711e9c3b 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -563,6 +563,17 @@ config MCP4728 To compile this driver as a module, choose M here: the module will be called mcp4728. +config MCP47A1 + tristate "MCP47A1 DAC driver" + depends on I2C + select REGMAP_I2C + help + Say Y here if you want to build a driver for the Microchip + MCP47A1 digital-to-analog converter with an I2C interface. + + To compile this driver as a module, choose M here: the module + will be called mcp47a1. + config MCP47FEB02 tristate "MCP47F(E/V)B01/02/04/08/11/12/14/18/21/22/24/28 DAC driver" depends on I2C diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index 5d20d37e44ce..992f8930f95c 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -55,6 +55,7 @@ obj-$(CONFIG_MAX5821) += max5821.o obj-$(CONFIG_MCF54415_DAC) += mcf54415_dac.o obj-$(CONFIG_MCP4725) += mcp4725.o obj-$(CONFIG_MCP4728) += mcp4728.o +obj-$(CONFIG_MCP47A1) += mcp47a1.o obj-$(CONFIG_MCP47FEB02) += mcp47feb02.o obj-$(CONFIG_MCP4821) += mcp4821.o obj-$(CONFIG_MCP4922) += mcp4922.o diff --git a/drivers/iio/dac/mcp47a1.c b/drivers/iio/dac/mcp47a1.c new file mode 100644 index 000000000000..251c2281634f --- /dev/null +++ b/drivers/iio/dac/mcp47a1.c @@ -0,0 +1,193 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Microchip MCP47A1 DAC driver + * + * Copyright (c) 2026 Joshua Crofts + * + * Datasheet: https://ww1.microchip.com/downloads/aemDocuments/documents/OTH/ProductDocuments/DataSheets/25154A.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include + +#define MCP47A1_REG_MAX 0x40 +#define MCP47A1_CMD_CODE 0x00 +#define MCP47A1_MAX_STEPS 64 + +struct mcp47a1_data { + struct regmap *regmap; + int vref_mv; +}; + +static const int mcp47a1_raw_avail[] = { 0, 1, MCP47A1_MAX_STEPS }; + +static const struct regmap_config mcp47a1_regmap_config = { + .name = "mcp47a1", + .reg_bits = 8, + .val_bits = 8, + .max_register = MCP47A1_CMD_CODE, +}; + +static const struct iio_chan_spec mcp47a1_channels[] = { + { + .type = IIO_VOLTAGE, + .indexed = 1, + .output = 1, + .channel = 0, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_separate_available = BIT(IIO_CHAN_INFO_RAW), + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), + }, +}; + +static int mcp47a1_write(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct mcp47a1_data *data = iio_priv(indio_dev); + + switch (mask) { + case IIO_CHAN_INFO_RAW: + if (val < 0 || val > MCP47A1_REG_MAX) + return -EINVAL; + + return regmap_write(data->regmap, MCP47A1_CMD_CODE, val); + default: + return -EINVAL; + } +} + +static int mcp47a1_read(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct mcp47a1_data *data = iio_priv(indio_dev); + int reg_val; + int ret; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + ret = regmap_read(data->regmap, MCP47A1_CMD_CODE, ®_val); + if (ret) + return ret; + + *val = reg_val; + + return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + *val = data->vref_mv; + *val2 = MCP47A1_MAX_STEPS; + + return IIO_VAL_FRACTIONAL; + default: + return -EINVAL; + } +} + +static int mcp47a1_read_avail(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_RAW: + *vals = mcp47a1_raw_avail; + *type = IIO_VAL_INT; + return IIO_AVAIL_RANGE; + default: + return -EINVAL; + } +} + +static const struct iio_info mcp47a1_info = { + .write_raw = mcp47a1_write, + .read_raw = mcp47a1_read, + .read_avail = mcp47a1_read_avail, +}; + +static int mcp47a1_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + struct mcp47a1_data *data; + struct iio_dev *indio_dev; + int reg_val; + int ret; + + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); + if (!indio_dev) + return -ENOMEM; + + data = iio_priv(indio_dev); + i2c_set_clientdata(client, indio_dev); + + data->regmap = devm_regmap_init_i2c(client, &mcp47a1_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "Failed to initialize regmap\n"); + + ret = devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulator\n"); + + ret = devm_regulator_get_enable_read_voltage(dev, "vref"); + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to read vref\n"); + + data->vref_mv = ret / MILLI; + + /* + * This is a volatile DAC which doesn't have an ID register, instead + * the value register is set to 0x20 every Power-on-Reset (table 4-1). + * Any other read value at startup could indicate that the device is + * damaged etc. + */ + ret = regmap_read(data->regmap, MCP47A1_CMD_CODE, ®_val); + if (ret) + return dev_err_probe(dev, ret, + "Failed to read register on startup\n"); + + if (reg_val != 0x20) + dev_info(dev, "Read value 0x%02x at startup\n", reg_val); + + indio_dev->name = "mcp47a1"; + indio_dev->modes = INDIO_DIRECT_MODE; + indio_dev->info = &mcp47a1_info; + indio_dev->channels = mcp47a1_channels; + indio_dev->num_channels = ARRAY_SIZE(mcp47a1_channels); + + return devm_iio_device_register(dev, indio_dev); +} + +static const struct of_device_id mcp47a1_of_match[] = { + { .compatible = "microchip,mcp47a1" }, + { } +}; +MODULE_DEVICE_TABLE(of, mcp47a1_of_match); + +static const struct i2c_device_id mcp47a1_id[] = { + { .name = "mcp47a1" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, mcp47a1_id); + +static struct i2c_driver mcp47a1_driver = { + .driver = { + .name = "mcp47a1", + .of_match_table = mcp47a1_of_match, + }, + .probe = mcp47a1_probe, + .id_table = mcp47a1_id, +}; +module_i2c_driver(mcp47a1_driver); + +MODULE_AUTHOR("Joshua Crofts "); +MODULE_DESCRIPTION("MCP47A1 DAC"); +MODULE_LICENSE("GPL"); -- 2.55.0