From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274BF3FFFA8 for ; Tue, 21 Jul 2026 02:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600095; cv=none; b=q/ACVSBG8io2m/6SbSJSP+Y0mtsbr0aOYcEViXB4iWDB1MChw9g5F7ZyvagSL4QihM7r74EmT5p6hfzecITEmkuAIgGe41Funk9nZWR8ddVNv4GjSaVz8zbp937QwGFoZndcLQs2EzbiQRCuBoMni0TZ9vhXuVGyRr7rOQqoNpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600095; c=relaxed/simple; bh=tTM7ZUO5l79xlSlAd6AQmfbSdjjCjN8UgweVaG8QZng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rXwPEF+rXY1T6jUQtLHxuObvORTrCxQr7C0qG7vVI+8ykw9TpsJHOT0pgcZPny2DoE8Eg45csvPExygR88OueMRGLBo3mi37A/8IXTnSSKPg0TRyzNmQL02xyJwIEgpk6n17EHXvBA+BziicIyzwQXPaOMYRLnwI8nbbmmUYdw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8iPzetL; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8iPzetL" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so4736059a91.1 for ; Mon, 20 Jul 2026 19:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784600093; x=1785204893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z6qD1eCX8UZOQGibHra7bJn3ga0Dq+Abt2SRuAhtEeA=; b=m8iPzetLHIZHb3hYWgzVGq5Ilpn0rizK11Y1TlMJy35+vSkmiDMAsDLsMCqEJFGZsH VfggjzBz1caC67KNOaBT2ZdkdVKk9yPrh/SiNbB9jsbIwtdZoSbumJIkhs0RKOK3pZ4h DjiYMUhfPwKJ46wAcP8G4Z9xbIRIMa3/I3z3mGwgP4xibCZowPJxPZ0Dyv/c0MdGG+we EXn8Omv7wn/m3TtmK2INeL0mZNlJCCEEjh8JQom++/TJXqSz0aKkYfGi11koAah6NyzR tVndwledBRj590bbv+ir+BK/cnjb45jSyis2XtnjAfHyRuyy46hpQnIy7vxuu6CxbCjl 2eBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600093; x=1785204893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=z6qD1eCX8UZOQGibHra7bJn3ga0Dq+Abt2SRuAhtEeA=; b=VZFFOnT8m9TOfTcWaq3nzLjapmUOd+BkY0ehEUE7ZKe0FL0zFFgONBq2Ud6RL5FDEb QEVUx7tlXAG5bdKIgi2Ywy5XfKIyp7M71ZDN4YVRmMzqVqYBVwswAvuJN3R6xIOVZ1WL 50mVcAkfCCQqX8AgrbCik/h6uLgpPYpbAGR0HoRcxxwzt5/zzEtzoZhNGfta0vCwmTuK E/epppHIKI1lc79NivTu2ZD3jrG2yUrm0RddR+bTpoRJZLIB0mtjVqzJtVIuMivqxobN T0ykvkQF6PkQCWzicF7GJIfyy3CJNeTTxRj/qM/QoL9v36vo4HG3M9A5A2+VDPGiWXB8 cZNQ== X-Forwarded-Encrypted: i=1; AHgh+RqE5HpoDAVwfFLAtrN3FwWSdx+MpyBbegHwqde16chDHFd57HqhfHyk0U88p5OT9FFGWF417ZPXUiCwGLI=@vger.kernel.org X-Gm-Message-State: AOJu0YwE25yOA/ICbjwXQkYowz9Hrgvm1iDw6TTZXbhnKiCLn4w1Zu09 n35lvP4vR5WXS0dfnCsK5YAyGJ/bWepSGtdqxfeIZaHIan25Gq2vIh8w X-Gm-Gg: AR+sD12iq4/pYdRyHxUJCZ/xuYTDL/bXmKUNn7kLbxXevNdAuShSTBo7zS1EkgJRy8I lFNi+bBvo7KZyni8seA6fz2elyF40spLPJNs6603tLDHhaUIRRgEqRAUKeiYo0wrkcx24pbMDX0 rH2bmcydt4swKlZ2fDzET36RYIasAW2eqqAJg9JDz5MQid6jBnqD5OaXyJC6Zus5QBEshnJt2ph lGBrS6q+osA24niQOSIH3qNRKPokivK2mKpe3+xWfUwO5rTfh8LCxc8D/TsajKAU6tTharIpAjA +wO+5PAsESEEowLWMXTKssRTdhRtDTwqb4lvfclCQADs/l3UfZ/qTHuH6woH5PtlRLgiVZL1yDf 4y6nTwdWa08SxFjK3r9hYD6Pju6ez1dasm3YKavwasVaLvRtIID6ZG6ntPsQvdj2SWDg7biLUo+ y7H0f8fEzVGw8TFt08EfbZM/iBsnRde4AALfuAHsOoVNERlcy9FmJw78kBykHxwmI= X-Received: by 2002:a17:90b:3ec7:b0:38e:cb1:8ec9 with SMTP id 98e67ed59e1d1-38e4b585bfcmr17200761a91.42.1784600093473; Mon, 20 Jul 2026 19:14:53 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e9235a4dcsm586241a91.12.2026.07.20.19.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:14:53 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu , Brian Masney Subject: [PATCH v4 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Date: Tue, 21 Jul 2026 10:13:54 +0800 Message-ID: <20260721021356.288506-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721021356.288506-1-a0987203069@gmail.com> References: <20260721021356.288506-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit div_u64() does not modify its argument in place; the return value must be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() called div_u64() and discarded the result, leaving pll_freq holding the undivided product and thus returning a frequency orders of magnitude too high. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller") Signed-off-by: Joey Lu Reviewed-by: Brian Masney --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk-ma35d1-pll.c index 4620acfe47e8..bfedd45bd04b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -92,7 +92,7 @@ static unsigned long ma35d1_calc_smic_pll_freq(u32 pll0_ctl0, p = FIELD_GET(SPLL0_CTL0_OUTDIV, pll0_ctl0); outdiv = 1 << p; pll_freq = (u64)parent_rate * n; - div_u64(pll_freq, m * outdiv); + pll_freq = div_u64(pll_freq, m * outdiv); return pll_freq; } @@ -110,7 +110,7 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 *reg_ctl, unsigned long p if (mode == PLL_MODE_INT) { pll_freq = (u64)parent_rate * n; - div_u64(pll_freq, m * p); + pll_freq = div_u64(pll_freq, m * p); } else { x = FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); /* 2 decimal places floating to integer (ex. 1.23 to 123) */ -- 2.43.0