From: kr494167@gmail.com
To: lee@kernel.org, pavel@kernel.org
Cc: kauschluss@disroot.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, surendra <kr494167@gmail.com>
Subject: [PATCH 0/2] leds: s2m: wire up missing of_match_table in platform drivers
Date: Tue, 21 Jul 2026 11:18:44 +0530 [thread overview]
Message-ID: <20260721054846.34318-1-kr494167@gmail.com> (raw)
From: surendra <kr494167@gmail.com>
Both the S2M RGB and flash LED platform drivers define an OF match table
and register it with MODULE_DEVICE_TABLE(of, ...) to generate modalias
entries for DT-based module auto-loading, but forget to assign the table
to the platform_driver's .driver.of_match_table field.
The consequence is two-fold:
- The kernel will never match and probe the driver when a DT node with
the corresponding compatible string is present.
- The MODULE_DEVICE_TABLE(of, ...) entries become dead code - uevent
modalias strings are generated but the driver can never be loaded by
them.
Both patches wire the existing tables up into the platform_driver struct,
fixing DT-based probing and module auto-loading without any functional
change to the non-DT (platform ID) probing path.
surendra (2):
leds: rgb: s2m: wire up of_match_table in platform driver
leds: flash: s2m: wire up of_match_table in platform driver
drivers/leds/flash/leds-s2m-flash.c | 1 +
drivers/leds/rgb/leds-s2m-rgb.c | 1 +
2 files changed, 2 insertions(+)
--
2.55.0
next reply other threads:[~2026-07-21 5:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 5:48 kr494167 [this message]
2026-07-21 5:48 ` [PATCH 1/2] leds: rgb: s2m: wire up of_match_table in platform driver kr494167
2026-07-21 5:48 ` [PATCH 2/2] leds: flash: " kr494167
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721054846.34318-1-kr494167@gmail.com \
--to=kr494167@gmail.com \
--cc=kauschluss@disroot.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®