From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E78642FCDA for ; Tue, 21 Jul 2026 06:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616907; cv=none; b=G68Qi4yYIJWfOYExP0/V7FDRiWF6j1qIhtiEJNRhwxIJcxIDm3PWF47YBdYAj1LE6teQ+UpFKSCzUh/Em8u8IYxJfsvv4paVnwKCFLi4Zso8eY/pC9fw7rvFumFDzlN5ILogl9ZJqcCdlZ9iKwvFvukcmo9rmuOd/IhOdFKUCiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784616907; c=relaxed/simple; bh=rDxhkqymr7zNZNO5s5LLG26mVpihgtL4jhXYrXXJ+wY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D8Oqqly4+Aaq/LOd4ExMBsGplnqnNRwofwDkH8biAEU2IuzjLi5dvDWAVR4XIzkP0C72LaUMMyeuPWLVCUF4i/8pD5Q1CBmWGRFJQEfCJlRniQac//J20PKN0Hl+jxliK5VNfJQleYO0GgyJaX8Hki6ZpoLDVg7VlRkzNhg91qM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=NSKN9p6/; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NSKN9p6/" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ca64c3ce5fso125894845ad.3 for ; Mon, 20 Jul 2026 23:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784616904; x=1785221704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fHUpdIaIyIIyz0xHiffTwBnjBb2ySQuUos1Tr0diNj4=; b=NSKN9p6/4OKlOUKnluEU5E+bpYA5Gx4ApsZ3d9ivBRylHjrig4TIeZvawbqO/C7H/5 kR2u4wm1id9hinJq3AxDqU3LDrPqIelLk0Ld9Zqp8LGydswuzyuqk3+4JS3v1CpsnCJL QOytZ0ebbuXG4ycgOmMUu/IfMcaQZ3EHCtxAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784616904; x=1785221704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fHUpdIaIyIIyz0xHiffTwBnjBb2ySQuUos1Tr0diNj4=; b=dlESKL4wPqQJL/0Z71uCb3hxuEm2WMNtmjn3v/9T+kgDo32eMh3m2VGap155ZAIs8q DevvYwSYbw69ih/mKGB+3QoLGlTKObg9pRIdsKHKMuePLKg6V2C2gjxTf/8XzL8ksQFo 7twrdj6tZlBt6vckKoVeAhQsZVKaWViRoh8SJ57jbwO4v5R+UhZdcU+ihrX9v97yOOXe b5abyvp/zrmO/TI7+YW8VRfJrvO8+5JKmccK1FFTsxnNpI10jE6eGMRgiGPkYOIxbU8C cSfpRAaF02GCPclGHX25xmBp1hmXCLI7xR9tn5+3TNx9gP6i1uD+RROPj0+p34D+CU4B YtHw== X-Forwarded-Encrypted: i=1; AHgh+RoNGKnOd6H+r+Fc1a4IVV3BDSgSfH0Px6Ogb1AQeJWQN50q/dQqxhIi4ivcvRSt3AmQEKI7HxhfNOLZV8A=@vger.kernel.org X-Gm-Message-State: AOJu0YzG0JAdcJW5cfBNKMjEtD+ycdTQl2YWvvw3D7AvYeSMlX4AO1of opOGX/wmlGgBpSnQQYlo91qks6wu9BdReN5JhjDYxvnDF/Hghm0R9OtPoBaNS8q4vw== X-Gm-Gg: AR+sD12Dxe+SDXaZJdkoADgQtbkPevJJEi3bWKzCP1dH/D8MvBXliLb/BBvhIEOzHaR Mnl5Tmdhm/KNpmUr9NtdqfRj3a4YbeCxwWhqVrTOIxN0/xHSMEZtwO+IoFWkkq1C3EshwkGqBND 8AJ7ufgHBERJ+jcCF0zoPAYCKKSScbAEy1LdNnt/TBXeqv59xPylNYDcZg5N8FGci46wwIAe/Vz c9bei9F16YYLyq4iwHq9tu02JqkRxYLKA9tpG1O7290AUKJX50RLJbEwh6ykFp1b06kr0b2UhOg +G6s6h+hOivkXkFdJTLdCvO4BJQ3j89qIztMrXMxPxXDPvK5DGMRyMC5RBSqmK1wu5fW/AEc75y xQpi3t1+8ti5dQ9zF29fCytrsOiscrsPvbV+dqgN7vkAsFwhAXztX9Fhnrw5PJvibWuMD6uzXOw xwFKbqBxXps+sg0FqyRTo4/uWfYMRwiymFqSvgPJhtZERVGCb28n9WleCK9Skz2gkDGrMoWw== X-Received: by 2002:a17:902:f78c:b0:2cb:3f5b:6663 with SMTP id d9443c01a7336-2cf348bee75mr185892145ad.11.1784616904541; Mon, 20 Jul 2026 23:55:04 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:3916:f048:32c3:931f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf3448ee77sm69716005ad.4.2026.07.20.23.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 23:55:04 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v6 06/16] usb: hub: Associate port@ fwnode with USB port device Date: Tue, 21 Jul 2026 14:54:01 +0800 Message-ID: <20260721065413.2306137-7-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260721065413.2306137-1-wenst@chromium.org> References: <20260721065413.2306137-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a USB hub port is connected to a connector in a firmware node graph, the port itself has a node in the graph. Associate the port's firmware node with the USB port's device, usb_port::dev. This is used in later changes for the M.2 slot power sequencing provider to match against the requesting port. To avoid potential conflicts with ACPI firmware nodes and then causing power management issues, only assign the firmware node if the hub's firmware node is not an ACPI firmware node. Reviewed-by: Andy Shevchenko Reviewed-by: Bartosz Golaszewski Signed-off-by: Chen-Yu Tsai --- Changes since v5: - Added extra |struct fwnode_handle *| local variables to shorten lines (Andy) - Added comment about passing fwnode_graph_get_port_by_id() return value directly to device_set_node() (Andy) Changes since v4: - Dropped unused |hdev| variable - Added flags for fwnode_graph_get_port_by_id() with FWNODE_GRAPH_DEVICE_DISABLED so that even incomplete ports can be connected Changes since v3: - Added missing fwnode_handle_put() Changes since v2: - Skip assignment if hub firmware node is ACPI node --- drivers/usb/core/port.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index b4452b665f59..c0a51d9b06a6 100644 --- a/drivers/usb/core/port.c +++ b/drivers/usb/core/port.c @@ -7,6 +7,7 @@ * Author: Lan Tianyu */ +#include #include #include #include @@ -358,6 +359,11 @@ static void usb_port_device_release(struct device *dev) { struct usb_port *port_dev = to_usb_port(dev); + /* + * At this point ACPI nodes and swnodes have been removed by + * device_platform_notify_remove() in device_del(). + */ + fwnode_handle_put(dev_fwnode(dev)); kfree(port_dev->req); kfree(port_dev); } @@ -754,6 +760,7 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1) { struct usb_port *port_dev; struct usb_device *hdev = hub->hdev; + struct fwnode_handle *fwnode = dev_fwnode(&hdev->dev); int retval; port_dev = kzalloc_obj(*port_dev); @@ -782,6 +789,24 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1) port_dev->dev.driver = &usb_port_driver; dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev), port1); + + /* + * ACPI FW nodes are associated later when device_register() happens. + * Skip assigning one here to avoid potential conflicts. + */ + if (!is_acpi_node(fwnode)) { + struct fwnode_handle *port; + + /* + * fwnode_graph_get_port_by_id() returns either a valid fwnode handle + * or NULL. Passing NULL to device_set_node() clears any associated + * fwnode. It is effectively a no-op here, since no fwnode has been + * assigned to the newly created device yet. + */ + port = fwnode_graph_get_port_by_id(fwnode, port1, FWNODE_GRAPH_DEVICE_DISABLED); + device_set_node(&port_dev->dev, port); + } + mutex_init(&port_dev->status_lock); retval = device_register(&port_dev->dev); if (retval) { -- 2.55.0.229.g6434b31f56-goog