From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9655B3B42CB for ; Tue, 21 Jul 2026 08:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784622315; cv=none; b=IR6Tl4Bmm4mUjYL5ixEPeHkGKoUyKqpsi4OTX5Dpo04jnerXfWVnEp05uJkFSRQ4AaMSqqUJOjj6I+xF6fuGce8i/Ley+NKk/AnrxHwFOdq4XhaUMV6XLNm9t4W2FzC36UDRSwmqxN+kXOOqWwNW5dqR8ih0GJs6jDAJJDdoPrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784622315; c=relaxed/simple; bh=zfTn2Kc9WqhfDc14tF4xKypbGNJXvuqTxtRlcOWMzUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UvKIiGBzcU62dqlMtHhs72je4ctbWj0YnDcUdbFm56ETQ8A/hnF86Nwh6dwUC/di36Yr+YC17CvvW7aaVM0Tb8THyi03e1nNoVWXVRVyvjCfhBmWNoqiCSTxVTCsOL881uE6MGinYkWLCBBBwIh0vWhZcD9lyCl95AWbdxFrn+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gCrU7rNE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gu99pYuy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gCrU7rNE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gu99pYuy" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L44FgE534746 for ; Tue, 21 Jul 2026 08:25:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ZOpXARkKmNj 6Eb4RGQZtpa8uRlFLKJu52rmjCAOrvGE=; b=gCrU7rNESdBaziZfASg/j/KEnMQ sdlPBSIT5NYy8W/vsKm1PIHRQOoaN1kZx+0mOp3sFJgxqa9gnVQ0+LjRX/x8uzcN C4ZwgcgIDNI1+mIUyfLz+6J/yhejv6Elal4j7p/vmpumcaIPWtLNfXMI+Vm7QjOd 4DeNvwp5dVK98Axqbt91dTcWJcT3r/slntjW+4llujsAcm4OQphLHGyvD7/T13Gp EDs4bp8O4wcyswzyNF7j7ifD03hESYOfCokjbvfLYXdz4w9+sD7iVhu4HBkqmVOW vXI6NoEScJ2l4LZPJBUggIzVUavw7yWejaIGwva49mQJ6bKPhHA455WGdRQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1duh0ek-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 08:25:12 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8f000e221d7so164904576d6.0 for ; Tue, 21 Jul 2026 01:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784622312; x=1785227112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZOpXARkKmNj6Eb4RGQZtpa8uRlFLKJu52rmjCAOrvGE=; b=Gu99pYuyEsMxBehhb3NWGlTOGLEssUTWN2AbHLBOyw5gGLLi0UMeDILYydFfMaueLO h5dTcW3gTkiUZWIMNO0kKkwL+rMzN9Rx2MrHvQKh6jLdKYBAQjxBjGGxqOjDCDjswkh3 T5FcBRMYQJuQJOtI3EC3WhGGBmCLCQ+jnT9bXLqeBn6cvDGSReYDES9iatbghd1kSH6A vN21pzUTCgA+Md0PjdilJgpfJKbkt3nfOB8sf8sWsnAqb20Xtb1qb5gVkjF7B8BsEI+O HhdxjRtA3dINOoeKGSmqsvS2fxLT9k/SUKGY0Tp+dk9NJJgP8kkvLTlG+2APXJfGJ0Uq 6P3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784622312; x=1785227112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ZOpXARkKmNj6Eb4RGQZtpa8uRlFLKJu52rmjCAOrvGE=; b=W90SaQFvOcBa5HuYWlsQWgteCW7/JnkpbKFIuz7H2tauKe3QzpKcDgUl/H8Y/vVNZX SJgaFkczEhhYLtWOhzhh40mN4RqA4SH+yrasyQUb3W/9kGBfT41cYVIaimEfxLmEtWDj EcwW+FFbacET5yx+6ka3JvJZR851fkV/5j38qQN20oDCrqlPRbSQbVGhm/cQ3zfA1CHQ XD4YDcj0NW64FxRAqMZSjDbZiZPIseMfBFVHxuaMSaEyj/r7SKEhyNF11SQpYVHImey7 a/4R/pwgijmiT9OvvN4ToOQ5XItLD43H24ELQ1MUmnYYGrTyoPsY4pnX+qq3sA9yFOMa 2LSQ== X-Forwarded-Encrypted: i=1; AHgh+RpyCdzTM+mbpydDkhS2DpGgtEl3O/eH2Tkw8pi0ZSo9EjifFBx1C/tNMkLlhbIBKZ76r9AYsBT2Frylz1k=@vger.kernel.org X-Gm-Message-State: AOJu0YwqfW22HzAR5gT7Jm03gvDarK+FNDhhn1JN3d1es6wnN8VNsXIZ QiL/LDNb253qmRsLAUjOpp/9EA/ToCUnIwsZg7hF70vimIYb7CZTYlsYOMiA6cwhwwhFy+W8YN+ dZ/ri28tl6siRfhkfGqO10DaqKhPsryAVfL/XTdz1f3UBotPPerfkK8D88dqz+Ra+siw= X-Gm-Gg: AfdE7ckqFklUF4MWLOIS8Fz84niex3sP0ajFE0XmVfE3UuoXaI26khvsPi37kwEsp5s +Sv9HJJpWc3cfjiy7jk5VjLOHO7TzWv3VrH57/0KTvJqYsvfKB0c8BaPOk4ICxTvDCyEYnkr4mC 0+JlmdStO+5uEZftWwNv025mj1FMKW1J1LFzNJTsjMo7n4ffujL1668QG+VdqZ+QB1HMEnMpBT+ nc2DVqc/eR1cDz4Efq6A5k//vRfe5XHukO/5LxGgnNbgjqvVw8atVtSLepdGFTQESEt9GyryZZc UEfghV4aoXlgCaxOsGOG233TA6zkQap3cpjYtTTYRdvzKHwztqqsKrwHY/QQb7bVoDZL7EL77ch BlYChnMseelC2xCvtxW4H2Y9Xetht X-Received: by 2002:ac8:5d13:0:b0:51c:bb79:a52d with SMTP id d75a77b69052e-5213aa6d813mr166970901cf.14.1784622311586; Tue, 21 Jul 2026 01:25:11 -0700 (PDT) X-Received: by 2002:ac8:5d13:0:b0:51c:bb79:a52d with SMTP id d75a77b69052e-5213aa6d813mr166970631cf.14.1784622310894; Tue, 21 Jul 2026 01:25:10 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:9dcf:9ab8:bffb:ec35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm39901054f8f.21.2026.07.21.01.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 01:25:09 -0700 (PDT) From: Bartosz Golaszewski To: Herbert Xu Cc: Bartosz Golaszewski , demiobenour@gmail.com, Russell King , "David S. Miller" , Eric Biggers , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org, brgl@kernel.org Subject: Re: [PATCH v2] drivers/crypto: Mark QCE as BROKEN Date: Tue, 21 Jul 2026 10:24:58 +0200 Message-ID: <20260721082501.6128-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: <20260712-qce-broken-v2-1-b2dfff47f7f5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: FWrUmoT0YlfTfxw13ebnisG_35aps6Jd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA4NiBTYWx0ZWRfX87a/2LgGvsla 5xO5ry+XvJZ2ldt/WENmsppFt20ecZOLz7v2kmTIYOBoqtLmEF1TjXMsfkj5LZKu1hH2l1OLooF rw5cLCNRnL3gdxAyBTUDe4lK6PKr1zx2G36eQwHnL/C1MqpCktL2GNOBTFuF8gahyB5gd4bywfa InypKC/ZLzjRnF8TpsyjrQo8z+FdytQPzpYBZmlm27KhKRYMPO9DIzscezVPPgYjU/if6ikVlaj jsS4H5Uo3mWZtPVneVZtXLUEsmj9QuLDlrwWm6i3TtYbKuaArEYpFrgo0v7R7wXfmTLxlyISSJv r7R9xrHg7rHFm9HTb8riiWffU4eIuxkAO8v5mbvMTXamMRKNvRsMkdYpNKCvk/AZgWbnr5Soyvo 5/xGGQXEYzlL8sQaLVdZBod3TNZ/Cjx9wtR2sxq1T8xyosPQDTSV4WMnxmBQOzDnmo8V2e2+OAu M6dXWTaxsE4s6ysw4sw== X-Authority-Analysis: v=2.4 cv=I9JVgtgg c=1 sm=1 tr=0 ts=6a5f2ce8 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=SHEdVmtcqMJQtNp9YQoA:9 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: FWrUmoT0YlfTfxw13ebnisG_35aps6Jd X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA4NiBTYWx0ZWRfX/rzX/pOyLyji G2EVBY/cu5AJy0Oj1hIYnG6U5WE4++SCg7U7egiV5xUJ0C+wEEKhhQingYQg/URiZ/ejKUnmmRD br+X8+DVshN645LUaLIikfMuk1fGqFg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210086 On Fri, Jul 17, 2026 at 06:18:48PM +1000, Herbert Xu wrote: > On Sun, Jul 12, 2026 at 05:31:31PM -0400, Demi Marie Obenour via B4 Relay wrote: > > From: Demi Marie Obenour > > > > This driver is harmful: > > > > - It is much slower than the CPU [1] [2]. > > - It Has a history of bugs [2] [3]. > > - It does not have exclusive access to the hardware [4], causing races > > with the secure world. > > - It register its implementations with too low a cra_priority for them > > to be actually used [5]. > > > > Therefore, disable it to ensure that nobody builds it into kernels they > > intend to ship. > > > > In the future, the driver will be used for processing restricted media > > content. However, the kernel does not currently support this. Since > > the driver will have future uses, allow building it if COMPILE_TEST is > > enabled. > > > > [1]: https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/ > > [2]: https://lore.kernel.org/r/20250615031807.GA81869@sol/ > > [3]: https://lore.kernel.org/r/20260706-qce-fix-self-tests-v5-0-86f461ff1829@oss.qualcomm.com/ > > [4]: https://lore.kernel.org/r/20260629-qcom-qce-cmd-descr-v20-0-56f67da84c05@oss.qualcomm.com/ > > [5]: https://lore.kernel.org/r/20260524204537.GB110177@quark/ > > > > Fixes: ec8f5d8f6f76 ("crypto: qce - Qualcomm crypto engine driver") > > Signed-off-by: Demi Marie Obenour > > --- > > Changes in v2: > > - Add Fixes: ec8f5d8f6f76 ("crypto: qce - Qualcomm crypto engine driver") > > - Add Cc: stable@vger.kernel.org > > - Link to v1: https://lore.kernel.org/r/20260712-qce-broken-v1-1-85e2bff17871@gmail.com > > --- > > arch/arm/configs/multi_v7_defconfig | 1 - > > arch/arm64/configs/defconfig | 1 - > > drivers/crypto/Kconfig | 6 +++++- > > 3 files changed, 5 insertions(+), 3 deletions(-) > > Patch applied. Thanks. Hi Herbert, I'd like to ask you to back this patch out. Admittedly I should have NAKed this under the v1 thread but I thought the discussion we had under the Shikra series and the subsequent patch making myself the maintainer of this driver (note: Demi did not Cc me on this nor the Qcom mailing list at linux-arm-msm) as well as the pending series[1] fixing the QCE issues was enough to imply we should not mark it as broken. Please consider applying [1] if the fixes in v6 are correct. Bartosz [1] https://lore.kernel.org/all/20260717-qce-fix-self-tests-v6-0-455775fe5f6c@oss.qualcomm.com/