From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15EF93B3C15 for ; Tue, 21 Jul 2026 20:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666200; cv=none; b=HwlWD8s34EA7DRt2I1KQ6DsX3TOofKpZWRK+Q4L3wD16XmAsPlqdotjU19mrCeICJuogUWL+6DXaYcAoL9YzkxVcB8eiNu87N5FXhwlxDKOO0C99rLvfcgcZFdu9pWPi6A3jvyhMfOr4URCUMkjI2ZYcEWfGFHZRse6J/5OzRmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784666200; c=relaxed/simple; bh=XIvGGDAaThdDV0LUz6beat7MwFI5tcL0lS8UNZFIuk8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=UeXS8188B6YgRKwyTbKKkakzVeUKIjWscXRzWmelJgZApy0fQ7TrO8Qbe5eVTaivWBBiaiuhrdxx6TozKgcfqjbUxswrsHSxMESXWX6HQRO84Afto/pdRKyexR7iquAGJCDEU15uz6xHX25k3xC7WeJ8di5IZ1IT9Ma9+ADZfDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=XLQwPvZ9; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="XLQwPvZ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D9AC1F00A3A; Tue, 21 Jul 2026 20:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1784666197; bh=75nElkeyX/1rftfHH9IMo3FcFB/4yMecwRs8lFAe3OE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=XLQwPvZ9xtGdL+DY6bGaWTnkoRGbd9wQqD5w1Arm5TIeVUGypID8HUCBGnz9J8BB0 Yo5uCAe6oRTZsXgu4C8V9DsfiA5c8LCvitKVd4cAK1Bd9q5+aNkMoju59xFum2nqUX G4MuLqf+yYanRswvoRSguhUqrQUGE3l3AbfRt5AA= Date: Tue, 21 Jul 2026 13:36:36 -0700 From: Andrew Morton To: Will Deacon Cc: muchun.song@linux.dev, osalvador@suse.de, ljs@kernel.org, david@kernel.org, liam@infradead.org, Dev Jain , catalin.marinas@arm.com, kernel-team@android.com, riel@surriel.com, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kas@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, apopple@nvidia.com, rcampbell@nvidia.com, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, ying.huang@linux.alibaba.com, ak@linux.intel.com, nao.horiguchi@gmail.com, mel@csn.ul.ie, j-nomura@ce.jp.nec.com, pfalcato@suse.de, tglx@kernel.org, dave.hansen@intel.com, jpoimboe@kernel.org, linux-arm-kernel@lists.infradead.org, ryan.roberts@arm.com, anshuman.khandual@arm.com Subject: Re: [PATCH v3 0/6] Fix incorrect access of hugetlb pte entries Message-Id: <20260721133636.df1a012df895054d3fd34a2e@linux-foundation.org> In-Reply-To: <178464737122.1305746.12295190523058911270.b4-ty@kernel.org> References: <20260703114202.365553-1-dev.jain@arm.com> <178464737122.1305746.12295190523058911270.b4-ty@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 21 Jul 2026 18:18:38 +0100 Will Deacon wrote: > On Fri, 03 Jul 2026 11:41:53 +0000, Dev Jain wrote: > > There are various places which use ptep_get() to get the pte entry > > corresponding to a hugetlb folio. Some arches (like s390) have special > > handling to compute the pteval, so they provide huge_ptep_get(). Use this > > helper consistently. > > > > Additionally, some code paths may provide huge_ptep_get with an unaligned > > address. This is a problem on arm64 (I checked other arches and it looks > > fine for them), which is fixed in patch 1. The fix is made to be > > to huge_ptep_get() - that is wider churn and we can do that later. > > > > [...] > > Applied first patch to arm64 (for-next/fixes), thanks! > > [1/6] arm64: make huge_ptep_get handled unaligned addresses > https://git.kernel.org/arm64/c/9175a8c7cfe88 > > I'm hoping Andrew can drop this from the mm tree to avoid a duplicate, > but I didn't hear back yet and I'd like to land the fix. I can redo Dev's series to omit [1/6]. The patches apply that way, but there might be build-time or runtime issues running the other patches without [1/6] present, haven't looked. Also, review indicates that the changelog requires updating (https://lore.kernel.org/all/2b9d60a2-8698-46b0-80ae-b8747a66a85b@kernel.org/) and I believe that Dev plans to do that. IOW, it would be better to carry this in mm.git with your ack. Do you plan to upstream this in 7.2-rcX? If so then I can hang onto this patch until it appears in mainline. Or something.