From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4515401A18 for ; Tue, 21 Jul 2026 17:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654845; cv=none; b=u5PrTG2FhW5n4p1E3zN38RXtkF9k1B7UqHrZdCUDN0FS6b4X44INPhUuWGiTe6Y15+HiQqSno79708MGqSI03RLxL5u7ozkX9OeC49Bxs54B+xgyOt/P0320CA4NMeXDKQYFAXMG8PuH24A/rRZXmIKpevcmTatTnEHKOXFoecw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654845; c=relaxed/simple; bh=SWocx1zV+cyb7BRIUwblLWB3TOFqoHLH0eZrzF7gFiM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=azOr2+mA9/UgV7Xi9sqqDaGEKkEIUDQ/h/C1hDMxkXxdfrJgcody0auO/ujewRaUzwJxEGqmUY7m3wYv2LbVhpAWA3oe03tkKOIznGsg8CBXUZegu/X7NlyE9bGpwZWY4KNrJE//UYFZ6NNh7A2dTjUNJDcDLgEj3LNpWlJVBPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQZ5O27l; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQZ5O27l" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f707e5d75so1877270f8f.1 for ; Tue, 21 Jul 2026 10:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784654842; x=1785259642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=aQZ5O27l3X2V3zUdpDC1MDbdV+PVKLF2jBh6wN7x8FLkel2M5W6rz6rm8m6rprsN+W SVAVrkY7Se0cpeyoTl4Jnejh2NS5maDF1GMkNUPrj+0BuH0nywCoXctEd8hAdwuPB3gW 2+pp2zJTyChzCWeMbVHxr2ETUTOHibCbCtXRT9+mcZd7wuXIqRjYFf1reusScGsv3/N+ QjtCXgIdH2XrXB9gGorI7pWy5AQ9eLMPNA0rL1EbNai8D7Qbv3cX2SlqlhaRCtvSR/yX f3LFb1p8OLVQtwTYPMD3Ypt5pA+Y6kseyENCyQpZOUioNdV0929tFVv6NEDxOiU6wFpW tSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784654842; x=1785259642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=fpBWSkPeQkBPukUGEdefgYYD5Cr9XufC3gHqfSolIoo7M4h5k3nX8Mtu/1p2Ilj8wa iZXmsDqcVt9B7lG9KNshMLsDNHWP4k16ah3lXlATQHP6dvhyNrnE2EEqx8lVUF4CYLv6 koAMTl9EfFAh1kQMALBQh5bJmCjZBBdTXxXd3rpmVLFMiu9aK22QbRpx8K7q5M8K4DLC rgPOtfvnf4IPKv/yuOwgKAFSseI0kUUBLHmNwVSR4sZX+JmpBpoV6+xc3ZKh4pHRkhNN 1HhlHY9QTmnPmbh1cuIU1M+51w+mCCaZjz7w+0PTKsixB0Hh1wTgHCkPEOXsWrMRXEgr KY8Q== X-Forwarded-Encrypted: i=1; AHgh+RpOQ6z+1tH1nmx9I9uJzEdlDBgw4IBoZzFZ4IciRJ5SsQAt6DECDkN5ycP9M4wvtXh/ah9KcMeeUv0vyIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzpA9aPqPbdR+qIXYEuM8aKh/U7JCmwB1R81ug2tW2m5Aocua1y a5NrRyuwJUbraKMrs92S9FiHSZS3VIqgpadsb0qCS8ah8XR1JboPci4e X-Gm-Gg: AfdE7cm0ILR6LlCq0KYvgqVAaeDaG6TgfDxlhRu/U2CYiUzIyzy0CMWV5ofJXExykBU yiAuW0y2zTEMzr+xXgHZkjc3XzMe1NEdmKvHcydvd8M9vQZNKUD1PTIWnxoElb9udI6ZRaFil9C qMRw24sJCjgbWraxBv79T0i1LhHBOi3KTnxzWnw0jnCzggV12VR/+YczOF7b8P1If4opAzT1DMj InvwjwvyecjAA59byIhvb9oDBm7g9jnQD+uGS2uX1IkCsRc+PDf20VDebETjah9CuDtMuU+quJ0 2PG7Z9QgNTqFuZaNoLRcYmTdGj7GlI0JZrYPHiVqeK39yEnuxCJUV1u1lV6y+s8OTIr6f52Tc0w ukY7aBzA5mBi7oT6RrfsrlYTlIk8fucl7GmmAlOcpgiVKIBex2NZCre6U3doYNIiZ6wZC8tagYf fDWZo2CSWa+6a7xYD86TJ9lpl4yoB8uXPYQZkqnxlY0sITUqzO X-Received: by 2002:a05:600c:8284:b0:495:5d6d:d4f7 with SMTP id 5b1f17b1804b1-4955d6dd523mr129158855e9.24.1784654841621; Tue, 21 Jul 2026 10:27:21 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a4f9a11sm7593595e9.4.2026.07.21.10.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 10:27:21 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v3 1/3] drm/panel: ilitek-ili9805: Use _multi variants Date: Tue, 21 Jul 2026 20:27:13 +0300 Message-ID: <20260721172715.602196-2-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721172715.602196-1-michail.tatas@gmail.com> References: <20260721172715.602196-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file. The multi variant of these functions include improved error handling. Signed-off-by: Michail Tatas Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c index e6c483851f1f..7e9587afebbe 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) static int ili9805_activate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int i, ret; + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; + int i; for (i = 0; i < ctx->desc->init_length; i++) { const struct ili9805_instr *instr = &ctx->desc->init[i]; - ret = mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); - if (ret < 0) - return ret; + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); if (instr->delay > 0) - msleep(instr->delay); - } - - ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); - return ret; + mipi_dsi_msleep(&dsi_ctx, instr->delay); } - usleep_range(5000, 6000); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); - ret = mipi_dsi_dcs_set_display_on(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to set display ON (%d)\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } static int ili9805_prepare(struct drm_panel *panel) @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) static int ili9805_deactivate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi = ctx->dsi; - struct device *dev = &dsi->dev; - int ret; - - ret = mipi_dsi_dcs_set_display_off(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display OFF (%d)\n", ret); - return ret; - } + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; - usleep_range(5000, 10000); - - ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - return 0; + return dsi_ctx.accum_err; } static int ili9805_unprepare(struct drm_panel *panel) -- 2.43.0