From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46FFF45A291 for ; Tue, 21 Jul 2026 22:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672150; cv=none; b=Obq+T4oRYOmAwW6clamaJRdnqjFWfSBikSoSaIDAi5Hu7a89NaYIiRsSjVWQvnnp928SExpjNtmL3tDbibTZIexR48nQJbGCFZRpYvqlsi70K9DQvEV+8pYpvBT6aLVk7UPhilDXyOVfWjHw9ysr2atfuebl921FYD0RCy1mYRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784672150; c=relaxed/simple; bh=VylVE97urOnGo1fKhA1IwM8dNjVc6rVPycHxhapEvGA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nVzN9VQawB4NBdQk0e1l4xvoyxYkI/672qHkgmdSl7N200yYjRvy25dwGeU7Joepp3dDuvhLycIyiLpbemW9S9aNNrMGCVz0Ke6vIsOjoQfr/ogS1u8oxFN2H02rxgrHO1BwV+vprvwEFi7fRwOgPI1zFrJ5szMD8FBxLn9R74Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WhMhKu1t; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WhMhKu1t" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-ca2fad0ae38so9231223a12.3 for ; Tue, 21 Jul 2026 15:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784672149; x=1785276949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5mP6wFrKPhYjd/5KHULwyWUdonzv0xy3jN9195/5g2U=; b=WhMhKu1tzHDSY/1mwMMhB10yCS21VcrNOG24xbGFP/TljIzjw3V+C8SD+v6CyxMlPR /GvxPSJFZsW6G5VH5FmHIiwekS0jpd9IADSz1IKxB9OvJB9PkvO76pJkI5RvNAGr4nlw WKNywSAM8Z7g/HLnCtJJojyyA/nAV+L1vfrIyP+BbGRn3bxT3Q2V7aJMBbOfmL/X9AU+ +4cMuPCfkss4vMwsVqd/+s3S4+uIcxfAiOqz5HZnm9MvMf+2rZMlkyskEw+veFBlwjQ6 ADugWw7ixYd/InKQdTpc4311w/7BAZINvrUbSF0Y6/mJ3vxxZUMtH7sRHih+1D5Nv7nx 7jdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784672149; x=1785276949; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5mP6wFrKPhYjd/5KHULwyWUdonzv0xy3jN9195/5g2U=; b=q010lkZckja8c4zvtNZ37KjzpR+SrF+M4r0mweh3na12OImcORLgEoIFGrN/nlMl5F LzubhZCxBiNNKge0GR+JybC+wIBuIr5g8R8xzGarQ3s6ChXGiaf55lbqIUvkcEuhWMOz ZnoMtF1MpA7dxIklXgKlXxY4/QQPW1tPYOFiyO+50ZKWKoxF+ip+nCV4Dc5SF88H7vrY DhJ+gx2ar9405R7xGVMc38OdEDP8ZHz2KX3ZmwU0/LNQyt4a/lAApsXi0Qa3JLnpevv+ YqdzXTRssO644HeRb4CR+GgwpKH+NEe9tqv2fopu0plogsbilyM3WG7T10q/lMMW2KOP ww+Q== X-Forwarded-Encrypted: i=1; AHgh+Rr0KuhcLrWgBseO0L/ceMT0m9wGPG8HawpjU40HFbN68jANBriKDnRm3bIxwrxAzAqSrbi4ON64p0CYUrM=@vger.kernel.org X-Gm-Message-State: AOJu0YykeBmdCsuEp9g0dyG0IbaOM+lYzqjTEHpa+/a/5o2+piP7JRca cdJR/j/UjlJO3SJe8Jv+juC/zflP+TJYjlZxq0ormFYsiE5/jPTmCWbBal1GxQ== X-Gm-Gg: AR+sD10xu0kKUgJmSabRfHKES8RiAhNT2tZXdysdgPeGUqxgF8dLiKFVkb3EH32uzdZ 6FSpDAzpqjIpXxCwguuW7RlFCKQDBpbRnFBfgdzlzze6+xHFwg3IZd20iVG5x9nj03ZTIlRhyi9 rFZTNKW+xaIO3jA/xoONbNUbYKJFp6gnnzrAh5DdLQullA8/asK4gD5qKeMxJTr8lHjzOxptu6M BAbPmL4rYi/fCX4766FikMFYVXoonxKH7/+SZlRL/mndLk3OsTaloN+fF0GplWU5n6r0fVIIW/v 3sQXsusaYxQD+8rxT88NwiGG0jwukj3t33QjOHVWcMW6/hyT9uU3mdE29/D/FG9uU26M4ld9wx0 ohGiJ18qth59b0d9QRkTDTjxzteizQ0ZsX0HPe4XYefbXveKLokjq1VLpaZU2hVbgCxNjJNEzXE 0onTxq4A== X-Received: by 2002:a05:6a20:549b:b0:3bf:9c93:ac44 with SMTP id adf61e73a8af0-3c3ad66b543mr23855336637.19.1784672148601; Tue, 21 Jul 2026 15:15:48 -0700 (PDT) Received: from localhost ([2620:10d:c090:500::9edb]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e088d3fsm2093442eec.25.2026.07.21.15.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 15:15:48 -0700 (PDT) From: Zinc Lim To: Alexander Duyck , Jakub Kicinski , Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Guenter Roeck , Simon Horman , Mohsin Bashir Cc: kernel-team@meta.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, zinclim@meta.com, Zinc Lim Subject: [PATCH net-next 2/6] eth: fbnic: expose all hwmon attributes unconditionally as read-only Date: Tue, 21 Jul 2026 15:15:36 -0700 Message-ID: <20260721221540.648272-3-limzhineng2@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721221540.648272-1-limzhineng2@gmail.com> References: <20260721221540.648272-1-limzhineng2@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit All fbnic hwmon attributes are read-only and always present, so fbnic_hwmon_is_visible() can simply return 0444 for everything instead of matching on the sensor type and attribute. This also prepares for the threshold and alarm attributes added in the following patches: they are exposed unconditionally and reads return attribute values. Signed-off-by: Zinc Lim --- drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c index 6c8c66ab86c1..38bb26cb8e6c 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c @@ -20,12 +20,7 @@ static umode_t fbnic_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type, u32 attr, int channel) { - if (type == hwmon_temp && attr == hwmon_temp_input) - return 0444; - if (type == hwmon_in && attr == hwmon_in_input) - return 0444; - - return 0; + return 0444; } static int fbnic_hwmon_sensor_read(struct fbnic_dev *fbd, int id, long *val) -- 2.53.0-Meta