From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473EE3DB33D for ; Wed, 22 Jul 2026 06:37:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784702251; cv=none; b=YVW01HBpRCNMB6PZLHPv+YEUBp8U0XpEfUWaHNS+9iLso8dpNOs19H06qsXSD0PiTshax6GA9bi48vK2MhGCgCrYxQPjPYVDkY6emMjoSjmYuEKa3yAvErhwaSdsHwqCi3VMf90yyhZlBr3Uz+82bpJh787ajffQQLUweBZHpgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784702251; c=relaxed/simple; bh=ru2Wb6WusJrEqzG9fcYZvfqNT3ibrquiqxYIOULpW3A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ONCsJmQL/5AMa2zhRvfYu1NmvnCxZlZlQb5cXqB5KhZZ87+ykoLiUPhQo3cETeeKcF7qdkRaTJhPM85jU4/yU2kENNU4DzmIV51UPLn7WTvo+19m8Il5vDTMlLiHRdn7U9/TtY0UqEKuJzWp9Fq6qRFVDHpn2FsQhnK5x450P44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SvqVDo1k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GGlZaI0I; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SvqVDo1k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GGlZaI0I" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M623D3984644 for ; Wed, 22 Jul 2026 06:37:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RkBsQAWB9soKsoLrvCV1NtPiFvCgA8F8m7591cr4bVk=; b=SvqVDo1k0aC+hWx9 mj7liaY+to0Mp4vspuNWeID2pX5m8amrD0BHR+vXtYZdiA59nhYIvL9vnqIIl/B7 wl8J+UuEecS3loZwwve7Qp0/1QzndntHHVt5jkU2LKd+QK2WGKkciwaCoAVPb5Ui LUsN1nHx/03t7+7hAbYCLvQafn+tp4rZxDZebgfK/N7Zk1lARSqBxNVZTO3vfoCh 5vqqxnkQ6D6NXdagserTw7egeNoBdZT/5xG/zOdkFDnZhaao6DdHf31XuRe/JFJZ R4ZGMzyKIlRgjJ5TsC7ACYsviix0cBXgHMTmon6vN1GeKyUQ7PDCpbRQ6uAMxWIO qaXI5g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjr8384b1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 06:37:29 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c21c01cf3so193872761cf.2 for ; Tue, 21 Jul 2026 23:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784702248; x=1785307048; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RkBsQAWB9soKsoLrvCV1NtPiFvCgA8F8m7591cr4bVk=; b=GGlZaI0IhXlq5ce2ItTB60SBnN0e2EPXyXexEzKassmJNj4R2gG/eRVXLCWI1DRWST cFvKTgnsPMMIT4iqNlQy8rNPwnFP6uNz/+axinx8frzpCSiJwXUOjmS4PMcX09V/xokc KHaLgzPdTLaZOoO3z6a4ml2kVmYX4vw8WGFifRhkxLyoLKRsRH/MIJz5t9LkU9VOE4ti xUi9puOCXJNfTmO6uoVxwejDx6iBvV+N+8SDqKieasssOEtsEJgkCgxd/fTM4whoLD3m wZm8jok3KYAD9r5ssLqNXnpd2YbztPay2htKlF1+Lb4Qmaj2rV2U0CF/iWajKNhILaWQ Fgzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784702248; x=1785307048; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RkBsQAWB9soKsoLrvCV1NtPiFvCgA8F8m7591cr4bVk=; b=px/FfwwWWZfTSA3je46u7eS6mOkQ3ZPQv4G7mW6IgS+Gt3ul9AxpxdUwozHUSkLmKO +OfLzdU4y2r9MjKUg4dT5AJ6eOEE3TeVVWTe3cObX2gADMJkVUqY34unw+CG/m31vfUr CILiycg+Oh76aANvknsAvWTkF7WEG7rZfaO4olJHoRRhIk++nvORnoM+K8adN6mQrVSs kJe/6a9SKdPbTgTuG/vJgehL2/Fnzv2VyIku1qkYkhSEG8bVtGZLVeSiYcQsFPduQ4mr EuiuvjaAgFDtKxbnHXRM35Bu7JyxRauFuBPyU6qeXPfpiJ8on2H4ad7SpjwrJfYksBZ6 TPag== X-Forwarded-Encrypted: i=1; AHgh+RoUqdc0KcxCGby87fLIhu8Qzi8F0JeMLdEejgHHIYLF4wFOnOrnORULua9cNCNaQL9FhgcyxV9zAhAZWrU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxof1vl/07/nJb/a9pSYAt5vwLYV2YpHtSxBJuHdNMBlGPO+oA9 2DGHznChQPOtMVdaplik4aNrVneoFnrWvi0ChnyGvophUxjIIo+9Q8/qHgopzXWlfDQSkwTCvUW 4/dEZCRWqR0jKyGqzKmyZZeyrlXVOFcsvZ7sPQ1uspna2mp+TeijynR9XstPbwy65G+8= X-Gm-Gg: AR+sD11RT5PSqCj5Iv/iO5G6ZhvPN/eLM2Uj0+IVN3cA6004ujOq8Dl3qqutzYKhmRF 1Guq1z2K6A63D/ycYDmYBqU01OmCfr7LCC12Lcm2dze0hxqNtMGzxD5IpGpF0vx1KxCn45G06KL qtmwAjJit+jkcrtmp7XpWWZ5M67xuIQMcJS3+OFNtFA8mErwQdrtEa4ZhcuMJwtjiGM8PxU/f4J /RvDkK88k2cz7k1cDBBQWB41CxnZw98KiCqZKzXX9cZF78oj5O4HDwZRvzbvvnmBv8kuKXkrdvs YNZSBNv5QrFzacLa26y9LLwvTKBwwWqnmNhC//flmnIXG9ff5oa0jI4eLcv56HakrCzbUXOfpIO 8nhU0lzQyv04oCNG+cYUecog2pF7lCrhc5VeUxzXNLNXcVhPI75LBZ001I0YU87Tx18hP8onQnn VKbOyzkCwDKOSFuw== X-Received: by 2002:ac8:5a86:0:b0:51a:329:e802 with SMTP id d75a77b69052e-5213f66c60amr209095011cf.41.1784702248631; Tue, 21 Jul 2026 23:37:28 -0700 (PDT) X-Received: by 2002:ac8:5a86:0:b0:51a:329:e802 with SMTP id d75a77b69052e-5213f66c60amr209094831cf.41.1784702248174; Tue, 21 Jul 2026 23:37:28 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9b8c6f6sm309696e87.4.2026.07.21.23.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 23:37:27 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 22 Jul 2026 09:36:35 +0300 Subject: [PATCH 20/24] drm/msm/dp: use drm_display_info in mode_valid callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260722-drm-msm-display-interface-v1-20-368c10fe62fd@oss.qualcomm.com> References: <20260722-drm-msm-display-interface-v1-0-368c10fe62fd@oss.qualcomm.com> In-Reply-To: <20260722-drm-msm-display-interface-v1-0-368c10fe62fd@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2317; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ru2Wb6WusJrEqzG9fcYZvfqNT3ibrquiqxYIOULpW3A=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqYGTpm9cXV4806bVBAhjFnRwAnQLIwryFRMcY/ YP0nY0FHzGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCamBk6QAKCRCLPIo+Aiko 1TzoCAClTRqjxWI6IzRO/17UiIDa4gaX3f+NszHxiYQEom48W2TfKB8mGh9fsRKRnstpmfgPPzO fH6WvlGb2eutiVuEOieqlgFatmgNuZPmCuoZdnrFXKQYXeh7IUvQiuwvF9ZanX862b9NojoXefo EZ7mXokIAdN/tyI6s1EVEBjr3NhsGPq+/K6sWvlWhFEb+qcLvKumZJOqyD/8it5jnP6NxeUpKGq HvVbWWv0GY2cb2nQBlqUfsZObXK6e+8nkrsVXHNAJLWADwOMuU449p1JRPfQO4kz+DXrKrcf+bt YLqojqDPX7hIT/gx/7HcbnLPzWOlzQJhZsKnYJAF/Fe/pW4d X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: K9EqynhLVvjC3WfoETWm91OSXUe8JNi8 X-Authority-Analysis: v=2.4 cv=VfrH+lp9 c=1 sm=1 tr=0 ts=6a606529 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=oESPpdQVtlo-kY4fL14A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: K9EqynhLVvjC3WfoETWm91OSXUe8JNi8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA2MCBTYWx0ZWRfXwtB87M0rj34x pPkldfgGZbU+jBdI0OOe5H0FFxwYCzFxuXHxBQQrj1tRCtjxjJGU6wq2S4SeLgqb8sjd2jZTO0r BnHGbRMQFaar0gRDURvl9vE5KjKsDLSoQLjCZijyFyFfh/G4MmrRVgj/8+M81Cz41fbtS+CTzSE McLU6Fmif/4NajHhWhouqUEnJfYhW161wsBqK1i/FRAVuzWyzYBR6IxPxVioEgW4XtsFJxIbk3D zuD1T7GfXBayGN2YJOkNqf8ejViHsk5a4JCuQg/cqkCi9x5gEeoiTN4y9OV0P/lEt47tWf3X97J +DQm47awbJji8V5tqizNMl+R3kE+vboKE8Tu8N9rBfuPOy27vnyCvvO3AwriyBXvpbXHM1TGBi2 gSD2WZgjBsGVYMbWEBoUuz1D+DTohJyJUcWzL7nym1/w5Cl6indu1ZIITWsvFGECW9hN5+5zXzc 48+0CnowGajtk74ROKA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA2MCBTYWx0ZWRfX6IActjr7GZCd YNUB8GzNBbESCGRZSdWLMzczY1JocELqVfItdm8MTQUiSACgWXmIEFufpB93N24CFtl9jrzQl82 OBktc71zrZzEJWjP4ljs9NOK64+bMCY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220060 The .mode_valid bridge callback is passed the sink's drm_display_info directly, so msm_dp_bridge_mode_valid() and msm_edp_bridge_mode_valid() have no need to reach into the stored connector for it. Use the supplied info pointer and drop the now-pointless !dp->connector guard. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_drm.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 461420a72820..3397a3a47ef3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -731,7 +731,7 @@ enum drm_mode_status msm_dp_bridge_mode_valid(struct drm_bridge *bridge, dp = to_dp_bridge(bridge)->msm_dp_display; - if (!dp || !mode_pclk_khz || !dp->connector) { + if (!dp || !mode_pclk_khz) { DRM_ERROR("invalid params\n"); return -EINVAL; } @@ -739,7 +739,7 @@ enum drm_mode_status msm_dp_bridge_mode_valid(struct drm_bridge *bridge, msm_dp_display = container_of(dp, struct msm_dp_display_private, msm_dp_display); link_info = &msm_dp_display->panel->link_info; - is_yuv_420 = drm_mode_is_420_only(&dp->connector->display_info, mode); + is_yuv_420 = drm_mode_is_420_only(info, mode); /* * YUV 420 is carried over DP by signalling the colorimetry through a @@ -754,7 +754,7 @@ enum drm_mode_status msm_dp_bridge_mode_valid(struct drm_bridge *bridge, if (mode_pclk_khz > DP_MAX_PIXEL_CLK_KHZ) return MODE_CLOCK_HIGH; - mode_bpp = dp->connector->display_info.bpc * num_components; + mode_bpp = info->bpc * num_components; if (!mode_bpp) mode_bpp = default_bpp; diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 8dbe7d682ddf..6b55753da0f7 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -203,7 +203,7 @@ static enum drm_mode_status msm_edp_bridge_mode_valid(struct drm_bridge *bridge, dp = to_dp_bridge(bridge)->msm_dp_display; - if (!dp || !mode_pclk_khz || !dp->connector) { + if (!dp || !mode_pclk_khz) { DRM_ERROR("invalid params\n"); return -EINVAL; } -- 2.47.3