From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8E3403144 for ; Wed, 22 Jul 2026 06:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784702256; cv=none; b=RLsvwaJLOGsf4wNMD5wZukYSD6z8x9qRdCzhL+5e15AnP4gfrn+Ad/Kir45WK0rAPpTBGAkz4nza11QzyOk/a+3z2XoaAhj8CdrgRgKSwV1orT2t90krCT4tdXEUtmIMbr5hwVRDnhet36zE63S6msHEX8JFCk/YK7iHU5qLKR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784702256; c=relaxed/simple; bh=9/2o8KpXC7EG+vRWo0L9iXCJX0grbq1xFrlQ8yvb2cc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PXIPnluvl/ELCLYnfPg+CIrbAJm7TBKL9B/oPCLrpPtsdVZRVYQ+ASZMcKpGdWQYkXDFYDt/JUdmx3bZzBprnThhHmbahaE/WpuImbmO+Aoz3eL2vT4i76/g0nSe7bNwHjpLhix9Zn4y1ulqeGw5WPuSsD4+mUkFVFqBpw9fikw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GXm1Yfcs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NmrWeSlx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GXm1Yfcs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NmrWeSlx" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M53idY3473730 for ; Wed, 22 Jul 2026 06:37:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s5GcuVSqx3TARTmxR3YrApkKUxojUC5YenbypcGMgm8=; b=GXm1YfcsRmTqE3rC aILbKPzSetOC6pvsAzmynIuuXw9OlyqPoIOUf9dtoEDfi+aHt9vp+3e+VFmpTHc/ mUgiRBgCLqQIJugiJfALEhZ6P2QbzadQ8ZWU1szkp3Zxss1QM92X3PHwsJrQ3vNr v8zQzcdUyWvDiIDQA8WyOjM9t5YO5wUFL2WMtjqzUFXN/vjC9q+S9eHhUJU5fRO6 XIOK0eUrEbVLj+tjA8aMqaKNLhvreclevqL50D8Azh5f0fSMCZDi2P9DUkZvyVCs r6/TBFMlKANjoSPuoKB3m+7Ek76CiUFXPK0TUcjMogXJAfXd7yZpdnch1X+zuj+q NATlhg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjd6ftmdt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 06:37:33 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1b4d961dso102809011cf.1 for ; Tue, 21 Jul 2026 23:37:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784702253; x=1785307053; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s5GcuVSqx3TARTmxR3YrApkKUxojUC5YenbypcGMgm8=; b=NmrWeSlx+YgClf48aOKxHCBIs2fEuLtGkgbiKRTLWYSW5yV0QTFSe+M/J+9EyiQPb9 rUwsdxDmDzlht5aRZM4xwcg7EWeMurQcmiRC/kEFT+g17707znnao3Ydi0+ja/VZT2IB LHlSwPINETw4AGkqa3OQQHlKI+grDz2iZkBuygczGRXMO+pAwgRFfPsYRxAadW0+jUrs wUspXCgMn+L+MOCCjXODVTPA3iwgNdS3vekIqJZ+In2cGdtj86+Wu/VvNvJ88WhwcR1Z D2Pw6hwoZBhMvPbQt8kFT9toj7TjSZFQJC7EUT5HcEMU681fNgMLkDV4amwHw1oaaCy4 X8bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784702253; x=1785307053; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s5GcuVSqx3TARTmxR3YrApkKUxojUC5YenbypcGMgm8=; b=ZOyqrlpqtJ5tq16E69zzQawT2UDJ9Njd0ELsH4UoaQSu1bCAFOwN9gva5PmKOhoAOj 9//ebZfcTka1w3PX1rjZDuEB8YGchr2frfOXPa0tJk+R2fK5ivpWCOMIB+WB9H3wlR7K TdVE0rixoU3LvUILBm2ZsVS9a9qSgo87uXjfDlBqJdu1LRhe0rqDFxnAmLKDhgju76K9 Yv3Tl4oTmA/xA7Z0sXW75+LAEKpt2CJIxm86u3CuANasC5K3/jBBnf51xBF3OL9fnbXf E3y2Icm82yZofq1fXZKvH8tuxPhyB6uw6qsjlDXPmYcLC3dKwZm2CL3dnAw/tz8TY60p T1Ug== X-Forwarded-Encrypted: i=1; AHgh+Ro3EIE4a8fJRUPB8Gq3rN2zVXH5lBRatQ4X6OwJ+DhGCOMmr/asVuk9zWdzu7eerHr0aWtnbP1aPtOE0c0=@vger.kernel.org X-Gm-Message-State: AOJu0YxYiRroF4MqBi6W5abj20jysyosb8Y5S8UXLP31khWdMPOWull7 MSq6MeafTwr973B5Knn9nbBYB8bvtQumb9H0YNOWuH+1IlR3kvtHWLEVZcvNnMoYu4eyZxqNM6m 8H8El4oHFpOX6fdLSFI6VRXvOEhWDUvh5959EYZCn4VI9bAs2Xnl5drDbeDp8YrwE9Jg= X-Gm-Gg: AR+sD13Y042FpfAW7PpeRfYU1/idSe/y9nBug+UgzEizFnn0Hr7LSHqmZFms1JUDbyA G5Xy3/vg5iQhXjzWlEf37aeiRm9fkJyu4QLq0b+QBF0qsPRTtJLqYrvi9NZ8o2nNagnh1UGLbIN eDpM4yONlPSeaYGi5yUwa44Shnvk1gDsd/05ZuvrJn7DYXv1Tj1RBbGvazExrf6FOJjkkUOyisW qsQdo00cX4/qG1jtNJbGegTFzQt6bQdsZEl+IYePySooNKohDYVOkydRkDfg4tva1eSDbe3QeSM a0z5s+I2MK7l5/dfqYcnEjJnY/P16g/uaXRxBwNbMWYgxJ2IAa0/noeYiJ6EeNqZGyW6cJ5lMmU 6/B7hMzMDJm6fNwyyhOKCnEpw3ZYLlVxtWZjRnO0RR8Wp0YNJLyAvJEflQoHYMgKSivW8Cbql+f b22DfVZhyjPI5hYA== X-Received: by 2002:a05:622a:296:b0:517:c582:9161 with SMTP id d75a77b69052e-527a5c0ed5dmr28362911cf.7.1784702252773; Tue, 21 Jul 2026 23:37:32 -0700 (PDT) X-Received: by 2002:a05:622a:296:b0:517:c582:9161 with SMTP id d75a77b69052e-527a5c0ed5dmr28362611cf.7.1784702252378; Tue, 21 Jul 2026 23:37:32 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9b8c6f6sm309696e87.4.2026.07.21.23.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 23:37:29 -0700 (PDT) From: Dmitry Baryshkov Date: Wed, 22 Jul 2026 09:36:36 +0300 Subject: [PATCH 21/24] drm/msm/dp: guard subconnector setup on the connector type Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260722-drm-msm-display-interface-v1-21-368c10fe62fd@oss.qualcomm.com> References: <20260722-drm-msm-display-interface-v1-0-368c10fe62fd@oss.qualcomm.com> In-Reply-To: <20260722-drm-msm-display-interface-v1-0-368c10fe62fd@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2550; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=9/2o8KpXC7EG+vRWo0L9iXCJX0grbq1xFrlQ8yvb2cc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqYGTpUgbAG+XcsMyqOlI37kJQzxzDNWXSDTLYv bxCpiezV66JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCamBk6QAKCRCLPIo+Aiko 1QGGB/4w8HILPKpUQzeABwsNjmmVWbOg15aj3qwewGrfqofbXm0E2tKb3tVKsOCsG7v+DaBSTgz E35dLqPkiEAHhK/4mg4X3P2vxPpAloYItnJ7ecrofE133fJzft1hvxWP+MhKnwfrHo96ByF0Sbq LX2vsVRgNPrxG4tNvuIS6gp3tSzucv1orqKL8aPj6tSbCi4rT7pmqpyBATpDaGIRvRaUy1OuSEW NbPya+Cy7ssB9EJ5/VIXExfrLYOngNVhroCV0L3WU+QVDPVBUaK8t13XbRLr/ZpEZoJ86xcAsYn eaWfhzSh59icozOG5smoZvcMA4NAb1WsenQvJcawclpIt8JI X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 0opECfATbjqlqU2PBpEJ9HumX05CohMX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA2MCBTYWx0ZWRfX0IMPoEdYqdas ziE0l+0iRKWyXSyHJBggaito19qDPAn+bk9F1sgf4eit6UvUbM1YrIuP5CgdS6+v3DQtOX3O2g6 Pk4EHUlPH3WuvVgt5QReFR3admnvgdgdE3TKvcGEM7HJMfbp98W8NbgDTi140aGBMVOogrzXLXa mPcTdBJXrk7wlt0JqFkyi9e19pBX+oQcIXPHo1K7YM5AMgY94SaBEf9grghXtLOQEpB1iZ6yU1G MqDDV9CgENQxKwHXS4x98nNYaFMdSFgQm70u/LWR8U4jQyuitPlioCD0lheNWukSo2MBGG0Ae1/ 0s49uFRwaD5q5pqUud33GvtGFU/gMclCi3tJ/s6qwmR6NXjl8gbENDWFO8KRVdFo8zTHr8XiRNP 6qovwPA2MjLTA2l6WtH5Pt5cyWRONp+txb7WYdWX5qQSDRv9E7g+WpqXrFsRA6K0hYCMxhH3lBs IOcHtQwKxYdlh+dfKDA== X-Authority-Analysis: v=2.4 cv=e/o2j6p/ c=1 sm=1 tr=0 ts=6a60652d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=m6zLIIb-bBn14vORhpcA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: 0opECfATbjqlqU2PBpEJ9HumX05CohMX X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA2MCBTYWx0ZWRfX7OTFQOWoIr0x sLwcPk6vx3CiYl6Zmn2Oc9iC3DZwE7ITmTlYk3Fcm2Wy+XHyjzL3x/CWDcOQVwDiC5j8vjd7u8O 9N+mQzPIvxQ8sc7HQgvWvGkb13J9iaw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220060 The DP subconnector property only applies to full DisplayPort outputs. This was expressed as "!is_edp", which infers the property's applicability indirectly from the port flavour rather than from the connector it is attached to. Besides eDP, that is also wrong for an HDMI output driven by the DP controller through a DP-to-HDMI bridge: such a sink is not eDP either, so it would be handed a DP subconnector property it should never get. Key the DP subconnector calls off the connector type directly (DRM_MODE_CONNECTOR_DisplayPort) instead. This ties the decision to the object the property lives on and correctly covers both cases, skipping eDP as well as HDMI (via a DP-to-HDMI bridge) outputs. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- drivers/gpu/drm/msm/dp/dp_drm.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 3397a3a47ef3..4f6da636f7c6 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -295,7 +295,7 @@ static int msm_dp_display_process_hpd_high(struct msm_dp_display_private *dp) msm_dp_link_process_request(dp->link); - if (!dp->msm_dp_display.is_edp) + if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) drm_dp_set_subconnector_property(connector, connector_status_connected, dp->panel->dpcd, @@ -477,7 +477,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp) * We don't need separate work for disconnect as * connect/attention interrupts are disabled */ - if (!dp->msm_dp_display.is_edp) + if (dp->msm_dp_display.connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) drm_dp_set_subconnector_property(dp->msm_dp_display.connector, connector_status_disconnected, dp->panel->dpcd, diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 6b55753da0f7..00653b0364dc 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -323,7 +323,7 @@ struct drm_connector *msm_dp_drm_connector_init(struct msm_dp *msm_dp_display, if (IS_ERR(connector)) return connector; - if (!msm_dp_display->is_edp) + if (connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort) drm_connector_attach_dp_subconnector_property(connector); return connector; -- 2.47.3