From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-op-o11.zoho.com (sender4-op-o11.zoho.com [136.143.188.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730D0233D9E; Wed, 22 Jul 2026 23:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784764488; cv=pass; b=oqItn4hygHyK3iGqcf+9CE90VPu7AwkhajCM2PdT9j4fuT8M90dARVOXH0n23r1Ku5gnz83SuwBPeD4mpBP1HaMzOvXHa/hA+6zgNqWbIziXwsyA+0a3hz+wmpfAidVEthl9kaO5tEgTgpjsczIMkGOFkAFjCDwd0a4Tg87ORgQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784764488; c=relaxed/simple; bh=jwslnoja1cbGGRhDvQz6tFJ3uJnsGMI9RWuubiehUwA=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=l/7HPp3Q0wnGM6t2K4nNfOS5boWAVz65Kia2QR9wuaqHG39XzBjvfpJT91aWJjwUn9FBejXlrVv94UE1TYgdixvTy7GiXst4tAkuDWC69N/P6GMi65ZZxbNGx5cFrQ4vKU0lwox0Ko1j+lp2n8DqtNYgJvBXNAjUhH3flvVd7qE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b=PsZ2Qg3Z; arc=pass smtp.client-ip=136.143.188.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=deborah.brouwer@collabora.com header.b="PsZ2Qg3Z" ARC-Seal: i=1; a=rsa-sha256; t=1784764454; cv=none; d=zohomail.com; s=zohoarc; b=cmNhOkLyBkjThtl4YVCY5K34MMeKRG2gB/fbsDyv9AnvDs9k6Z/LQu2x2BB93Trh3APFH8Pjq2oMifirp50kKgZcq8wh2nR1dPSaf4UepBUBip9sEp8F4KH/GeeugXGqfsLA1+G+2XS2/HI9Y6IRr6on0AOVEMeLl2TFufOW6ag= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784764454; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=4iaNdNvCJ5AMkFooQERArqIO2ZuOnRegMHy80ampa24=; b=YPzmQ9nDRfRgL70HF3QsNOStSWX5eYijW+zu86w6p6nmhmREizI0Xs4w8qH/39fXUpvzmshS+IjFvNTrSpJ+6KSq4oUqfhrfXhhd74hOATTj6G9wyc+PRvHTxEuAdZQFyIFwEuuEyyjR3DziNbZRcpTOdOdm/RCT8LFwEhdIA5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=deborah.brouwer@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1784764454; s=zohomail; d=collabora.com; i=deborah.brouwer@collabora.com; h=From:From:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:To:To:Cc:Cc:Reply-To; bh=4iaNdNvCJ5AMkFooQERArqIO2ZuOnRegMHy80ampa24=; b=PsZ2Qg3ZPZ/6ncUG0slH+0Y+rRpVT6s6vRw2a2NpIRk939AwlnFZcNPaaEOTmrnV FVIjBKgCKcnI/D9twBpTo+XjgDEp9lo3gTpcyzPqEJh+cKbJiX05P6imD5GCjT5QCEW 1ULhJYko4PtepvJyN0Nev6cvl+RobDOgOpV8bkIU= Received: by mx.zohomail.com with SMTPS id 1784764452397424.582421711729; Wed, 22 Jul 2026 16:54:12 -0700 (PDT) From: Deborah Brouwer Subject: [PATCH v9 0/7] drm/tyr: firmware loading and MCU boot support Date: Wed, 22 Jul 2026 16:54:06 -0700 Message-Id: <20260722-fw-boot-b4-v9-0-8669d2a02590@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/23OzWoDIRSG4VsJrmtRRz3HrnofpQt/GyGNxQkmJ cy915kWOtMOuDnC8/LdyRhrjiN5OtxJjS2PuZz7YR4OxB/t+S3SHPpNBBOaAUOartSVcqFO0sQ AmLZCKw+kg48aU74tsZfXfh/zeCn1c2k3Pv9+Z6SQC/8pNTk/Rq0KhjPFAE149uV0sq5U++jLO 5lrTf0W/gxpqnMAI6zTGAdl9rhec7PhunNvB8Mjt5Iz3OOw4nzYcJjHp4DBc2lk2B2PKy74hmP nTmACKRVy/2/8NE1f39A7WacBAAA= X-Change-ID: 20260708-fw-boot-b4-f07706a265c7 To: Daniel Almeida , Alice Ryhl , Danilo Krummrich , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , =?utf-8?q?Onur_=C3=96zkan?= Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Deborah Brouwer , samitolvanen@google.com, lyude@redhat.com, boris.brezillon@collabora.com, steven.price@arm.com, alvin.sun@linux.dev, laura.nao@collabora.com, beata.michalska@arm.com X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=7766; i=deborah.brouwer@collabora.com; h=from:subject:message-id; bh=jwslnoja1cbGGRhDvQz6tFJ3uJnsGMI9RWuubiehUwA=; b=owGbwMvMwCVWuULzOU9c7WvG02pJDFmJEcpeC73NHmZMnnXm3RtxlaTaeaLTvyz2Xxf+zct52 /vdWXONOkpZGMS4GGTFFFnO2hv1iFe9N9Kd/78ZZg4rE8gQBi5OAZiIvQEjw/bYs97vC/Yt2PTX etf7v59Vkt7Kmtor2Shv0O5gSNr2r5nhn3n+hasFM6eIRSRLJ0qIrE3e++P079XnTnDZWv/8N3v TDSYA X-Developer-Key: i=deborah.brouwer@collabora.com; a=openpgp; fpr=CD3F328C177AEF322D9FFF8379A829E70C5E7DEB This series adds firmware loading and MCU boot support to the Tyr DRM driver. It includes: - A parser for the Mali CSF firmware binary format - A kernel-managed BO type (KernelBo) for internal driver allocations - GPU virtual memory (VM) integration using drm_gpuvm - An MMU module and a generic slot manager - Loading firmware, VM activation, and MCU boot at probe() It is based on drm-rust-next but also depends on: 1. [PATCH v3] rust: iommu: add device lifetime to IoPageTable https://lore.kernel.org/rust-for-linux/20260703-pgtable_lt_b4-v3-1-e738e1f513a4@collabora.com 2. [PATCH] drm: Remove DRIVER_GEM_GPUVA feature flag https://lore.kernel.org/dri-devel/20260421084701.24227-1-laura.nao@collabora.com/ This patch is in drm-misc-next for v7.3: https://lore.kernel.org/dri-devel/20260702-powerful-successful-raptor-eded34@houat/ A branch with all dependencies is available here: https://gitlab.freedesktop.org/dbrouwer/linux/-/commits/fw-boot-b4 Signed-off-by: Deborah Brouwer --- Changes in v9: - reuse SlotData when reactivating a slot - add fn seat to SlotOperations - don't allocate gpuva for full unmap_range - add small sleeps instead of busy-wait for hw - move sparse address space test to constructor - use infallible pin_init! for registration data - add fw stop() to disable MCU and call it from drop() - check page alignment in parser - validate firmware header and entry bounds - allow firmware sections with no VM mapping footprint - clear stale MCU interrupts before boot - handle various errors and clean up - remove various unreachable code - remove trailing newlines from dev_ prints - Link to v8: https://lore.kernel.org/r/20260721-fw-boot-b4-v8-0-b28f744581c9@collabora.com Changes in v8: - kill the vm if firmware does not initialize properly - write to JOB_IRQ_CLEAR after MCU boots - check that a mapping request does not run past the end of the GEM buffer - check that the SG table gave us enough backing memory for our VA - make the KernelBo gem object field (bo) private and add an accessor - return unused gpuva from remap() - always provide three gpuva to unmap() instead of two - be stricter about interpreting MAIR bits for device and non-cacheable memory - preserve idle slot data in case subsequent activation fails - clear evicted slot after eviction in case a subsequent activation fails - wait for flush and lock commands to complete before proceeding - rewrite SectionFlags with the register macro - use the InaBits conversion provided by the register macro - rename the slot data argument to vm_as_data for clarity - add various checks for size, shifting, truncating, sparse values, overflow etc. - return errors instead of panicking from unwrap() - use dev_* macros for all logging - Link to v7: https://lore.kernel.org/r/20260713-fw-boot-b4-v7-0-afd8dc1494dd@collabora.com Changes in v7: - slot.rs: don't print an error when all slots are busy - change all allow(dead_code) to expect(dead_code) - use LockedSeat type alias in VmAsData - shift the lockaddr_base so it fits properly in LOCKADDR - replace core::fmt with kernel::fmt - make SAFETY comments clearer for map/unmap pages - fix arm 32-bit build failures - release gpuvm_unique lock before calling deferred_cleanup - Link to v6: https://lore.kernel.org/r/20260709-fw-boot-b4-v6-0-ca391e1a4108@collabora.com Changes in v6: - Move gpu_info from drm::Driver::Data to RegistrationData and remove drm::Driver::Data entirely. - Remove the extra drm::Device ARef in TyrPlatformDriverData since drm::Registration already owns an ARef to the drm::Device. - Stop storing platform::Device ARef in firmware since it is unused. - Pass a generic kernel::Device instead of the platform::Device through firmware to Vm and pagetables since this is all that they need. - Link to v5: https://lore.kernel.org/r/20260708-fw-boot-b4-v5-0-7792ab68e359@collabora.com Changes in v5: - Reduce the scope of this series back to just MCU booting. - Drop the CSF global interface, job IRQ, wait, and arch timer patches since they will be sent as subsequent series. - Add lifetimes to resources and store them in TyrRegistrationData. - Link to v4: https://lore.kernel.org/r/20260424-b4-fw-boot-v4-v4-0-a5d91050789d@collabora.com Changes in v4: New commits: - drm/tyr: program CSF global interface - rust: time: add arch_timer_get_rate wrapper - drm/tyr: add CSF firmware interface support - drm/tyr: validate presence of CSF shared section - drm/tyr: wait for global interface readiness - drm/tyr: add Job IRQ handling - drm/tyr: add Wait type for GPU events The existing commits from v3 remain unchanged. - Link to v3: https://lore.kernel.org/r/20260413-b4-fw-boot-v3-v3-0-b422f3c03885@collabora.com Changes in v3: New commits: - drm/tyr: remove unused device from platform data - drm/tyr: use shmem GEM object type in TyrDrmDriver drm/tyr: select required dependencies in Kconfig - Rename commit since the dependencies are not limited to DRM. - Select new RUST_DRM_GEM_SHMEM_HELPER instead of DRM_GEM_SHMEM_HELPER. drm/tyr: set DMA mask using GPU physical address - Use register macro to read pa_bits instead of separate helper function. drm/tyr: add MMU module - Switch MMU code to typed register APIs (TRANSCFG, MEMATTR, STATUS, LOCKADDR, etc.). - Use MmuCommand enum for MMU commands instead of raw constants. - Minor cleanups and renaming (MAX_AS, AS_PRESENT handling). drm/tyr: add GPU virtual memory module - Extract VA/PA bits via typed MMU_FEATURES register. - Update the VM code to match the new GPUVM v6 and shmem GEM v10 APIs. drm/tyr: add a kernel buffer object - Reject zero-sized KernelBo allocations up front. drm/tyr: add firmware loading and MCU boot support - Use typed GPU control registers. - Pass iomem by Arc into Firmware::new() since we store it eventually. - Link to v2: https://lore.kernel.org/rust-for-linux/20260302232500.244489-1-deborah.brouwer@collabora.com/ Changes in v2: - The whole series is rebased on drm-rust-next including v7.0-rc1. - Each patch has its own changelog. Link to v1: https://lore.kernel.org/rust-for-linux/20260212013713.304343-1-deborah.brouwer@collabora.com/ --- Boris Brezillon (3): drm/tyr: add a generic slot manager drm/tyr: add Memory Management Unit (MMU) support drm/tyr: add GPU virtual memory (VM) support Daniel Almeida (1): drm/tyr: add parser for firmware binary Deborah Brouwer (3): drm/tyr: add resources to RegistrationData drm/tyr: add a kernel buffer object drm/tyr: add Microcontroller Unit (MCU) booting drivers/gpu/drm/tyr/Kconfig | 5 + drivers/gpu/drm/tyr/driver.rs | 68 ++- drivers/gpu/drm/tyr/file.rs | 11 +- drivers/gpu/drm/tyr/fw.rs | 321 +++++++++++ drivers/gpu/drm/tyr/fw/parser.rs | 588 +++++++++++++++++++ drivers/gpu/drm/tyr/gem.rs | 134 ++++- drivers/gpu/drm/tyr/mmu.rs | 120 ++++ drivers/gpu/drm/tyr/mmu/address_space.rs | 511 +++++++++++++++++ drivers/gpu/drm/tyr/regs.rs | 135 ++++- drivers/gpu/drm/tyr/slot.rs | 404 +++++++++++++ drivers/gpu/drm/tyr/tyr.rs | 4 + drivers/gpu/drm/tyr/vm.rs | 937 +++++++++++++++++++++++++++++++ 12 files changed, 3203 insertions(+), 35 deletions(-) --- base-commit: 337c44a2f50c9008273a338f518cc552f6b08567 change-id: 20260708-fw-boot-b4-f07706a265c7 Best regards, -- Deborah Brouwer