From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD9CD46AA8C for ; Wed, 22 Jul 2026 23:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762069; cv=none; b=KWEdZFw5QopUg0zRdMECt4XbGi9bM0XPsVC2hmewZiKrybiHeYQ9vIafkIVGMummYE/sCyXe8cevMXRBFtygFKLGKxGFBkE6rab1bsZjLlNe4gVv2DGaTPstRHjOh2kpqeBcV0g0Zi7+VREGb29rIXl8gR3TWGgcgt/LRJ9vLE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762069; c=relaxed/simple; bh=zZzVrLnqgX5NCe2uXFsKt1T0XrTCHMmVN/7IIfMKdPo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MwPN+SgMVbHw3pivlW3yBul/1JJ/vyubM0EqhO3ilJEUz7pgcCK/GLZTSPRKCKiI0W9Pula4SGAssiCe7xxcch1kyP5oM+sGcFTkloieVzI7kn8KFKXXuMARErEFYFp20ezVHFnkAD5gENI1LCJ7sfap3eTPksMGcG0lEYEvcy4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GC8NWR4y; arc=none smtp.client-ip=209.85.210.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GC8NWR4y" Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso7489591b3a.1 for ; Wed, 22 Jul 2026 16:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784762067; x=1785366867; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lGDAjh7yFH3A4fNogRP5xVRIbvOG+E+4bwq+sQxTTxs=; b=GC8NWR4ycFpgpS9b0eo3Aw67k0+pNnJ8jKzVFjpWXiM+VhkCKXdtnXyiA+Ui07suAe eXqvg5efpYAy1xnfa9iTjBZbdLkmeSLXSBVkaBiWi1bIroN4xKWsz9P/7LFN94n6kIRR UfIBMseC6qf6nYb6LdErfFJtmsoOO1+m5xEmXerbc6IZhMMkXC/C+BUkhYXPsdc7zxNh Rdo6IKVR2w1N1sX3jMNR+gEiz8uR+l9zFzGTerawIDxiTo5/oN3IlPaEIMjWAFVLQlYk resO/8+0KsXPe4OHIdZZQCFtmOPzywShchFdhuKWUqQfNXh57co5TF7LS1kkRItKfWyO eBNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784762067; x=1785366867; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lGDAjh7yFH3A4fNogRP5xVRIbvOG+E+4bwq+sQxTTxs=; b=nBJ1lsPXSff/Q6QuBNvAIYWWNUUSe/vM0z9/ZTd6KjE3VElLjyBBU+KvM0lbvl9OBI r56Wy/IkY9gMSgSsrInUKf+22o70Qm8fiu2zyMp+Zlyg8VgLZM9E4xexluLi8oxo7SlN VQxuQAuGGiFOCG2GnDFq2LlL++CBGtrbv0UIeRKD3c34EKC95R9+jVCvZr2ULWA23ucr ZoVnvtRfu2m6lhzmLBbmo21wl7pZAkPeYDuYSlqVizZPi76k39jXaLLd3IKrbkFE+dtG 3GHfFHmB+9NnN3Yxaxmws3I9j9ZozmtOcLAyMwcroeqOcI0QgM/kefXrYzuOhgdDHtX7 xgIw== X-Forwarded-Encrypted: i=1; AHgh+Rrr/IZEPZygv2nCO80JjPvGAqjEVVL6vSw1oWCVE03fps2sW6ZuojwqZL8fw0cEA+6UmE98spm4dR3XG2w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjy2dXYwmYkipcaqa4eb0hMlZ7CabaCrpxgf6tfJ2DmNvw/bVJ QKMazpfMfiTIMBD9WNitBazPkK2Gl1a5sbTL+ufwount+zxows00bZx59ObUvfyoqDa0Lr1Si/i D5XmKqg== X-Received: from pgcv17.prod.google.com ([2002:a05:6a02:5311:b0:c93:59ff:8d6d]) (user=wyihan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:4a97:b0:3a2:c9a1:2c26 with SMTP id adf61e73a8af0-3c44c95c87bmr312696637.7.1784762066939; Wed, 22 Jul 2026 16:14:26 -0700 (PDT) Date: Wed, 22 Jul 2026 23:13:16 +0000 In-Reply-To: <20260722-tdx-selftests-v14-0-15ad654a50db@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260722-tdx-selftests-v14-0-15ad654a50db@google.com> X-Developer-Key: i=wyihan@google.com; a=ed25519; pk=cRi0fKzS5BMxlHyHY2pJv3w/1zcgfYKr6EYGYppdMYc= X-Developer-Signature: v=1; a=ed25519-sha256; t=1784762054; l=4491; i=wyihan@google.com; s=20260319; h=from:subject:message-id; bh=P3owxtLsKMvv9okvSM89mKMQ3BM4k0MGM2Mh0dCe1uA=; b=62zD9UnHJb4hBmlcuiUbSAkoiFlVPJ3RSH5zmYrf06sE+0OJIjaJyfs2g2w8mdcK2zLz//sYZ 22kl9844njFBc+NDTJGIfUGPRgvH/RX3v53+wzJP4N/ROQjc6Ddq2rK X-Mailer: b4 0.14.3 Message-ID: <20260722-tdx-selftests-v14-11-15ad654a50db@google.com> Subject: [PATCH v14 11/22] KVM: selftests: Set up TDX boot parameters region From: Lisa Wang To: Andrew Jones , Ackerley Tng , Binbin Wu , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Xiaoyao Li , Oliver Upton Cc: Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, Lisa Wang Content-Type: text/plain; charset="utf-8" From: Sagi Shahar Allocate memory for TDX boot parameters and define the utility functions necessary to fill this memory with the boot parameters. Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Signed-off-by: Sagi Shahar Signed-off-by: Lisa Wang --- .../selftests/kvm/include/x86/tdx/tdx_util.h | 2 + tools/testing/selftests/kvm/lib/x86/processor.c | 2 + tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c | 51 ++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h index 642ffa010da3..f5003cbaa106 100644 --- a/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx_util.h @@ -46,5 +46,7 @@ static inline bool is_tdx_vm(struct kvm_vm *vm) void tdx_init_vm(struct kvm_vm *vm, u64 attributes); void tdx_vm_setup_boot_code_region(struct kvm_vm *vm); +void tdx_vm_setup_boot_parameters_region(struct kvm_vm *vm, u32 nr_runnable_vcpus); +void tdx_vm_load_common_boot_parameters(struct kvm_vm *vm); #endif /* SELFTESTS_TDX_TDX_UTIL_H */ diff --git a/tools/testing/selftests/kvm/lib/x86/processor.c b/tools/testing/selftests/kvm/lib/x86/processor.c index f93953777ca1..748c6041f8bf 100644 --- a/tools/testing/selftests/kvm/lib/x86/processor.c +++ b/tools/testing/selftests/kvm/lib/x86/processor.c @@ -794,6 +794,8 @@ void kvm_arch_vm_post_create(struct kvm_vm *vm, unsigned int nr_vcpus) if (is_tdx_vm(vm)) { tdx_init_vm(vm, 0); tdx_vm_setup_boot_code_region(vm); + tdx_vm_setup_boot_parameters_region(vm, nr_vcpus); + tdx_vm_load_common_boot_parameters(vm); } r = __vm_ioctl(vm, KVM_GET_TSC_KHZ, NULL); diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c index d64d153d19e2..2ce8c297f7ed 100644 --- a/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c +++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx_util.c @@ -6,6 +6,7 @@ /* Arbitrarily selected to avoid overlaps with anything else */ #define TD_BOOT_CODE_SLOT 20 +#define TD_BOOT_PARAMETERS_SLOT 21 #define X86_RESET_VECTOR 0xfffffff0ul #define X86_RESET_VECTOR_SIZE 16 @@ -49,6 +50,56 @@ void tdx_vm_setup_boot_code_region(struct kvm_vm *vm) hva[2] = 0xcc; } +void tdx_vm_setup_boot_parameters_region(struct kvm_vm *vm, u32 nr_runnable_vcpus) +{ + size_t boot_params_size = + sizeof(struct td_boot_parameters) + + nr_runnable_vcpus * sizeof(struct td_per_vcpu_parameters); + int npages = DIV_ROUND_UP(boot_params_size, PAGE_SIZE); + const u64 gmem_flags = 0; + gpa_t gpa; + + vm_mem_add(vm, VM_MEM_SRC_SHMEM, TD_BOOT_PARAMETERS_GPA, + TD_BOOT_PARAMETERS_SLOT, npages, + KVM_MEM_GUEST_MEMFD, -1, 0, gmem_flags); + gpa = vm_phy_pages_alloc(vm, npages, TD_BOOT_PARAMETERS_GPA, TD_BOOT_PARAMETERS_SLOT); + TEST_ASSERT(gpa == TD_BOOT_PARAMETERS_GPA, "Failed vm_phy_pages_alloc\n"); + + virt_map(vm, TD_BOOT_PARAMETERS_GPA, TD_BOOT_PARAMETERS_GPA, npages); +} + +void tdx_vm_load_common_boot_parameters(struct kvm_vm *vm) +{ + struct td_boot_parameters *params = + addr_gpa2hva(vm, TD_BOOT_PARAMETERS_GPA); + u32 cr4; + + cr4 = kvm_get_default_cr4(vm->mmu.pgtable_levels); + + /* TDX spec 11.6.2: CR4 bit MCE is fixed to 1 */ + cr4 |= X86_CR4_MCE; + + /* TDX spec 11.6.2: CR4 bit VMXE and SMXE are fixed to 0 */ + cr4 &= ~(X86_CR4_VMXE | X86_CR4_SMXE); + + /* Set parameters! */ + params->cr0 = kvm_get_default_cr0(); + TEST_ASSERT(vm->mmu.pgd < (1ULL << 32), + "PGD must be within 32-bit address space for 32-bit boot code"); + params->cr3 = vm->mmu.pgd; + params->cr4 = cr4; + params->idtr.base = vm->arch.idt; + params->idtr.limit = kvm_get_default_idt_limit(); + params->gdtr.base = vm->arch.gdt; + params->gdtr.limit = kvm_get_default_gdt_limit(); + + TEST_ASSERT(params->cr0 != 0, "cr0 should not be 0"); + TEST_ASSERT(params->cr3 != 0, "cr3 should not be 0"); + TEST_ASSERT(params->cr4 != 0, "cr4 should not be 0"); + TEST_ASSERT(params->gdtr.base != 0, "gdt base address should not be 0"); + TEST_ASSERT(params->idtr.base != 0, "idt base address should not be 0"); +} + static struct kvm_tdx_capabilities *tdx_read_capabilities(struct kvm_vm *vm) { static struct kvm_tdx_capabilities *tdx_cap; -- 2.55.0.229.g6434b31f56-goog