From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8510147124C for ; Wed, 22 Jul 2026 23:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762080; cv=none; b=GbXQ9OMl3lGUfrnNL9n2AqsNji+dee8fQXPHMz6qayEUnvPf53fJ6kpAgO0eTaBJTlEGgulMNDh5qzT78DPlkwOIuRXpB/TNWOX4P/ZJdNEOamOWBqHSwhtLOAwg7ro6w0yAaOCndAWdjZCaNdZ3bQ0xwVzEt8GtltRt2or/DOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762080; c=relaxed/simple; bh=J2jP33MsvXzcPyd71zMa34BP+SHntkFHO92tJSH/otQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TzikJ29ZJ10mIa0pH0hxCdK0Ylv0H0lVRYk5Wp5HI/PMs8iUvL3mpYW3ih3lM28u1LiSz9lAeuEQGBNlGnMq3hN5NVfZEYAU/CgvkXVQxu5TsN9vw3HnNbIrDrAk5W/SwdfpGNlp0E+vYS9QiwD8p20fLa/xb9MsZqf7331ytSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=foecDQCp; arc=none smtp.client-ip=209.85.214.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wyihan.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="foecDQCp" Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2cceabd70f5so1426875ad.1 for ; Wed, 22 Jul 2026 16:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784762078; x=1785366878; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OE9BObxgnpVBtB0susWSfoNAQmdWjz8VkVFbMsNsCVk=; b=foecDQCpaALgNr1xMmroZEUQ6VJH5GJFriLyTDXMHEI6REry4HNYgTYQdn3fRW+Gvi IGQ1Q99am0//xJVarzpihKuWw1IDMwhRllTtifL60FWKd9eBxydyoyl3L7OvWpZ28ouA /S3MAGUx0jp80A46JUhOXKvJzfnn+kcGDWsLgeF1ykxhhHB2ITAQfzo0A7fCZGxivUio +pPe6E0hE+9Ai5NV0gY1LpVcP51N8dw+bFQ8bkyF6MNkvKehpcevoCPSfT85gVQlJUJe XwViD+AvMmLSFm6edvBrlpp2amdWZMdrgjhmXNwPYSIhtGhMtIBRaN3FiVKh6e5o2aa6 hP+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784762078; x=1785366878; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OE9BObxgnpVBtB0susWSfoNAQmdWjz8VkVFbMsNsCVk=; b=BAAQEf87neE0YBuoxGQHHOb0RkFsQ7uPFRH/rFNvvJBcoS/UK0XBjZCYFpjIBToOTt vABnfgYsGVZIkc16HzbhCm7md30/zLkT+UB53ZGKjkimj/RjsYiSyzl4xE898FmUV6c5 McHjSSntIhj4pnSI3nMGuohIGCZbUZI2xfUH3soT2KbnvVpvBF6ursi2AwjM2vPhdbqc 8tQS2SdMsy+m2wsSML0LTk8RzMokTSWLXkJ03dDdWFziA8p9JJhke023UJ2uD60+368E zVY4Wva1CfEzGYHfKM4DU09qOQxsIRuEe5ZtJcphc2hWy3ZOB/V+GyfKiXs/xUMGC2hb V/KQ== X-Forwarded-Encrypted: i=1; AHgh+RqqlRe5RMiEJwkiJ6qRd4Cwcj+LMbtJXbGBNuE6a2ROrzzpQubZtvPm6OV+VXDIPbCG48KyOZXASeNEUzs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv+EqKucaQ3O9xd9Lj5qfzoM4S9loFTxOIIWl5Phz782XBQ1nK BXHuM1THrUQBnadZmdKUYxhZA/1bAT5/En/vSrexryM6pR0qwOKOBHT8twsH4MbGRvMfJtCBKgX JUTNlQA== X-Received: from pggh14.prod.google.com ([2002:a63:c00e:0:b0:c9e:142c:425e]) (user=wyihan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:748a:b0:3c3:bb13:438 with SMTP id adf61e73a8af0-3c44b0504bcmr554799637.32.1784762077746; Wed, 22 Jul 2026 16:14:37 -0700 (PDT) Date: Wed, 22 Jul 2026 23:13:25 +0000 In-Reply-To: <20260722-tdx-selftests-v14-0-15ad654a50db@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260722-tdx-selftests-v14-0-15ad654a50db@google.com> X-Developer-Key: i=wyihan@google.com; a=ed25519; pk=cRi0fKzS5BMxlHyHY2pJv3w/1zcgfYKr6EYGYppdMYc= X-Developer-Signature: v=1; a=ed25519-sha256; t=1784762054; l=3161; i=wyihan@google.com; s=20260319; h=from:subject:message-id; bh=LhPITB0/P3+C8fkpUXhj3CMOp+sdIRyRL+NpJnysUVU=; b=KwG/mq0dqAwUImRbDSEcbPFdl15WaqHL4VOTMgbqjf6a4Ej+o01Emqg1/da9WwWbbYyH6qqAZ KDHbmghfo96Bij8EdsXBK7NyAbD5HONradFoDKSUxowWKqebJozW8wK X-Mailer: b4 0.14.3 Message-ID: <20260722-tdx-selftests-v14-20-15ad654a50db@google.com> Subject: [PATCH v14 20/22] KVM: selftests: Implement MMIO WRITE for the TDX VM From: Lisa Wang To: Andrew Jones , Ackerley Tng , Binbin Wu , Chao Gao , Chenyi Qiang , Dave Hansen , Erdem Aktas , Ira Weiny , Isaku Yamahata , Kiryl Shutsemau , linux-kselftest@vger.kernel.org, Paolo Bonzini , "Pratik R. Sampat" , Reinette Chatre , Rick Edgecombe , Roger Wang , Ryan Afranji , Sagi Shahar , Sean Christopherson , Shuah Khan , Xiaoyao Li , Oliver Upton Cc: Jeremiah McReynolds , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, x86@kernel.org, Lisa Wang Content-Type: text/plain; charset="utf-8" From: Erdem Aktas Implement the tdx_mmio_write() to allow TDX VMs to request MMIO emulation. Follow the Intel Guest-Hypervisor Communication Interface (GHCI) spec to the minimum extent that a spec-abiding TDX module will pass the request to KVM. Skip implementing the #VE handler as described in the GHCI spec to reduce selftests dependency. To perform emulated I/O, VMs use the TDG.VP.VMCALL instruction to request MMIO. Signed-off-by: Erdem Aktas Co-developed-by: Sagi Shahar Signed-off-by: Sagi Shahar Co-developed-by: Lisa Wang Signed-off-by: Lisa Wang --- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/include/x86/tdx/tdx.h | 17 +++++++++++ tools/testing/selftests/kvm/lib/x86/tdx/tdx.S | 37 +++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 645d9aac61db..28b33ed8c2e6 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -33,6 +33,7 @@ LIBKVM_x86 += lib/x86/tdx/tdx_util.c LIBKVM_x86 += lib/x86/ucall.c LIBKVM_x86 += lib/x86/vmx.c LIBKVM_x86 += lib/x86/tdx/td_boot.S +LIBKVM_x86 += lib/x86/tdx/tdx.S LIBKVM_arm64 += lib/arm64/gic.c LIBKVM_arm64 += lib/arm64/gic_v3.c diff --git a/tools/testing/selftests/kvm/include/x86/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h new file mode 100644 index 000000000000..6355a30bb47f --- /dev/null +++ b/tools/testing/selftests/kvm/include/x86/tdx/tdx.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef SELFTEST_KVM_TDX_TDX_H +#define SELFTEST_KVM_TDX_TDX_H + +#include + +#define TDG_VP_VMCALL_VE_REQUEST_MMIO 48 +#define TDVMCALL_MMIO_WRITE 1 + +u64 __tdcall(u64 leaf, u64 r12, u64 r13, u64 r14, u64 r15); + +static inline u64 tdx_mmio_write(u64 address, u32 size, u64 data_in) +{ + return __tdcall(TDG_VP_VMCALL_VE_REQUEST_MMIO, size, + TDVMCALL_MMIO_WRITE, address, data_in); +} +#endif /* SELFTEST_KVM_TDX_TDX_H */ diff --git a/tools/testing/selftests/kvm/lib/x86/tdx/tdx.S b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.S new file mode 100644 index 000000000000..dff48a3624a1 --- /dev/null +++ b/tools/testing/selftests/kvm/lib/x86/tdx/tdx.S @@ -0,0 +1,37 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +.globl __tdcall +/* + * u64 __tdcall(u64 leaf, u64 r12, u64 r13, u64 r14, u64 r15) + */ +__tdcall: + push %r12 + push %r13 + push %r14 + push %r15 + + /* Map C ABI fast arguments to TDX GHCI payload registers */ + /* RDI=leaf, RSI=r12, RDX=r13, RCX=r14, R8=r15 */ + + mov %rdi, %r11 + mov %rsi, %r12 + mov %rdx, %r13 + mov %rcx, %r14 + mov %r8, %r15 + + /* TDCALL boilerplate */ + mov $0, %rax + mov $0xFC00, %rcx /* Expose R10-R15 */ + mov $0, %r10 + + /* tdcall instruction */ + .byte 0x66, 0x0f, 0x01, 0xcc + + /* Extract status */ + mov %r10, %rax + + pop %r15 + pop %r14 + pop %r13 + pop %r12 + ret -- 2.55.0.229.g6434b31f56-goog