mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: Michal Simek <michal.simek@amd.com>,
	Prasanna Kumar T S M <ptsm@linux.microsoft.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
	Jay Buddhabhatti <jay.buddhabhatti@amd.com>,
	Pan Chuang <panchuang@vivo.com>,
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/ZYNQ
	ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2] soc: xilinx: Remove redundant dev_err()
Date: Wed, 22 Jul 2026 10:35:23 +0800	[thread overview]
Message-ID: <20260722023523.42269-7-panchuang@vivo.com> (raw)
In-Reply-To: <20260722023523.42269-1-panchuang@vivo.com>

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Acked-by: Michal Simek <michal.simek@amd.com>
---
 drivers/soc/xilinx/zynqmp_power.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index 370e61ac47d8..54c796afb89e 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -368,11 +368,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
 						IRQF_NO_SUSPEND | IRQF_ONESHOT,
 						dev_name(&pdev->dev),
 						&pdev->dev);
-		if (ret) {
-			dev_err(&pdev->dev, "devm_request_threaded_irq '%d' failed with %d\n",
-				irq, ret);
+		if (ret)
 			return ret;
-		}
 	} else {
 		dev_err(&pdev->dev, "Required property not found in DT node\n");
 		return -ENOENT;
-- 
2.34.1


  parent reply	other threads:[~2026-07-22  2:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  2:35 [PATCH v2] soc: fsl: dpio: " Pan Chuang
2026-07-22  2:35 ` [PATCH v2] soc: ixp4xx: " Pan Chuang
2026-07-24  7:57   ` Linus Walleij
2026-07-22  2:35 ` [PATCH v2] soc: mediatek: mtk-svs: Remove redundant dev_err_probe() Pan Chuang
2026-07-22  2:35 ` [PATCH v2] soc: qcom: Remove redundant dev_err() Pan Chuang
2026-07-22  2:35 ` [PATCH v2] soc/tegra: cbb: " Pan Chuang
2026-07-22  2:35 ` [PATCH v2] soc: ti: wkup_m3_ipc: " Pan Chuang
2026-07-22 13:10   ` Nishanth Menon
2026-07-23  2:34     ` Pan Chuang
2026-07-22  2:35 ` Pan Chuang [this message]
2026-07-22 13:14   ` [PATCH v2] soc: xilinx: " Michal Simek
2026-07-23  2:09     ` Pan Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722023523.42269-7-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=jay.buddhabhatti@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=michal.simek@amd.com \
    --cc=ptsm@linux.microsoft.com \
    --cc=radhey.shyam.pandey@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®