From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB904360EEE for ; Thu, 23 Jul 2026 10:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801444; cv=none; b=XhqKyLSOOJveR67mi0pu5+21ylQATSBtpPSQkRyELmhXGyQkKK+gjjPUfsHEpEMVOpVEKHJJ9+roCbv8U8K7akRoHasix5TIcEVneGebttl+GzjcTJkrB+6UpgHFCtadx8oU8jHgEC94TrVxgjjwkXZamXPRjZovavtqyXLNZKI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784801444; c=relaxed/simple; bh=Lrccgm+Sai81MWikEO1xuuoxujw1PcDuqCFTEx8Kci8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=CDSu/iK8I+XESxTnayKmBrfFbx3qGg9Gvc1193Rr4RihzEnI+jgQH+1H3B7q575dXKClvw27wy6VZjq5xWqFqZyNpD1Tq4sNkGHwSwaKitnp7cbNGewE2e+hmG1+46/22z/7duCXid9l9b2//Fd76ZYu/LNtxPsb0Ty1o1+AnSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kk+fsh6K; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kk+fsh6K" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so482716f8f.1 for ; Thu, 23 Jul 2026 03:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784801441; x=1785406241; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RAjHZU7KutdIcENZyCMKTZmcMUSGgjomFPIzWQXU0T4=; b=Kk+fsh6KySduIQ3sorvSMYiWgeByYm63fylI43IwtVOY3b8g+sW97HkVhNLspS2PTu igpXQ1kXKJVbL/L4GZPe2WhZKUt25A6TtpZAVEgcdNt4sdNsUXuP40WGTixLDyKY1lF6 PjpTwCUUatvck0LR0J6iJJZm9jyO6F9bMZ7BJ8Zo84xeqLPY9pTt4aAraatW5x9PiBJA ehT6ptromI8tCuy6VlRg3QmM42IoFd19TW0o0eh2vA6ECwK2+EN/4kje+rHpkvk47MZL oJTM5SrXyoJqaeO8sKreA1z6LcNYljCiTVtL6igwQ/Eicx4C/CxKYTeZd77I+hB/XHWI LH1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784801441; x=1785406241; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RAjHZU7KutdIcENZyCMKTZmcMUSGgjomFPIzWQXU0T4=; b=T6kPy+x3WhVBuFHJzuAUZvI6FxYZlb23AfIu5yBOWXD7vHRvB51MpM3Eb5G0cph18v 9ya9VDS/cuaL+kmn9VyDfMWTp3fHHK4IN02hJFRdbAJIZZnPsWXaj1bf95Yi67QOYQ0L S4+CLCZ+gxBSUjES9TwbFgTlihUsH5Ayo6ROPJNvBb39FwCBpN/9NkNlop7C+WoGiCZu QtB8u1RqF//uyvjgDLO1lxcmCfMShoxaNB4HjtLsq7sOylJuaiwrDxw4bvH/94vMvQih uTHOeLlpTTUV229nJjCTeX3OWBzbvr87JuWqWoTVdfGPcVbYSrNkPE4M3nDklIywKawh 52tg== X-Forwarded-Encrypted: i=1; AHgh+Rrxy/P4tfi/il8wgAr7q2lzDvVDnVl8p5aiN1GI0Rw1TEktpefrYI5/718K4j9lgrT8B7w46ftLcqCEBpc=@vger.kernel.org X-Gm-Message-State: AOJu0YxM7jjfjcrw7SsTT1CCvygwywj1rHy0nolPgxWt+M38aAvwv3bQ sDC/4sTt8uROqziN1LKmeyGVhpB0ExkJEe1RqjqNMu64ecvG4tTX1cp+ X-Gm-Gg: AR+sD13ImzoFtxiLpH57seSQKrckpheRW/3ePLUuOTi7TEuinD+CvRYrSUAFTJ8Fv05 NgkCpv2tJcWuv+2m6cDPg+e1zC+6vjN24UbeQSCuyHuTfZw/4l5O9TzDiuCntb3+TPxdm4AW4Q3 kteRF9WFGyTsx1liQbP6dn20uNHQAajrBVIULbtnDsZZB0rrJlQHT+p8yn8QGAfTAM4rb64Y0F8 HIqPOHH7wy5aZt4R8jgEc3NkF+yqUEQb23uHWbMy2aTlhXe+v5TqE9vT5yHH3Vh5XhQCTOSwrNM SLtFDAHeVAUpMjNx1uHa9YwVo9Z1HPphl7fGIzOrQ8OoAhxeWWO2sPp/bT115XnHTNVIQDvevPR edqrr8py40EvEb/JGvfLP2qLcS1FvQe55HTlSc9Pi2qORb2M0KrBm1GTNA/zOR8653XPsufdOiA == X-Received: by 2002:a05:6000:18a2:b0:47f:7531:3e6d with SMTP id ffacd0b85a97d-47f8dc8cc77mr2890129f8f.38.1784801440784; Thu, 23 Jul 2026 03:10:40 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85bc62basm14104470f8f.13.2026.07.23.03.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 03:10:40 -0700 (PDT) Date: Thu, 23 Jul 2026 11:34:00 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Harry Wentland Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Alex Deucher , Alex Hung Subject: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3415 dm_suspend() warn: inconsistent returns '&dm->dc_lock'. Message-ID: <202607220433.GXC845n9-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: b95f03f04d475aa6719d15a636ddf32222d55657 commit: af3f2f5db2659a13c256d2fb096c473eb50412ef drm/amdgpu: Remove UML build exclusion from Kconfig config: um-randconfig-r071-20260721 (https://download.01.org/0day-ci/archive/20260722/202607220433.GXC845n9-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: af3f2f5db265 ("drm/amdgpu: Remove UML build exclusion from Kconfig") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202607220433.GXC845n9-lkp@intel.com/ New smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3415 dm_suspend() warn: inconsistent returns '&dm->dc_lock'. vim +3415 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c 982d7f9bfe4a503 Sunil Khatri 2024-09-30 3359 static int dm_suspend(struct amdgpu_ip_block *ip_block) 4562236b3bc0a28 Harry Wentland 2017-09-12 3360 { 982d7f9bfe4a503 Sunil Khatri 2024-09-30 3361 struct amdgpu_device *adev = ip_block->adev; 4562236b3bc0a28 Harry Wentland 2017-09-12 3362 struct amdgpu_display_manager *dm = &adev->dm; 4562236b3bc0a28 Harry Wentland 2017-09-12 3363 53b3f8f40e6cff3 Dennis Li 2020-08-19 3364 if (amdgpu_in_reset(adev)) { 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3365 enum dc_status res; 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3366 cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3367 mutex_lock(&dm->dc_lock); I guess this lock was supposed to be deleted when we converted to scoped locks? Bad merge??? 98ab5f3513f90f1 Bhawanpreet Lakha 2021-01-11 3368 754003486c3cc95 Ray Wu 2025-12-17 3369 amdgpu_dm_ism_disable(dm); 98ab5f3513f90f1 Bhawanpreet Lakha 2021-01-11 3370 dc_allow_idle_optimizations(adev->dm.dc, false); 98ab5f3513f90f1 Bhawanpreet Lakha 2021-01-11 3371 09a4ec5da92c849 Dillon Varone 2023-11-17 3372 dm->cached_dc_state = dc_state_create_copy(dm->dc->current_state); cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3373 8092aa3ab8f7b73 Alex Hung 2024-06-04 3374 if (dm->cached_dc_state) cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3375 dm_gpureset_toggle_interrupts(adev, dm->cached_dc_state, false); cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3376 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3377 res = amdgpu_dm_commit_zero_streams(dm->dc); 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3378 if (res != DC_OK) { 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3379 drm_err(adev_to_drm(adev), "Failed to commit zero streams: %d\n", res); 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3380 return -EINVAL; mutex_unlock(&dm->dc_lock); before returning. 3cf7a0bc87f028b Mario Limonciello 2025-02-17 3381 } cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3382 cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3383 amdgpu_dm_irq_suspend(adev); cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3384 8e794421bc98158 Wayne Lin 2021-07-23 3385 hpd_rx_irq_work_suspend(dm); 8e794421bc98158 Wayne Lin 2021-07-23 3386 65890cad2edb53b Mario Limonciello 2025-02-17 3387 return 0; cdaae8371aa9d4e Bhawanpreet Lakha 2020-05-11 3388 } 4562236b3bc0a28 Harry Wentland 2017-09-12 3389 50e0bae34fa6b8b Mario Limonciello 2025-02-13 3390 if (!adev->dm.cached_state) { 709a37ab9c63297 Mario Limonciello 2025-06-01 3391 int r = dm_cache_state(adev); 709a37ab9c63297 Mario Limonciello 2025-06-01 3392 709a37ab9c63297 Mario Limonciello 2025-06-01 3393 if (r) 709a37ab9c63297 Mario Limonciello 2025-06-01 3394 return r; 50e0bae34fa6b8b Mario Limonciello 2025-02-13 3395 } d2f0b53bda31938 Leo (Hanghong Ma 2019-01-24 3396) 7594874227e1b04 Kun Liu 2025-01-08 3397 s3_handle_hdmi_cec(adev_to_drm(adev), true); 7594874227e1b04 Kun Liu 2025-01-08 3398 4a580877bdcb837 Luben Tuikov 2020-08-24 3399 s3_handle_mst(adev_to_drm(adev), true); 4562236b3bc0a28 Harry Wentland 2017-09-12 3400 4562236b3bc0a28 Harry Wentland 2017-09-12 3401 amdgpu_dm_irq_suspend(adev); 4562236b3bc0a28 Harry Wentland 2017-09-12 3402 754003486c3cc95 Ray Wu 2025-12-17 3403 scoped_guard(mutex, &dm->dc_lock) 754003486c3cc95 Ray Wu 2025-12-17 3404 amdgpu_dm_ism_disable(dm); double lock. What? 754003486c3cc95 Ray Wu 2025-12-17 3405 8e794421bc98158 Wayne Lin 2021-07-23 3406 hpd_rx_irq_work_suspend(dm); 8e794421bc98158 Wayne Lin 2021-07-23 3407 32f5062d1c7dc2a Tom St Denis 2017-10-17 3408 dc_set_power_state(dm->dc, DC_ACPI_CM_POWER_STATE_D3); 2fe79508d9c393b Hamza Mahfooz 2024-10-04 3409 2fe79508d9c393b Hamza Mahfooz 2024-10-04 3410 if (dm->dc->caps.ips_support && adev->in_s0ix) 2fe79508d9c393b Hamza Mahfooz 2024-10-04 3411 dc_allow_idle_optimizations(dm->dc, true); 2fe79508d9c393b Hamza Mahfooz 2024-10-04 3412 0f657938e4345a7 Samson Tam 2023-11-28 3413 dc_dmub_srv_set_power_state(dm->dc->ctx->dmub_srv, DC_ACPI_CM_POWER_STATE_D3); 4562236b3bc0a28 Harry Wentland 2017-09-12 3414 1c2075d401f06a2 Jason Yan 2020-05-04 @3415 return 0; 4562236b3bc0a28 Harry Wentland 2017-09-12 3416 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki