From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7EF473C98 for ; Wed, 22 Jul 2026 07:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784706949; cv=none; b=nZJdRn64TIjKwS/rLGCyiG1DJrMutFqV6UVKmxBBYZJRhMc6zxoXUnpmA027nr6Z+1MIGMLpnOMjZ2SbiEYSK9VIDNnEtP7zbXalA+KgWDWdycuzqVBcUlsmyGuNPPNsnldZQE8lJv4zTsJLVxxMwm3PBQyUX6aEqdYh6/73O8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784706949; c=relaxed/simple; bh=7iZEz40xLl00lm91VqgOG7NR1gf8pYZxrp3nTa6KfZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sLKQIb42DmZ81DCi+NmvIlWuq48y9TTOaVJrww2UKoUDp1cZe1gm3qYiqnd0/eEjn1RaLIf0f/q0u489oxaeSl+fBJceHGkwJx15hfDe+SFsLMtnId+YYBC0nq4b1T02gSPnM1NGDoKBDulzoxDBmjqaqdlcRJvJm4sCcNZ1Uq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZwvOMFDl; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZwvOMFDl" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-47f706438c3so193006f8f.3 for ; Wed, 22 Jul 2026 00:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784706946; x=1785311746; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ylc8TXlNP8HCp9xOR7j/KXR/abtqHgmLUYlJxvcNlVU=; b=ZwvOMFDl/1E3Iw3pBlJrYqhFqGqcOWSz6C3GgMmpuFj9aqVtxXxaY6nilMGXNvNOWB hXqchaug8ol8cJkuSlPV+rZCA4ugHesmgwM+El6a7MjE/rvSuybRfv7VZ7tK3wX4eQLe sSFBHBanVsVF4H/vEZ1W5navaSgvxaoa3tG9iZl8JemfRroUagBgVp/EYmdH8pbUBnhC DIlpkjDEcpV9vY8nIaVe+zlfU9KzfvaKAwv4FHTST1Qg4tMI0t8hVuayo+fq9zxOgZK0 EfwA05FlF0QAqsBwB4vxRWWNJs9ZTefniwlmwU9Gd1f5cIyKnq1Hf+fGnLypaKPckOAy WDnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784706946; x=1785311746; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ylc8TXlNP8HCp9xOR7j/KXR/abtqHgmLUYlJxvcNlVU=; b=Tv1XpIXjSkeGBgzjtUngO6fLjLEPtJhKFaRU/eME59SlWToFvUaGXJABVRRRJDtty1 vuXNLK9Z6S1bD3sVLNsqr5bp1InyTbxOqrjeOxdgpUrXWtJ8LBxYq0agKcNqhEdElola aa1Zieq0Zq+G9pLgrTNql+Q7gLzGrpbClkdrrqgoI8x0cvGdh0xVserjZ2h6JY62QYRB J2SCh8bJhCsyN7ErPUkFhqhmBFVV+7WJP/j0DLKkq8Pz4P1ZTPE0ylt86kfRm6NLonyA /z9uNpgjaCWhErUj5BoHt514miaOEOnpY/wmD/v7hBvSB8q3wgOMreuGwuq9842w1r0w hMiA== X-Forwarded-Encrypted: i=1; AHgh+RqAzYWi/pcdupV9EbjHUa4LWMpp62gOYvm2A9TOh1qjY5HWroItAuwF4IM/EoFQBAo0sPCHduMhN9rH2FE=@vger.kernel.org X-Gm-Message-State: AOJu0YzylP3iy6SzJ0epH4GGAwpsf2PMqtMXQgnA2S9EHiP0ZhC0StvB PbNSNm1xR5UNS20epp9R7IDfBzyscTLRzs3hY26og4WhkGckXlm/vCaS X-Gm-Gg: AR+sD13uCCuP5qknnSXmmaFjwhvxTONnrrHEZC0CHm9QIYXzpeAPdf8TMXJfjGIkBUq u6oNNhXcHRvA3UtE5iGyA/T8NuEVA8ckiSXmoEmXcovrgdiNenpW2eRZ8zNgVoS2kdwnymr+6O5 YV1JYHfZlqBfYBYrqViKemm7+OX4b6aUqHLjvX9h67lWdJv4rs9n6+o2uUdndvt7+6v46LLoXhM tM2zZ5OBftcGVvJBTzJzuWDe18fsmg/Xx9VfY77WvH+R+5KbltaHbWHFvuZ+yedb0I+8h/ff2KL Wamsv58LV4tzyAd4yiPFM2BXKj39hfbFSPCKjZW/YSJrE65kRVXdzYLQmSmvz/41Hht7AxpNT2b pzpYa/iA8PPpWXTO3uEvJBYXKndlI/kWuojKCF4dqRLsmkNG98a4VvWbESVtQYTVHPKHH X-Received: by 2002:a05:6000:4687:b0:47f:8136:e7f5 with SMTP id ffacd0b85a97d-47f8136e9edmr2516706f8f.2.1784706946354; Wed, 22 Jul 2026 00:55:46 -0700 (PDT) Received: from skbuf ([2a02:2f04:d801:b100:1a7a:c7e7:fc27:12d8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a64dsm3759581f8f.1.2026.07.22.00.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 00:55:45 -0700 (PDT) Date: Wed, 22 Jul 2026 10:55:42 +0300 From: Vladimir Oltean To: Michael Walle Cc: Vladimir Oltean , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Ioana Ciornei , Vinod Koul , Neil Armstrong , Tanjeff Moos , "Christophe Leroy (CS GROUP)" , Shawn Guo , Frank Li , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 phy-next 1/9] soc: fsl: guts: perform fsl_guts_init() error teardown in reverse order of setup Message-ID: <20260722075542.p3uissyqzcvfsdri@skbuf> References: <20260721231603.67865-1-vladimir.oltean@nxp.com> <20260721231603.67865-2-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 22, 2026 at 09:18:48AM +0200, Michael Walle wrote: > Hi, > > On Wed Jul 22, 2026 at 1:15 AM CEST, Vladimir Oltean wrote: > > Michael Walle has confirmed that ignoring the error was intentional, > > and we preserve that: > > https://lore.kernel.org/linux-phy/DK44809N7Y8I.J2Z3U4N32H0Q@kernel.org/ > > I thought you wanted to check if kasprintf() fails and return an > error? Just to be clear, I'm fine with either way. I did, but then I considered I don't have a strong justification, and it isn't a change I need to make to make progress with this series, rather more of a distraction.