From: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
To: jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org,
nuno.sa@analog.com
Cc: gregkh@linuxfoundation.org, skhan@linuxfoundation.org,
me@brighamcampbell.com, jkoolstra@xs4all.nl,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: [PATCH v2] staging: iio: frequency: ad9832/ad9834: add comment explaining do_div usage
Date: Wed, 22 Jul 2026 13:52:27 +0530 [thread overview]
Message-ID: <20260722082227.18768-1-raizudeen.kerneldev@gmail.com> (raw)
In-Reply-To: <20260630032322.5805-1-raizudeen.kerneldev@gmail.com>
Previous attempts to change do_div() to div64_ul() were rejected because
mclk will always fit within 32 bits for this hardware, making do_div()
safe to use.
However, Coccinelle continues to flag this as a false positive. To
prevent future developers from submitting unnecessary fixes, add a
comment explaining why do_div() is intentionally kept.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
---
Changes in v2:
- Instead of changing do_div to div64_ul, added a comment explaining why
do_div is kept, as requested by Andy Shevchenko and Joshua Crofts.
drivers/staging/iio/frequency/ad9832.c | 7 +++++++
drivers/staging/iio/frequency/ad9834.c | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index 60c33e10c46f..6d046e9121e2 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -118,6 +118,13 @@ static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout)
{
u64 freqreg = (u64)fout << AD9832_FREQ_BITS;
+ /*
+ * mclk is an unsigned long, which triggers a Coccinelle false positive
+ * warning about using do_div() for 64-by-32 division. However, mclk
+ * for this hardware will always fit within 32 bits, so do_div() is
+ * safe to use here.
+ */
+
do_div(freqreg, mclk);
return freqreg;
}
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index 33dfd723923c..8722f3a01cde 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -103,6 +103,13 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout)
{
unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS);
+ /*
+ * mclk is an unsigned long, which triggers a Coccinelle false positive
+ * warning about using do_div() for 64-by-32 division. However, mclk
+ * for this hardware will always fit within 32 bits, so do_div() is
+ * safe to use here.
+ */
+
do_div(freqreg, mclk);
return freqreg;
}
--
2.53.0
next prev parent reply other threads:[~2026-07-22 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 3:23 [PATCH] staging: iio: frequency: ad9832/ad9834: use div64_ul instead of do_div Mohamad Raizudeen
2026-06-30 7:39 ` Joshua Crofts
2026-06-30 12:02 ` Andy Shevchenko
2026-06-30 13:07 ` Joshua Crofts
2026-06-30 13:27 ` Dan Carpenter
2026-07-22 8:22 ` Mohamad Raizudeen [this message]
2026-07-22 8:46 ` [PATCH v2] staging: iio: frequency: ad9832/ad9834: add comment explaining do_div usage Joshua Crofts
2026-07-22 16:03 ` Mohamad Raizudeen
2026-08-06 20:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722082227.18768-1-raizudeen.kerneldev@gmail.com \
--to=raizudeen.kerneldev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jkoolstra@xs4all.nl \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®