From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F18541D11B for ; Wed, 22 Jul 2026 16:00:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736033; cv=none; b=eYxpyRuPFtMd29mMbzEI84Seqddd9hC3qORvlwXFYBPIIZngeoPpR7htZHcP+KPzVzluD+nAfBIbvhPKRX9PrYQ7X1bwKrlhr7TWFoQOfUY7BzV61ynlBVITdsh88tzEyEF2c05VV8zUbtebpjmIF4mpt4/X0lE5IgLrBe54Ecg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736033; c=relaxed/simple; bh=UwPMrzkEFYDQvmOeu9Uqitb1bfLVR7kFSvjSpva12Bc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KPFBfxoG3q2S0YpzddN++GnKajdtPIiI8T64TsztVJOfmr/hgkmn5MywMs6gNJ7SxFofN29C1AwWq9Wd7oFcLW0MaGS9M+dQ5BzpivMnvY8g6sUqRb5Eag9REL2nloTri9X5pP923W1ZK6TWzKsIOL7O8nRZRLiaMJqcxaFbhPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TTTE48+l; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TTTE48+l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67EB51F000E9; Wed, 22 Jul 2026 16:00:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784736031; bh=aHdgY5r4uJCpDKIGepAv2tGFo3ooAxjfpPP7GfZz+AU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=TTTE48+lBmFUFgwvIl8vO/8al7XhvFI1z0wxvrSTPazTiZ3lz+wE/GuxoWx9+/09J AJdoXIhuHfFq4v0Vnq0bCDr5PHUtU5mQh8FNM56iG75x74dB0kaDvjT8MXlgpC/fwn svdJBFImGI7D9paBSbzA7utRhaY71IdVEs0QijMw= Date: Wed, 22 Jul 2026 18:00:22 +0200 From: Greg KH To: Eli Billauer Cc: Jonathan Corbet , arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] char: xillybus: Harden driver and improve code quality Message-ID: <2026072212-fernlike-junkyard-461d@gregkh> References: <20260722102307.49090-1-eli.billauer@gmail.com> <87o6fzdqps.fsf@trenco.lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 22, 2026 at 05:53:14PM +0200, Eli Billauer wrote: > On 22/07/2026 16:49, Jonathan Corbet wrote: > > Eli Billauer writes: > > > > > This patch set consists of several boundary and sanity checks, gaining > > > better control of execution flow and fixing minor coding issues. No > > > difference is expected in the driver's behavior under normal conditions, > > > except for one change that might improve bandwidth performance > > > marginally. > > > > > > These patches are the result of a comprehensive AI-assisted code review, > > > using Deepseek, Kimi Thinking K2.6, ChatGPT, and Claude Sonnet 4.6 as > > > plain prompt tools. > > > > So it would seem that they need Assisted-by tags? > > > > Frankly speaking, I don't know. And I'll explain the dilemma: > > As I wrote in the v1 cover letter (and removed for v2, which I perhaps > shouldn't have done), my work with the AI tools was what I call a "reverse > rubber duck" session: the AI tools told me what they considered to be a bug, > and my job was to convince the rubber duck that it was wrong. And this went > on for three weeks. > > In a few cases, the rubber duck actually had a point. In most cases, it > merely got me to pay attention to things I didn't notice before. And the > actual corrections were written by me: the suggestions made by AI were a > long way from being usable. > > I understand that Assisted-by tags are intended to keep track of how AI is > used for contributing to the Linux kernel. But I'm not sure my case is what > this tag was meant for. Plus, as this went on for quite a while, I don't > have a record of which tool contributed to which patch. So mention all four > for all patches? > > So I'll have to bounce the question back: Is the Assisted-by tag suitable > when AI acts as a rubber duck? Yes. Please add something there. thanks, greg k-h