From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775193115BC for ; Wed, 22 Jul 2026 13:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784725839; cv=fail; b=E+r6wgADrJi73dgpbNLMNXc6eHzq6QGJo9nITepnb2sNUVn6GCKbE0I+GrkHLz5DB083FN5xbGJuDf6CGgIV+k7sBLnPwgRVsnipw5DQbT70MKtFlcAkRugSi0anc21yYBMFciTn/Ssq8RUooYy66uF/HL0oeF9naEBBVDRhzo4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784725839; c=relaxed/simple; bh=W14FXWk1dEd4r7Se+btKLsvHmR1TZzZ1qaxhzz+hbHU=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QAMdbfV07hBMJRuN8NjkX143ZLmdEWtLlDwZpny/BIAT77IYIQ0iUYPfL1QNdYmRygGwC9kCLTmyFx3Hhi/Z1EDCfiKtK75Wrqrj6sRGWWj67Jrl2qwT0o1HhqTLhvajd3Z0lHxjd+ivHw5fpz+bOSGZxTsvvGrLUEr1tmPd4FM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=nyZiKuFe; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=akFyYYKK; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="nyZiKuFe"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="akFyYYKK" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 66MD1Nj21747061; Wed, 22 Jul 2026 08:10:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=proofpoint-05-2026; bh=oXK/8Zorbz+ia7s YhsJBBNhllgD/VVN+nSdDpmEBfj8=; b=nyZiKuFeJopdw/pYIPkeqvh0HZ6YbTa n7uuuncS9NmAcGB+U6mo5wcP1XUE56kjwylhtlmTp860Bm0ERDRxtpS1uHJESvOQ /3h2T7wedO+1jwM6GAmoe1CrL/HXHqmwUy9WYEs1Dswf2kIJ/7JQvR6iMIFBitl8 +rDfyhoNKV/qUD3nGS5ysrj8I6tAM/4p4jlUhOybhpi/k0Rfu4+xoYDTFr7hKzJa MX+tPa1z55UruaTf38XWjFT4N0ALaNg0uIf3JGUiQWQZdvaeB8olc2cYK0i8G5ue ck53W5G2sH/eo+NlohKJ3vYa/ZUfjDZjAuRiT2jAs/353oe8NcgT+Hg== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012005.outbound.protection.outlook.com [40.107.209.5]) by m0384305.ppops.net (PPS) with ESMTPS id 4fjw4jgeat-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 08:10:32 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iUpqaZZYDHGRdqf+KaWRfqVOuPyuCHqus6ZPWPyE3IuHBmhp6jvhcBydrJtfTGiw0k7vKEFsWZgm93TOb6f2R9KUbRm5ayajXkGh2zMj5tRi8whTU0T6hEikc2nYypKXlhAaGY2ZvLjEw62p6ngIl5y5DweTC3RP6OiLJKUlo1QLupwMokYfex7qTnzRIdvzjOrRTUx5IGpcLbavfG80BG4zqUwIx5sJfxfmLFbtz/4/OsYAycKKnhrKGHQuSZ+fI2/+RTb0M6qGmAu7cntBFvRg7G30uFy8E5WmUNLneYZr9B0n2sdp/z31m1waO8DFJeWhavElQHHy037VrsP7hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oXK/8Zorbz+ia7sYhsJBBNhllgD/VVN+nSdDpmEBfj8=; b=DK7k+kkZenWay7HPsCN8EnNiRzyUF4pTv0HNm9ySQV3a3/wNC20ir30ihZ2cBwilHJtULllnAddCOoT3Q7kUzVfRL5CScEckxVmoB5q2L5vaKbiIq0asIT59UbSpBikn194LP99O7BEV23cj6V0qII7bmee/CNfwC3wBAJ9wmFSo/h3P5cqbeXUdWkyJKC83tmE2RA8bjkeDkGztUFJCU6SXWLi0pHdVyXlYNbyMBGXSBSjXf/CmdyD9/N88Vl3UyBz4gG5L5Br/Q+UKKDxUE6TCjNGMbrOMxP4lo+v9vqlsthX8EnEm2F9vgOlSlb+hqqGvxZdWqbJNvZXevhDaig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.195) smtp.rcpttodomain=lists.infradead.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oXK/8Zorbz+ia7sYhsJBBNhllgD/VVN+nSdDpmEBfj8=; b=akFyYYKKuQMOfhulQpv5U8wSbpozWpyTDgonrd3Bzvw4HGKz32DA2p2VhaA7xVf0xnsKrG/7oyXlDGovUqFrRgHIC2Q7WULpnyVqKUmpB2axIGZVRedzESCstYIpcJMv7Jvw8xk4ER/JI92SO8rbJ4+lEmnU7CwKMbkPA/nVWSs= Received: from SJ0PR03CA0343.namprd03.prod.outlook.com (2603:10b6:a03:39c::18) by CH4PR10MB8145.namprd10.prod.outlook.com (2603:10b6:610:235::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 13:10:28 +0000 Received: from MWH0EPF000C6187.namprd02.prod.outlook.com (2603:10b6:a03:39c:cafe::46) by SJ0PR03CA0343.outlook.office365.com (2603:10b6:a03:39c::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 13:10:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.195) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.195 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.195; helo=flwvzet201.ext.ti.com; pr=C Received: from flwvzet201.ext.ti.com (198.47.21.195) by MWH0EPF000C6187.mail.protection.outlook.com (10.167.249.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Wed, 22 Jul 2026 13:10:26 +0000 Received: from DFLE206.ent.ti.com (10.64.6.64) by flwvzet201.ext.ti.com (10.248.192.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 22 Jul 2026 08:10:20 -0500 Received: from DFLE203.ent.ti.com (10.64.6.61) by DFLE206.ent.ti.com (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 22 Jul 2026 08:10:20 -0500 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE203.ent.ti.com (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Wed, 22 Jul 2026 08:10:20 -0500 Received: from localhost (uda0133052.dhcp.ti.com [128.247.81.232] (may be forged)) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 66MDAKRv3224540; Wed, 22 Jul 2026 08:10:20 -0500 Date: Wed, 22 Jul 2026 08:10:19 -0500 From: Nishanth Menon To: Pan Chuang CC: Santosh Shilimkar , "open list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS" , "moderated list:TI KEYSTONE MULTICORE NAVIGATOR DRIVERS" , Hari Prasath Gujulan Elango Subject: Re: [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err() Message-ID: <20260722131019.u6cegpas3vl5pewl@vehicular> References: <20260722023523.42269-1-panchuang@vivo.com> <20260722023523.42269-6-panchuang@vivo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260722023523.42269-6-panchuang@vivo.com> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000C6187:EE_|CH4PR10MB8145:EE_ X-MS-Office365-Filtering-Correlation-Id: b8934535-0bb2-4fbd-10a2-08dee7f298a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|23010399003|1800799024|36860700016|6133799003|56012099006|4143699003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: SEkDHtnPhmOR6jeqx5aHPa2mRuLXzAxuSpmcSv6h65vH2m3vr4vu8zYz9Hg0hop85jedfoTgQvM+mxtmcHo5xRseMQagCPlTu0qNBdyayrgq/jX/D33Ek3c9qoWTMnZDcDGmYMOp8TMv1kmUldIu2ITbROqfVLhXM6nUEc5zylofCTwuAaoJfz8JsHmmfKVQ42gS7bhMu/44gykJ3D5RP2sVoyngFaD5+LR4TvNvMzhNsyABy5vc0GJw84JlFpDsF85XQOVJhTMl/+aJ8NbQUp1bLYhDx6fpjFF3n40fh3eDA2Vh21m9AoYjOv8LBFRm4Tke0bgUsqgpCDWQIM9kBnhKxz44q/f24nirt/Wruxyag21PKx8lZdt9l3M3gn8U+/KvYR3SMqq7/RuOl74hqTlQoryMol9hJa8uV7jQ9lVl96KzmnGq70LplRdCS/F2T1QJyOo4HZgmhZ8RZQCfXZ6v2jUmYcj87ElPCHbMdEOe+Y/sPjGHaXOWBD9dbY3Ha+eq8IiwhtEzQiBDuBN6lVD4xqxMqix5VXUCdRshTMRdxUAi1K+ipmTMNI8My98NriXIKIVM21Q/hAOziihsgUzJONEff/UmO0FBDPsLw5djm1cv2RnlCUG62zbBqSri3wxwNpsBGpGKnbQAMBZqjc3WyZh4Ei48mX84RXlm6LTYuZAXu+A2mnI4pKZ+uPsoMyVOfm9P91++h8kvGimqXQ== X-Forefront-Antispam-Report: CIP:198.47.21.195;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet201.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(376014)(82310400026)(23010399003)(1800799024)(36860700016)(6133799003)(56012099006)(4143699003)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: E9tZyw8GJTkdZGw4+leeffIXWjB9FoFueQE5b4YLKlmbDPFnBdPNX6kNNVep+4HdR41kpPjFULrPnbEzI/k/8Y50lKOIyYSUmbh3UQ0UXi6AgkC4vAJ+hKfBj1gb1IJru+qMwZm7D4E0Edh6Fa5NOTjmZJMbXwuK/Ga40FQnQ7qbjEZI9LhLETiDa0yJ1j/B9qguflUXceNB0OvAmryytpX4DncsTIRPHXvsr8WBYXh7umzT7oAW1cxsNR+nzoUD/AuiyadTTy1ksyjPYIQ9VWvh6GlfYPUJgJk1zRtW+2uFXogqcQH2IfLetYJ1VQsGjQc5ynVnXn1npX0lmSeDw3KlUMdv2Md8BJSPO4lk4BKSLJjoqyAcH0bzAOcPcDvXRoSGR6ZLxkpb+lT2go6ScNZiuZix7fn3glgz/+v+ux+RjTBXhsQvfdDCokvH7sPk X-Exchange-RoutingPolicyChecked: PA+uXZdfHiOnf5ZD826ZX71SJGr7tUXI+QcJDZxrFOygA4P3igJDvnvctELFPJgIvghG6+1cTncNKusp4yTFIlwJQA2KpIta+kkmSO33P1z7EAO6zC9LwpdPk7iNaAFBk8Erv3apmLDqwpbGKiJH+E6ri5cnw/rJ6ZDkrxhma9Y27oI8QcWYxDXnkKNo0KrlQEAgAx0uggVxbq0yhI1zc2LWYCNC1iTQgj0wC94k9F4Ppax0c9yvyeEK2bkZigfkvX1S1rZJCEM44vOqXP0JHgr8B51e1DlRj8asVjSNo1XS9uPEnY27T1luB5zR33JlMFN+Z/476Z9obho1m8t9UQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 13:10:26.0711 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8934535-0bb2-4fbd-10a2-08dee7f298a1 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.195];Helo=[flwvzet201.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000C6187.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR10MB8145 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEyOCBTYWx0ZWRfXxmQK1Is4KDG7 CNmyCOmIg7IQwuh4jtJFZh7O8ET8BcUDXvwCX5jbgU+XbjDo4650WS8S4BTvBG/pTJ4ezcJknMN PaKeI6OYT1GlZeNeAS7YcMFEnYAuC9M= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEyOCBTYWx0ZWRfX+9RQHBsPYw4x J9a6oESJXErFElO4IY2tKVrUzGdeG1E5sRNwkdY1jI0bWr1HfoixQRi4mAYONbYSGSP+8Olfnpb tFuHGNFw9cNX219gVUEgFhD7SxYkEnLN++uP3eYI89wSCeAd+2MOExPmiGh4Husk5H9b7cRQsd+ cUWpp2VvFt3S/aQiWHzacn97Q1DxmcY0yUGGFKljWsLF14eqfVmYnplheDf+68konAYb1PtV1hD v5rCI6meu0ZoinVkN0HTWum0ujX7bASIHPYu4LxLvlHjaMd2PB5esvcDFtguxzyRCSobPmfA77o hVJwaGWt+DAOXXDUqjUdKqT2Jg8dH7iFx1HaHj93Gz+XVyGtD1tWIRGKO67EjS9uzq9eU0sOhlN ShcqIp7yz5rSFmaDEROxHZqgQAMapzuw2OWv8kUCn60Ar6YLFDEno0CqNf7GBy7xdTWuH0JXNt/ fDuj3oQQQKrXIaOSBRA== X-Proofpoint-GUID: p25L0mGHvgFWKyN2lKmzh0pP6wQVPhFb X-Authority-Analysis: v=2.4 cv=ONwXGyaB c=1 sm=1 tr=0 ts=6a60c148 cx=c_pps a=jqKUOoIthQ4VgEFDxjm20g==:117 a=tJyPKKxUohctrY4NYmUjkA==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=sozttTNsAAAA:8 a=1WtWmnkvAAAA:8 a=KZuKFN6OswOjJxsanpQA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: p25L0mGHvgFWKyN2lKmzh0pP6wQVPhFb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_04,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220128 On 10:35-20260722, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > > Signed-off-by: Pan Chuang > Reviewed-by: Hari Prasath Gujulan Elango > --- Did anything change in V2? we don't need to post a v2 purely to pick up reviewed-by. B4 will handle it. > drivers/soc/ti/wkup_m3_ipc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c > index 5845fc652adc..f8640cdc2a21 100644 > --- a/drivers/soc/ti/wkup_m3_ipc.c > +++ b/drivers/soc/ti/wkup_m3_ipc.c > @@ -630,10 +630,8 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) > > ret = devm_request_irq(dev, irq, wkup_m3_txev_handler, > 0, "wkup_m3_txev", m3_ipc); > - if (ret) { > - dev_err(dev, "request_irq failed\n"); > + if (ret) > return ret; > - } > > m3_ipc->mbox_client.dev = dev; > m3_ipc->mbox_client.tx_done = NULL; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource