From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64625432303 for ; Wed, 22 Jul 2026 16:23:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784737393; cv=none; b=eKmOrBUv/tafw57HTv7MoM4ig0UB6mKrDiibokRr+w+DpXbXuFzDzac3zdk4zhqabEwZcJ2QbwWZUnHTZtr58Xuhnayf5X/7StFWPqZBQP0NxmZZ0O18UKcH5ajiTn0SRrJA83CmXkGnz3AtQBfsfGUEOAEAg5TgoPcwEA7di9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784737393; c=relaxed/simple; bh=i8HPqvtfirXrkg9CRJQYHnwQufUh+A0XBBmT0sSXqHM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nizvMjJ6zFba88ZkYRmKK/0+gtOzcPLLhbrchEe1X+7s2SJch+xUDj0UDTbDOum4N/nODKpcJhGDRPNQU8oxFiJKxvG5hzkwEI4ITbELwoCxQWIHAvTYSxX87UkwkFjQUzVvPRQ/977uFYIfx9/rsge0+MvrIFV79+0Zzu1U2XA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aVKoNCHg; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aVKoNCHg" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so9651230a12.2 for ; Wed, 22 Jul 2026 09:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784737391; x=1785342191; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eVAyazMl5WkniAlf75NkROON8JhWPspf9inm470FnWQ=; b=aVKoNCHgSBtdvfPTGMJRrjtE86jXGz5j+q/SxLV53aCQ2XtuMyyqQL/OqLSFjK9FXV FQ3rY40NO8uKnjht9+r4AhHUw596geoOtdvtCuPeO7pN878WZ89uVTCwLbvDGa4lg4dk uru4pyfgEGCOsXQ9M/by1nxE0IcReTQBzT3ayz4Nx7ZTi7NBnJ/uBo6zy/3ToQCY/Qj2 VRu/RGCExPxyBIqv09hF8vnFYqnIhE0BqQSZk/sIone4k+I29uvYakPHO7YuKoOI1Wh6 mjKTmJklyU4psj5Q1pUejU5XxlU67Y8a6nNGcBX0BmrvBJQtUY8IYTkNQcqXFK/e6wZd wNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784737391; x=1785342191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=eVAyazMl5WkniAlf75NkROON8JhWPspf9inm470FnWQ=; b=Cu3rnIvZhL4ggqBsv97qjnT6aZYA6C+PYHeT95P4U1MuSq10mFPTmAaA9btUNgSflB Co/vcOr41ZPLVzICVXp9rkI/F+J+h0Yak7WQWdv471A47uEgWE4hgM1Aijb25CL0cl3H dTmZFKhQ0dxGJJMAzKzAT/7/Z2mlUXuQN5v84YIsZirQ+rSMU0JCk964YWg7X9EqwzRC m0ABTlI8b1HizgH2XWuZr5W84yZUskKecrlf4pxe5C/8O/7TxfhZxgM+h7dq1qQs4mUM LsiyUwTRXujBa9HJmSdowTv5Rz1pp2KaREjIG264y0vQ2VxiBOI4zkda0zmOhuMU0Goe D9oQ== X-Forwarded-Encrypted: i=1; AHgh+RrN8o28kk+2ji12DSwBNMsh1XPgpYj9pkkpD2Id0yM5w7wlfSW9AR6azxhniBvu7fEcMwLxz5zWBlktgpA=@vger.kernel.org X-Gm-Message-State: AOJu0YxpaVAoy4FZ5nTnzRdEZwKuiz2Da8og8XBSsbAtqSwvI/hs/sGF GiZUHQFacwQexq24lOlDM7spPhofnMbBMOpgZq+dVc/EghVHgeG8SfA= X-Gm-Gg: AR+sD10hng2efV7CVDkPxTSimf2iXgMbQBhIUxWOOkaPyE8l9Sih4A1azjj4YmORX8i PghElVh+j1TtiHN2Qbhabk0HKzXkNetmrrYHsfgFwcWjhB2kaqO0KcGkHrhEYKWQxGs3EuL2tLX EJ1FCIW+WQGe5knlsPPToR8hFp/gRsc3cj99C83+xrQuM9aZT7eeQ61hHiBQuJQQzT3EI4HLjyH kILFMggzmI8x23D4sYaJkC4Vm/Itt4Zr7gJ5V6CiI12SZAK86ts+hBUUx+SH6n/i2kc5WTtyXdW 0JXXfzI95TSKps5J460DBmeHT0KInt1wabnMyRN3k70qdx7W5IBE/sXFXb46cGZjgyvh+ANgGgl Rk2WNTiMotp+IOgfOlqLGv7CTTfOfTJs3StTCppMe4FR6tWQDyE7exGgh6BEPJtMYUsEzNI8zDD UqTKkle/Mp9q73erIh6LYvXIBvpiy4Qw5nLDBL3j2zuA== X-Received: by 2002:a05:6a20:cc0b:b0:3c3:ac5d:b6de with SMTP id adf61e73a8af0-3c3ad7da25cmr27209656637.22.1784737390679; Wed, 22 Jul 2026 09:23:10 -0700 (PDT) Received: from localhost.localdomain ([101.0.62.129]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc1e3d9sm9260471eec.5.2026.07.22.09.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 09:23:09 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v2 3/3] iio: light: gp2ap002: Fix regulator leaks in runtime resume error path Date: Wed, 22 Jul 2026 21:52:47 +0530 Message-Id: <20260722162247.8229-4-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260722162247.8229-1-nikhilgtr@gmail.com> References: <20260722162247.8229-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If enabling vio fails, vdd is left enabled; if re-initializing the sensor fails, both regulators are left enabled. unwind previously enabled regulators on failure, mirroring the error handling already used in probe. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam --- drivers/iio/light/gp2ap002.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index e8ba9c00dabb..430336b51f83 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -677,7 +677,7 @@ static int gp2ap002_runtime_resume(struct device *dev) ret = regulator_enable(gp2ap002->vio); if (ret) { dev_err(dev, "failed to enable VIO regulator in resume path\n"); - return ret; + goto out_disable_vdd; } msleep(20); @@ -685,13 +685,19 @@ static int gp2ap002_runtime_resume(struct device *dev) ret = gp2ap002_init(gp2ap002); if (ret) { dev_err(dev, "re-initialization failed\n"); - return ret; + goto out_disable_vio; } /* Re-activate the IRQ */ enable_irq(gp2ap002->irq); return 0; + +out_disable_vio: + regulator_disable(gp2ap002->vio); +out_disable_vdd: + regulator_disable(gp2ap002->vdd); + return ret; } static DEFINE_RUNTIME_DEV_PM_OPS(gp2ap002_dev_pm_ops, gp2ap002_runtime_suspend, -- 2.39.5