mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Link Lin <linkl@google.com>
Cc: Vlastimil Babka <vbabka@kernel.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@kernel.org>,
	virtualization@lists.linux.dev, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, prasin@google.com,
	rientjes@google.com, duenwen@google.com, jasowang@redhat.com,
	xuanzhuo@linux.alibaba.com,
	Ammar Faizi <ammarfaizi2@openresty.com>,
	jiaqiyan@google.com, ahwilkins@google.com,
	Greg Thelen <gthelen@google.com>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	jthoughton@google.com, stable@vger.kernel.org
Subject: Re: [PATCH v3] mm/page_reporting: use system_freezable_wq to fix UAF during suspend
Date: Wed, 22 Jul 2026 17:36:39 -0700	[thread overview]
Message-ID: <20260722173639.34d3f58413354218b24a5b0d@linux-foundation.org> (raw)
In-Reply-To: <20260721005603.1710551-1-linkl@google.com>

On Tue, 21 Jul 2026 00:55:33 +0000 Link Lin <linkl@google.com> wrote:

> During PM freeze (e.g. S3 suspend or S4 hibernation), device drivers like
> virtio_balloon reset their underlying virtio devices and delete their
> virtqueues via vdev->config->del_vqs().
> 
> ...
> 
> Fix this by switching page reporting work to system_freezable_wq.
>
> ...
>

Thanks.

> Fixes: 924a663f75e2 ("virtio-balloon: Reporting free page reservations")

hm, now where did that come from.  I can find no such commit and that's
the second time this very unusual thing has happened in 30 minutes!  I
wonder what's going on.

I'll use

	36e66c554b5c ("mm: introduce Reported pages")

OK?

> Cc: stable@vger.kernel.org

The bug is very old so I won't fast-track this fix into 7.2-rcX.

AI review pointed at a possible pre-existing use-after-free issue,
related to virtio-balloon.  But I think this is a rephrasing of the
issue it flagged against your v2 patch.

	https://sashiko.dev/#/patchset/20260721005603.1710551-1-linkl@google.com



  reply	other threads:[~2026-07-23  0:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21  0:55 Link Lin
2026-07-23  0:36 ` Andrew Morton [this message]
2026-07-23  4:07   ` Link Lin
2026-07-23  9:15     ` Michael S. Tsirkin
2026-07-31 20:21       ` Link Lin
2026-08-01  0:16         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722173639.34d3f58413354218b24a5b0d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ahwilkins@google.com \
    --cc=alexander.duyck@gmail.com \
    --cc=ammarfaizi2@openresty.com \
    --cc=david@kernel.org \
    --cc=duenwen@google.com \
    --cc=gthelen@google.com \
    --cc=jasowang@redhat.com \
    --cc=jiaqiyan@google.com \
    --cc=jthoughton@google.com \
    --cc=linkl@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mst@redhat.com \
    --cc=prasin@google.com \
    --cc=rientjes@google.com \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®