From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5944368D4A for ; Wed, 22 Jul 2026 18:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784745330; cv=none; b=mTTe8VxEgbjbsVIsxbfdIx6kDouSA80Jy4VU4gbR1Bmpwp8tt9uCp250Jx3R98vffv/LEt4n+eL230Yp1UxO+A1xGVlK7dYIIetcuToYhl/KOpa5sJmATbLUqTgG/31ThHQApMDpw12jTd7u+Y11OEfF5LmcLXrDpowLmY06apk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784745330; c=relaxed/simple; bh=5oK9iWBVO5m3icq9mZsHdP4HXHEqMsBagSx2ZqZAtgU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CRxbqLGpxKFgUX3ns8nAIEa0F8Tl7lbD8M3KYtxYYy23JfTWgMQ7Ph0ySMQ5x3YS3RrzO/Ggkl+JlRXV9hQ8p1YIY5mq6fMAktK+xM+8v8R7KPge9fPNcJ1W4HP/gQc+3PuSsnklAqqSA10uMBfyC01/kWfjP487xsrky8QHqmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=YS0lv6dY; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="YS0lv6dY" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-90327237340so60588346d6.1 for ; Wed, 22 Jul 2026 11:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1784745328; x=1785350128; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qg2sr9w1J3nOO7FQ1cLX7doN7aPqFEfPWWRPqDtuE0I=; b=YS0lv6dY/KvM0E1GFVfrsQcBmnuYkh6ogE38ja+07tMZdYy6n9kc3aaCVWL2CtLxcz 7e63aPq8cFHomR7Ts4uEmxGF1uzrpnzVOUA9x1mBb24Hh041hf3cuw5KXkAuSSj7rN6k zpom9zzA6yVlkgmS6xgCUHW4Fllzu74Nq4pLyWDm2YcYn/fNZazTZ3spiBdyiP8aPPOd QPNiP58WDft/yj9Wx0ojyqpoxnySP0uGyPravkVJROvLs1rYHguf/X4j058DZolKJg4x byghJo4ErdkbnOASFvrhRQIsDgwmvcPhWxxI3boTgbE8WHFeJZvJ3/mU4PVhua/Z0iKV vnAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784745328; x=1785350128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qg2sr9w1J3nOO7FQ1cLX7doN7aPqFEfPWWRPqDtuE0I=; b=ZaJbS+dMKn/3yI8Z+ZB+Y9y3r3qzVce3pA/CKFNor2Nf5ezGVyG6aA6/L7nQIBDjch x+W462wJ1RUcssb7yVHwAUwU9vcl4XevKXyqxHlgcUzhlVYzkxJNknP+9eDRDW7IHX0u FpFQa6e1i9CoZ93fm/Y4O4hNEJIjeEKHKA9Rxdt9ah9Lo1U1Zklntd+Vyp4oLvrPDpnd 9d63WNIfO7Sjto04B+6A8kjYujkeHgv0SJpaZlLZjO82PPhx+X4su8bCniA6axksPFL1 ixWVxG1DzMyqm9ZzQvmqMor7SOy048orZpSEG1nC+Wx78+D4LdKE5VkUtL8uGSP8M4KV UC0g== X-Forwarded-Encrypted: i=1; AHgh+Rp8vfu8zTKqZJsxvRE0roiSXpL80CCtMQaTbwJrzrw3bcOW9/Mkz6TnnKFFhhLdUS1+PzijxhxdfpZO0bM=@vger.kernel.org X-Gm-Message-State: AOJu0YzKTnnpPbY5x5zywglM1F4lZ0KWm1+08/UO7kTvIoJUqlF492s0 IcK2i4oBCp4th+vuz++3eCTmLxgjPeIIruKJ6xakVvBDeDSW4CsjXqFRj54Na0MBzAw0KsDsDMr 7kv4J X-Gm-Gg: AR+sD11iz+7CWN2ZRSD8E9V8rii2b1uzfMzXLI4TKyRhqodq2GLSE4AtIFSYYhYb4Rr 7kpc5TzNjsRYVMKlsMF+klU2kmX1gi09Ze9KJZF3X/krKYbc4FfiZZEU4gljBhK2sod771Zs7cA GqRNe2oTblcJZz2HgqOOPHeP/fgplu06B0qitD1ABkN+qSfCGSoGRJmwY4bjFPkAT7DDWWcK0i/ o73wU+0pvJlCTeEsePIm1F+9ZrIQaKGjZlTNliczEpkqyzb5Vv5CFnxWBaWaEBP/8P3Ok+mrTb7 K16uJS+VGatIpxZEqJPU190z5I8E7GSfavLXPiIYXR3FD3z5ge2Vrw5lwOU9GVYbs72sn1HQHD0 TwAIPAL0JuR4jPK+SgUQQdIcRtiOHNnNhNC2gPj3s7NljLUwOhZNkDNW1DcRxSbJ0hAuf0uYvBC PQpF55l1hT9H4CZP25X82Cw8txHsv7Kp31a/lDD+0UO+0/CLeGeWxOjFuztTnBbMQ= X-Received: by 2002:a05:6214:2c12:b0:903:faf8:a93f with SMTP id 6a1803df08f44-907b9bcb694mr64124716d6.30.1784745327474; Wed, 22 Jul 2026 11:35:27 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F.lan (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907ba8b3e96sm27630216d6.1.2026.07.22.11.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 11:35:27 -0700 (PDT) From: Gregory Price To: linux-cxl@vger.kernel.org Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, alison.schofield@intel.com Subject: [RFC PATCH 2/8] dax/kmem: add private= to online memory as an N_MEMORY_PRIVATE node Date: Wed, 22 Jul 2026 14:35:13 -0400 Message-ID: <20260722183519.935213-3-gourry@gourry.net> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260722183519.935213-1-gourry@gourry.net> References: <20260722183519.935213-1-gourry@gourry.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a "private" knob to dax/kmem. Only writable when state=unplugged. Switches the device between onlining as N_MEMORY and N_MEMORY_PRIVATE. This marks the node private and excludes it from every fallback zonelist. Fails if the node already has online (non-private) memory or a if the node has a different private owner. The base plumbing for capability bit flags are added here, but no capabilities are added until later commits. A private node after this commit is solely accessible via mmap on the dax character device (/dev/daxN.M). Because a fully isolated private node cannot reclaim or compact, its dax-file mappings default to base-page faults (VM_NOHUGEPAGE). This makes allocation / failures more deterministic, otherwise a fault may fail due to a lock of given order despite memory still being free. When/if reclaim is supported (and the node opted-in), this can be relaxed. Signed-off-by: Gregory Price --- drivers/dax/kmem.c | 85 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 83 insertions(+), 2 deletions(-) diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c index d9021cf148982..c4c18aeb43c69 100644 --- a/drivers/dax/kmem.c +++ b/drivers/dax/kmem.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include "dax-private.h" #include "bus.h" @@ -52,6 +53,9 @@ struct dax_kmem_data { struct mutex lock; /* protects hotplug state transitions and config */ bool dax_file; /* when set, cdev allows mmap */ struct mempolicy *policy; /* device-lifetime bind for dax-file mmap */ + bool private; /* when set, memory is onlined as N_MEMORY_PRIVATE */ + unsigned long caps; /* NODE_PRIVATE_CAP_* flags */ + struct node_private np; struct resource *res[]; }; @@ -108,6 +112,13 @@ static int kmem_anon_mmap(struct file *filp, struct vm_area_struct *vma) return -ENXIO; vma_set_anonymous(vma); + /* + * Default a private node's dax-file mappings to base-page faults. + * Without reclaim/compaction, high-order allocations can fail despite + * memory still being available. Can be relaxed with reclaim support. + */ + if (data->private) + vm_flags_set(vma, VM_NOHUGEPAGE); mpol_get(data->policy); kmem_vma_set_policy(vma, data->policy); return 0; @@ -187,6 +198,10 @@ static int dax_kmem_do_hotplug(struct dev_dax *dev_dax, if (online_type < MMOP_OFFLINE || online_type > MMOP_ONLINE_MOVABLE) return -EINVAL; + /* Capabilities are stable as long as memory is online */ + if (data->private) + data->np.caps = data->caps; + for (i = 0; i < dev_dax->nr_range; i++) { struct range range; @@ -215,7 +230,7 @@ static int dax_kmem_do_hotplug(struct dev_dax *dev_dax, */ rc = __add_memory_driver_managed(data->mgid, range.start, range_len(&range), kmem_name, mhp_flags, - online_type, NULL); + online_type, data->private ? &data->np : NULL); if (rc) { dev_warn(dev, "mapping%d: %#llx-%#llx memory add failed\n", @@ -480,6 +495,55 @@ static ssize_t state_store(struct device *dev, struct device_attribute *attr, return len; } +static const struct attribute_group dax_kmem_private_group; + +static ssize_t private_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct dax_kmem_data *data = dev_get_drvdata(dev); + + if (!data) + return -ENXIO; + return sysfs_emit(buf, "%d\n", data->private); +} + +static ssize_t private_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t len) +{ + struct dax_kmem_data *data = dev_get_drvdata(dev); + bool enable; + int rc; + + if (!data) + return -ENXIO; + + rc = kstrtobool(buf, &enable); + if (rc) + return rc; + + guard(mutex)(&data->lock); + + if (data->state != DAX_KMEM_UNPLUGGED) + return -EBUSY; + + if (enable == data->private) + return len; + + if (enable) { + /* Add the per-service opt-in attributes. */ + rc = sysfs_create_group(&dev->kobj, &dax_kmem_private_group); + if (rc) + return rc; + data->private = true; + } else { + sysfs_remove_group(&dev->kobj, &dax_kmem_private_group); + data->private = false; + } + + return len; +} +static DEVICE_ATTR_RW(private); + static ssize_t dax_file_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -531,6 +595,14 @@ static ssize_t dax_file_store(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RW(dax_file); +/* Per-service opt-ins. Visibility toggled by 'private' control */ +static struct attribute *dax_kmem_private_attrs[] = { + NULL, +}; +static const struct attribute_group dax_kmem_private_group = { + .attrs = dax_kmem_private_attrs, +}; + static int dev_dax_kmem_probe(struct dev_dax *dev_dax) { struct device *dev = &dev_dax->dev; @@ -601,6 +673,7 @@ static int dev_dax_kmem_probe(struct dev_dax *dev_dax) data->mgid = rc; data->numa_node = numa_node; data->state = DAX_KMEM_UNPLUGGED; + data->np.owner = data; mutex_init(&data->lock); dev_set_drvdata(dev, data); @@ -668,6 +741,9 @@ static void dev_dax_kmem_remove(struct dev_dax *dev_dax) struct device *dev = &dev_dax->dev; struct dax_kmem_data *data = dev_get_drvdata(dev); + if (data->private) + sysfs_remove_group(&dev->kobj, &dax_kmem_private_group); + /* If enabled, clean up the dax-file char device configuration. */ if (data->dax_file) { kmem_dax_file_cdev_del(dev_dax); @@ -707,7 +783,11 @@ static void dev_dax_kmem_remove(struct dev_dax *dev_dax) #else static void dev_dax_kmem_remove(struct dev_dax *dev_dax) { - struct dax_kmem_data *data = dev_get_drvdata(&dev_dax->dev); + struct device *dev = &dev_dax->dev; + struct dax_kmem_data *data = dev_get_drvdata(dev); + + if (data && data->private) + sysfs_remove_group(&dev->kobj, &dax_kmem_private_group); /* If enabled, clean up the dax-file char device configuration. */ if (data && data->dax_file) { @@ -732,6 +812,7 @@ static DEVICE_ATTR_RW(state); static struct attribute *dev_dax_kmem_attrs[] = { &dev_attr_state.attr, &dev_attr_dax_file.attr, + &dev_attr_private.attr, NULL, }; ATTRIBUTE_GROUPS(dev_dax_kmem); -- 2.53.0-Meta