mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"git (AMD-Xilinx)" <git@amd.com>,
	"shubhrajyoti.datta@gmail.com" <shubhrajyoti.datta@gmail.com>,
	Tony Luck <tony.luck@intel.com>,
	"Potthuri, Sai Krishna" <sai.krishna.potthuri@amd.com>
Subject: Re: [PATCH v3] EDAC/versalnet: Report PFN and page offset for DDR errors
Date: Wed, 22 Jul 2026 11:46:09 -0700	[thread overview]
Message-ID: <20260722184609.GDamEP8Z2v9GgRXw1u@fat_crate.local> (raw)
In-Reply-To: <DS2PR12MB98216A090070FB54A63BAD3781FD2@DS2PR12MB9821.namprd12.prod.outlook.com>

On Fri, Jul 10, 2026 at 01:12:17PM +0000, Datta, Shubhrajyoti wrote:
> I have reviewed all the Sashiko comments and identified the valid ones
> (details below).
> 
> Finding 1: Missing null check for
> 
> Comment is accepted will send a patch.

Where is that patch?

> Finding 2: Uninitialized ueinfo when CE and UE flags set simultaneously -- Mostly a false positive
> 
> Looking at rpmsg_cb, CE (error_id 18) and UE (error_id 19) arrive as separate rpmsg messages with distinct error_id values.
> The memset(p, 0, ...) at the top of each case clears the entire ecc_status
>   struct, and p->error_type is set to exactly one of MC5_ERR_TYPE_CE or MC5_ERR_TYPE_UE.
> The get_ddr_info() function then uses if/else if on ISR bits, but the ISR comes from the firmware message for
>   that specific error_id, so only one type should be populated per invocation.

Ok, you can put a comment above get_ddr_info() explaining that it is ok to
alternate between the error severities.

>   Finding 3: memory_failure() with MF_ACTION_REQUIRED from async context
> 
> 
> Sent below patch.
> https://lore.kernel.org/all/20260701095040.4139675-1-shubhrajyoti.datta@amd.com/

Fixes: tag?

Does it need to go to stable?

Also, you'd need to send me fixes for the issues reported there.

> Regarding the context: rpmsg_cb is a virtio rpmsg callback. Looking at the virtio rpmsg transport, these callbacks run from
> a workqueue (virtio_rpmsg_bus.c uses rpmsg_recv_single() from
>   rpmsg_recv_done() which is a virtqueue callback typically dispatched via a workqueue),
> so it's not hardirq context. memory_failure() does take mf_mutex which can sleep, and this should be fine from a
>   workqueue.

Ok.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

      reply	other threads:[~2026-07-22 18:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 10:35 Shubhrajyoti Datta
2026-05-14 11:34 ` Borislav Petkov
2026-07-10 13:12 ` Datta, Shubhrajyoti
2026-07-22 18:46   ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722184609.GDamEP8Z2v9GgRXw1u@fat_crate.local \
    --to=bp@alien8.de \
    --cc=git@amd.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sai.krishna.potthuri@amd.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=shubhrajyoti.datta@gmail.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®