From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C2B3A9629 for ; Wed, 22 Jul 2026 18:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784746765; cv=none; b=slkZAwmEspbWmWSOU6tIspb2AuqO7B6cQi9uGRiUBI8/l3gVNJEN1wKHVDZ63YO8OdZGcbE7L9MJCmLbwq4+v+Yq7hm4j2jL6kSw8DI6I4H4a5KBYAa34tmN2SzcwYA4NQ/twGtGXRUZjpFH3KvPUL/8W7LLgTbjp0F1TAxKXO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784746765; c=relaxed/simple; bh=n8GgQxWkHVm/KdGafTPsIHfxiB0IxGBQX22H0tLv/oc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k+NINrFfFG4F1g5pEG0gHpu7xlsuPQWoQdohew7mlnyQnSFUSSy9Kt5wRw+7K51si2eVKDVpt8/XO/F6svciNl4VOlCXoKa80MMxEOKk/Gh+UHmtbZmH9VIxwA9v7ycxabv4AEzl4FBo0imdDmPmQ/r9FP0GkKvbcuIpq3AUmBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meshstor.io; spf=pass smtp.mailfrom=meshstor.io; dkim=pass (2048-bit key) header.d=meshstor.io header.i=@meshstor.io header.b=BUD9EGMP; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=meshstor.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=meshstor.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=meshstor.io header.i=@meshstor.io header.b="BUD9EGMP" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49548aebcd8so39532575e9.3 for ; Wed, 22 Jul 2026 11:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meshstor.io; s=google; t=1784746756; x=1785351556; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MJ1SD6Cu8vcIcr/kUuDg+vlUw58q6JfkUpXNh8eryGw=; b=BUD9EGMP/1U+a0nwK74clxQtwB3Fm+sF+M1EXzUJE5EBTXRCP8t/YTnJJL2fiL3DaU RGtm0KUneztislxIlc1Q+0tEucU5M0v56RHyBl0zuvRRuv1WDOINASAaw1ePnYxBHh2X yzHHdOgc6q9ZyWd+T7b9/jdCU/okasOSi02zqUIpGd4dYSA3cCJIHJPMroCbo2P/2CKF M+Z0bF0YoyByOp9jyResJ4jJUtJN3fultJElB5c6/k7p3M1BBRC3mQ0YUAjPYFBBFDOj QxCoC9mCOrsuI67i0dUaZbkkjIBb3auJio1hYn8hzbdhmR6cz2WgS5QfFyeXrYVixWba sk/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784746756; x=1785351556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MJ1SD6Cu8vcIcr/kUuDg+vlUw58q6JfkUpXNh8eryGw=; b=YSVkqk5qFcB6kFDE/YxJJ3WxsKgBV1NDBjqHqN51/+GabprfyPDim2+GzMo/zF+aMM Gh5VyZcEDgp4V5piNWWKzN9GcsHwelY5bQ/Bn378J7lT8ADLOqgrZoXUcgI0mdoWpW13 Y6hwpp+o4Ua85rfi7bWr7h1Iri8WOd6rUU+7fslrU5fdODWp9X4nI9LNASVY5MsNRFY2 AegQUzFWJNbZUJ3v6FZVn+6KzbMte43pvKsCXXfQJGFe2NL41hvuY7VyCAHfrP3ivU4w pwz++ndIQCtnXVaj4CpYG1DV9xV67OlbbtUVVWFhe1vt7mJpc7djMEC+ZGTXtp89tqZB vRsw== X-Forwarded-Encrypted: i=1; AHgh+Ro/y2637cuxtAgSDD7cOfCUKXHUX/q42SFd9KrzgWJ6sPuDMEWOoK/ppR7rjM/kDTckGl1a1idUgiidwJY=@vger.kernel.org X-Gm-Message-State: AOJu0YxHB02lLetCQp1SaRcC30xTFGQfY8ZnG3+EhfPqo24BUmtzOyKI goFlBnJ6tpEzzP7weIJ5zMPahGGpqJc6jE8WiWb8YjQAWBUKG2XAwuiajNVpnafPFQ== X-Gm-Gg: AR+sD10BZhHlASl6QyPspZjlDAfWO+WLY2wbjvclZMwmFlA4bI71u3XBf/FxadAd4Kc ZZPI1QevAdgXAqaCDxQwZ5fS74laoISW4VJkinB1kZODta6aXCqihStVR96PQaVO2vcGa4Glfrv nXL9SwNuZR8VFMzDR9GuwieRulGT425IsVMJu+zD6i+1UggUypgEW/0UfVDA9V4IrTxNr8UL5rB yt7SLh7Q0ABXbBlc9tKpnEpj1TH96VGbBBOrxZswvnrDtFozldH4aSUiM6EixgXg4CtYz4LyHem 9QFjd6FmZmnfCJFHekhCvGnXRL77lA9AhJb0d+5uGoU3zEtBsj8bfXYCaD9emLlHZDjYphdPRxY bzy0W7aZiMdsuJnNKgtMi11iUvcP6xtpt9X1PfN5aU6Mq8vdEAlDldMGlPaNX5+Dk83Reg0GzbB m72bJwSRE0rsKW9fIaWR4zYPfB+YgQoiTFS/4rDEr1Aovr/B8= X-Received: by 2002:a05:600c:4f92:b0:495:f31:7340 with SMTP id 5b1f17b1804b1-4954a3d06e4mr270795875e9.5.1784746756410; Wed, 22 Jul 2026 11:59:16 -0700 (PDT) Received: from ai-pc ([46.172.241.174]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-495730353d9sm13740055e9.12.2026.07.22.11.59.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 11:59:15 -0700 (PDT) From: Mykola Marzhan To: Jens Axboe , Song Liu , Yu Kuai , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org Cc: Li Nan , Xiao Ni , Guoqing Jiang , Leon Romanovsky , Jason Gunthorpe , Kiran Kumar Modukuri , Chaitanya Kulkarni , Logan Gunthorpe , Bjorn Helgaas , Shivaji Kant , Pranjal Shrivastava , Henrique Carvalho , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v4 8/9] md/raid1,raid10: set IO_BLOCKED in case of BLK_STS_P2PDMA Date: Wed, 22 Jul 2026 20:58:40 +0200 Message-ID: <20260722185841.449934-9-mykola@meshstor.io> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260722185841.449934-1-mykola@meshstor.io> References: <20260722185841.449934-1-mykola@meshstor.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Logan Gunthorpe A read that fails with BLK_STS_P2PDMA cannot succeed against that member, so mark the leg IO_BLOCKED and let the retry redirect elsewhere. Skip the read-error machinery: there is nothing on the medium to fix, fix_read_error()'s probe reads into host pages and would "succeed", and charging the read-error budget would evict a healthy member under a P2P read workload. FailFast eviction is skipped for the same reason -- the request never reached the wire. Fixes: 02666132403a ("md: propagate BLK_FEAT_PCI_P2PDMA from member devices to RAID device") Assisted-by: Claude:claude-fable-5 Signed-off-by: Logan Gunthorpe Co-developed-by: Mykola Marzhan Signed-off-by: Mykola Marzhan --- drivers/md/raid1.c | 4 +++- drivers/md/raid10.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 917d694ef401..76a1426e64f0 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2658,6 +2658,8 @@ static void handle_read_error(struct r1conf *conf, struct r1bio *r1_bio) { struct md_rdev *rdev = conf->mirrors[r1_bio->read_disk].rdev; struct bio *bio = r1_bio->bios[r1_bio->read_disk]; + /* evaluate before the bio_put() below */ + bool p2pdma_error = bio->bi_status == BLK_STS_P2PDMA; struct mddev *mddev = conf->mddev; sector_t sector; @@ -2675,7 +2677,7 @@ static void handle_read_error(struct r1conf *conf, struct r1bio *r1_bio) * read error. This is all done synchronously while the array is * frozen. */ - if (mddev->ro) { + if (mddev->ro || p2pdma_error) { r1_bio->bios[r1_bio->read_disk] = IO_BLOCKED; } else if (test_bit(FailFast, &rdev->flags)) { md_error(mddev, rdev); diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 9045a3f02dae..e35aeac29f06 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -2848,6 +2848,7 @@ static void handle_read_error(struct mddev *mddev, struct r10bio *r10_bio) { int slot = r10_bio->read_slot; struct bio *bio; + bool p2pdma_error; struct r10conf *conf = mddev->private; struct md_rdev *rdev = r10_bio->devs[slot].rdev; @@ -2860,10 +2861,12 @@ static void handle_read_error(struct mddev *mddev, struct r10bio *r10_bio) * frozen. */ bio = r10_bio->devs[slot].bio; + /* evaluate before the bio_put() below */ + p2pdma_error = bio->bi_status == BLK_STS_P2PDMA; bio_put(bio); r10_bio->devs[slot].bio = NULL; - if (mddev->ro) + if (mddev->ro || p2pdma_error) r10_bio->devs[slot].bio = IO_BLOCKED; else if (!test_bit(FailFast, &rdev->flags)) { freeze_array(conf, 1); -- 2.52.0