From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9DBE4582FD for ; Wed, 22 Jul 2026 23:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784763753; cv=none; b=OHTDyEr1wJHAPAx7gMjGLSqATFdcfV0791QUVFcxUNcCBc1W4UY8lb+0kkcEMG/hS8XKnT4DMf7FpByA2zkuV1AHjanL7Wj8MAV8pVU6gV8R9vViA/XjQG594vAu0YtouJhs4wSSRqC3R2HlOA1gpFUSMcSZpev3fyVDyw9Zhyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784763753; c=relaxed/simple; bh=kklT4BtGmbxmXXl5fIL1oE0W7MuVDXFCHQeH+8hoyJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d2cYBpb1Lryrd1pwEnH3aS9fw9F0HrLBXc7x9XDujLVMHjgIwXxEE1fnZp1PkwDEfpXZMyniFql3qS2X9XPF8ErPlpQsmrVQRpMpQFC8YeFiejas8M0ZRDrmeM6GEEm27KFk2A5DHAb3lXrMGx725WgYsRaUoHMuCIxlHibDQ9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F5s9REBF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AxpUhsaR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F5s9REBF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AxpUhsaR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66MMnxhp2176078 for ; Wed, 22 Jul 2026 23:42:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=o3eANFp8vRp iIPxEwZyDYsYfAkwyo20ziwerf+wA+5I=; b=F5s9REBFpAnFfykmMX0iKjxiumE Lp7aLG6k74D+etcM9W/GRp4UhkJE5DSqXaWGUdT2l20vDm4NzQw9zSnhGaMF7HvD 6grs8gG58yRHPvNCA2QaobMqxlhhlQgzNGd1lfi0hdYEqvoPcvsZ8//N2UG2PpH6 LZLyuz+JR+YnFeieVbSJGu5T1goc8VoAVXZFRFAxbMMRdW0yRHjcrMgG7cUFXgpp tP61Wl1BNOAYLkf54vTbmNtbFHjJHPkfUlLJE17BMPzsgvGbzeazFoTAgel6lGCm oNIliTH8lsjH/jVj2BtwcoOCR5286lzk5SkIOLWhZ8BGTahGvBcntT9T04g== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjxm12f05-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 23:42:30 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c21c01cf3so251291cf.2 for ; Wed, 22 Jul 2026 16:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784763750; x=1785368550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o3eANFp8vRpiIPxEwZyDYsYfAkwyo20ziwerf+wA+5I=; b=AxpUhsaRvQ8FZXTw4IA/vPs1SK7WpPUcXloyCh3lef/VCYWw/WyTRne9GjDNdwRk9X dwWkxyPRXJh7YS094NZLCo8Tz7jX8IGtvHAGoUBEhUcmBF0Th4wUs9Xo5UofZa/oAubj 7ouOKr4L31Km70Qyt+oP/8F97OPHFVt7VIDzgVRSbrCiPgvBxkqs7a1eZE9ejMsgprAy j26Fz0EpC4dDue0GjVOtKCOR4xbBYjqekmC3wZQG08LQXMSldAUEjTvv9vzWKb7GWadf RgM+uGVpn/6EU6YbGvOxHuQbEhHZo7obXQdVEZZv/KrPAj1ddl9FBFv2cvOWd0DjNIFC BQnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784763750; x=1785368550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=o3eANFp8vRpiIPxEwZyDYsYfAkwyo20ziwerf+wA+5I=; b=VcKqa2i2mOsAkyGDO2Bslxf03WMF3ifWfz0Vs5iroP88BiGi2NBBll7fhs/3wiOlsV uYv2BZckg/taaiY8yoooKgTq2kW7xohffVMI9OEXEQ431NmuZJJgQ1JKCISwAknnAxdK WvTFYPKSWzHgE74i3EQAOGgB3HOYGdZmQ6JPhrkpe4ulRjaktTdIPZoOyCI6w/Xcuc2e +um+pLyfgBp0U731q5thqi8wP5yC4IkI6cMYQnWtQEbFPo57HjnecxRGu2JWmhYS/fho sQf+l4deJzS3fxgUCPBPjChROox0DeeKrQbB4eBgP/BS8XgHo6jvU/RstBJX7b926kWc 8L0Q== X-Forwarded-Encrypted: i=1; AHgh+RphQMP3TFsiozXQ0Dj+MryNfXvXXP2eA7ym9SFmXiA6z9t8KywYSlNs8JY+qRwyWVQYeLP3jEzac5jErjc=@vger.kernel.org X-Gm-Message-State: AOJu0YxfUiXjHblByPuyB2OUGsQ0SaFS1Q+yPNLEEA4u66B3CA1c78CQ sZCYej2USV7/eATWDictxYzpstzxFBcg5Gbud4Uvsy38bo0PPzhoyJx4pPBiD8eFxUDAetlbXYI igzAGTju+hXdkL+ModaUa8FePkfPBCX/UomfZ+FkPVRJb4bkTRsazZq/Dg6NyutRy5G4= X-Gm-Gg: AR+sD12MNmyRQ28DBacQje60j+IK5z4AhxzsZbtTU40K7LVEDQnqO6GklAbg3x7ZNoz 8U0AiOXmB0b7/G2JO7envIUxy2ElPo6Sje/HXkqG14/g0PGo7LEGISxeuhnqCTjL0weOgUde9s0 cG1wUp4IDY+/rYL17x6w8/Jyg/GJt6yz7m8WHW0yAyIbxHRMk0wmEXEsuYKvimZfxqJuGfc/Wtt OP7YrwasqV0zzYl2QzCAxAA/R1Kvq8J4Cao1OqQgIf3lKhtsVaMfuG+5FSp6QmhrKpajgEvCWeq iEFsuFMicAjtqQi6I+lWLj4rx3gHQuD54wHSJ20XlNypVIbtk9ZsxgWwNo/dai9FxR+Tm3yCtgN M2XeLKEmaDItcyQ== X-Received: by 2002:ac8:5807:0:b0:51c:7b12:1218 with SMTP id d75a77b69052e-5283e0419dbmr6401681cf.86.1784763749852; Wed, 22 Jul 2026 16:42:29 -0700 (PDT) X-Received: by 2002:ac8:5807:0:b0:51c:7b12:1218 with SMTP id d75a77b69052e-5283e0419dbmr6401191cf.86.1784763749318; Wed, 22 Jul 2026 16:42:29 -0700 (PDT) Received: from debian ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a4aae16sm101796345e9.0.2026.07.22.16.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 16:42:28 -0700 (PDT) From: Srinivas Kandagatla To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Charles Keepax , Maciej Strozek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla Cc: Bard Liao , Pierre-Louis Bossart , Richard Fitzgerald , Jorijn van der Graaf , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: [RFC PATCH 1/8] ASoC: SDCA: hw_params: program upstream Input Terminals for OT DAI Date: Thu, 23 Jul 2026 00:42:11 +0100 Message-ID: <20260722234221.884765-2-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260722234221.884765-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260722234221.884765-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDIzMyBTYWx0ZWRfX4VPZh2sFk8is 4Sz0irtVtKrFTt+MqE0mvvJSq1wWxA8h9KBuhtQioB43TplOTxR6Dkx/Ck0b9Xv/lTm5k0WagYk QZlonFC06Ns2KlipUnPzqJztuK+nQSE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDIzMyBTYWx0ZWRfX+Mwlg6FOLYFG uRzjFwcw796NE8798AzCwvE3FDFIxoz6fw6nEJzuegroqq7YTCXxTPLJ4mmkNCMyOeVquCTWPqX uYMplksnohCUCmJyjARjvmI0EP+F8FZXAbl6hBYKUFj1YWVomb0RT+Jxu9DshFeXBBKOFkgnOYV bIBlAMqJwJySGf50p9IZFYO10Ez6jubjBlXMJUpj5d89b03joPAo8R/7NOsldaEXwhb8AgA6PJ4 0xEiWG0+iP6mdFSo4fPk+jvfyrJYDN1ZjpscW+dhi4lGHyWJhfALw7GcVwDQryELLhLVUtN7DwE UvQhvk/pZ2Ti1KFiqRVgdWfsAro4o3CE9ZfI71v92lmd+sTRQ9+bGR4qHStQBrv8wvdmSLYaTK7 dRHubbbSnipm/wi6/wsR6iwu4PMHcQxcacv+/3OCc9Yc6pmGiw76rWv2VQjtMyCWVtP47YYiD9m slvuHzwGIZAcBeuQBwA== X-Authority-Analysis: v=2.4 cv=Rsv16imK c=1 sm=1 tr=0 ts=6a615566 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=uD0j0RXNaZXElQmVNg8A:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: nbZCFe6qiEV2f9BBQTWdKZhtA6yIsiNp X-Proofpoint-ORIG-GUID: nbZCFe6qiEV2f9BBQTWdKZhtA6yIsiNp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_05,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220233 For a capture stream the DAI is the Output Terminal so sdca_asoc_hw_params() only programs the OT itself: cluster, clock and Usage. The upstream Input Terminals that actually source the audio never get their Usage, ClusterIndex or clock programmed, so the power domain comes up but no samples are produced. Walk the source graph from the OT and program every Input Terminal reachable through it. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Srinivas Kandagatla --- sound/soc/sdca/sdca_asoc.c | 51 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/sound/soc/sdca/sdca_asoc.c b/sound/soc/sdca/sdca_asoc.c index b4dedba719dc..ac688cd62970 100644 --- a/sound/soc/sdca/sdca_asoc.c +++ b/sound/soc/sdca/sdca_asoc.c @@ -1726,6 +1726,51 @@ static int set_usage(struct device *dev, struct regmap *regmap, return -EINVAL; } +/* + * For a capture stream the ASoC DAI is the Output Terminal, so hw_params + * only programs the OT itself. The upstream Input Terminal(s) that + * actually source the audio (e.g. a mic input behind a power-domain entity) + * never get their Usage / ClusterIndex / clock programmed and stay inactive, + * so the power domain comes up but no samples are produced. Walk the source + * graph from the OT and program every Input Terminal we reach. + */ +static int set_input_terminal_sources(struct device *dev, struct regmap *regmap, + struct sdca_function_data *function, + struct sdca_entity *entity, + int channels, int rate, int width) +{ + int i, ret; + + for (i = 0; i < entity->num_sources; i++) { + struct sdca_entity *src = entity->sources[i]; + + if (src->type == SDCA_ENTITY_TYPE_IT) { + ret = set_cluster(dev, regmap, function, src, channels); + if (ret) + return ret; + + if (src->iot.clock) { + ret = set_clock(dev, regmap, function, + src->iot.clock, rate); + if (ret) + return ret; + } + + ret = set_usage(dev, regmap, function, src, + SDCA_CTL_IT_USAGE, rate, width); + if (ret) + return ret; + } + + ret = set_input_terminal_sources(dev, regmap, function, src, + channels, rate, width); + if (ret) + return ret; + } + + return 0; +} + /** * sdca_asoc_hw_params - set SDCA channels, sample rate and bit depth * @dev: Pointer to the device, used for error messages. @@ -1762,6 +1807,12 @@ int sdca_asoc_hw_params(struct device *dev, struct regmap *regmap, break; case SDCA_ENTITY_TYPE_OT: usage_sel = SDCA_CTL_OT_USAGE; + + /* Program the upstream Input Terminal(s) that source this OT. */ + ret = set_input_terminal_sources(dev, regmap, function, entity, + channels, rate, width); + if (ret) + return ret; break; default: dev_err(dev, "%s: hw_params on non-terminal entity\n", entity->label); -- 2.53.0