From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C483911A9 for ; Thu, 23 Jul 2026 08:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784795210; cv=none; b=F6vgotoC8zRQ3ctnpR/fycsWuylAJHdis7/HMnH0hsrg7XNHEQaKmPpnKjRr9jBfxjN1ZFgexuiatLn0zv8zFbvxwvvcnuwi2UyRIgd01O46wZ8lyDQZkZcafRyHlY1cXqMeEh/9B+ulrV918Wrcf8cK17mhABqep36OAeAtadk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784795210; c=relaxed/simple; bh=1McoUymBymyISLFpJohX21UVwv2KSLo7NWLJUK7vCCQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kzEk2JhUMa/rnRYvm50b7txQFcNXXyEc80UaOSgfCmX/k/wbMojYmzlnpHlDn4RcK1B9uE4z7dBAyNSuq7ggFJYoy6Vw6OSW/ryjyexotUl/IwKOMc2z5zbWwbaVOsO1p9Xg5irNsvjdM4WAP5TTicsqzGh/JWQQx9uGxg1WGIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=fdVF9C63; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="fdVF9C63" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso2300115e9.1 for ; Thu, 23 Jul 2026 01:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784795204; x=1785400004; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rlMszdZXGp83rqdq4F5705HBF23F8eoUUsJHW6GLZWI=; b=fdVF9C633PSDVPlg4QYFqjQZ1rhQg2Rb+PeHA/hn5Eqgj2jX1D0F1X29Z9S1LtxyF9 RVlkkagYp6dkWNEJmDfGFefizkupkKAVbbJW0/ORbkXKr/J1ry9Vn4SBZoaSk52VTfi5 HsUJ3xRHeHHbjXHU0JZ8qyWO7gxOydfTnpterguaqatwB3n2Tq8d5POKo7+miXzVG44H zTSpCadMyLYUzOzxQi3HzyZceGALi/p7hO6D9UnfZLbaz/6GrrzJ+u1eOGhxCvngLx4w Bn3Xdx4eCmLMZut2w9m1HHEwyd7mpMnDpeE5FYfVfAjY0fPqbeOkvMBZW4sFCKSnCUuZ IOkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784795204; x=1785400004; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rlMszdZXGp83rqdq4F5705HBF23F8eoUUsJHW6GLZWI=; b=Jvh6/mIEgyoB7YKFm1PDMLJHAfGe2XKl/dS9wkHiXfw/qMY/2RySKMMmYskyJ08ZHp dbpF1cary96mckKNYKhpFJA2eueymumygMHgK+FJrY8lmfR0hkANQvgXGfMaWcrk/2TQ TsDGHbbPyHSPFpB9S27jYRJMYjxNkCknNRyz43NsxHVDd50TmL9X6sRrqQD1m7hv+vhj 8qEPqyW9bl6id1U+S+U6fsToMrBFsajtgRyQE/rnnAIT6E6a9kwVr58oSMVCp7H2xkfY FswYdD0ea9WUTQhLaZL4f1CBpfGeJ90dYae8yzV2888r04vNC7Xscnckbl2Tt5skYkcL Wwog== X-Forwarded-Encrypted: i=1; AHgh+RqKHXb8sXa0vkeJjc6eQUZ6U1D9R3n+G1GzyQkQCXPMxF3b0vV0TJnulY/D0WSklvVUsQNudnCtq555BGQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyn1msctAVXBz/MF5jWsXww56cyh1FNkGlZAUad2lCTLlRlmoSI G+d2mhEz8+VXmx9DFzQ6UFLC5s15dsfAsmxFLt7PAK5d5bZIlYuq20YySqZ0RxDqSYw= X-Gm-Gg: AR+sD13NZzJWdAzA+JBtqn/b+yzHcS16eHDeeweY4FVYxAmBbIRiP32dKfrdw//Umy3 0noeskQmS3F8k32ue8JVdQdFda8X8h4P/yZNxxMsUndO+GspTSCL0IZPKOf07PBQFKMG1lA1b+a RKsXlFz1M4uSDjKxPxavF/o7PBXKI6qfamDDb6TRSlK8WFpauGFmCo8VQshzbsQWm2OOYELF9B4 APVRNzKU4q/QwykQQhmEaARjV7YcG/GskVax+ugnTJzLIHRasTFtAI43W283uiTz1o9yjUo3f2U ClHUA+a6uGRCU+RUsLE7xmip0ah/DibGfRsg8FpcekdpZxbny8RAjnQsdVoKeWaE1lQ1oK0SVvT LPkYbH5Yjb0BzQuiAkURM2yiFn3yYN8Yk2kJXx8dizDK8Nyxl1DnFS5DD1gE9FQyGMkaAOaWFVg == X-Received: by 2002:a05:600c:19cc:b0:493:e451:a9e1 with SMTP id 5b1f17b1804b1-49573c8c29amr21928245e9.2.1784795204083; Thu, 23 Jul 2026 01:26:44 -0700 (PDT) Received: from zovi.suse.cz ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a4f9a1csm124831645e9.5.2026.07.23.01.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 01:26:43 -0700 (PDT) From: Petr Pavlu To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen Cc: Aaron Tomlin , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] module/dups: Use strcmp() to compare module names Date: Thu, 23 Jul 2026 10:25:55 +0200 Message-ID: <20260723-module-stats-rcu-v2-5-bd582261fae3@suse.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260723-module-stats-rcu-v2-0-bd582261fae3@suse.com> References: <20260723-module-stats-rcu-v2-0-bd582261fae3@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Use strcmp() instead of strlen()+memcmp() to compare module names in kmod_dup_request_lookup(), since all strings are NUL-terminated. Signed-off-by: Petr Pavlu --- kernel/module/dups.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module/dups.c b/kernel/module/dups.c index 56d659f049c5..80e1638ac34a 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -72,11 +72,9 @@ static struct kmod_dup_req *kmod_dup_request_lookup(char *module_name) lockdep_assert_held(&kmod_dup_mutex); list_for_each_entry(kmod_req, &dup_kmod_reqs, list) { - if (strlen(kmod_req->name) == strlen(module_name) && - !memcmp(kmod_req->name, module_name, strlen(module_name))) { + if (!strcmp(kmod_req->name, module_name)) return kmod_req; - } - } + } return NULL; } -- 2.54.0