From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 225E01E3DDE for ; Thu, 23 Jul 2026 00:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784766352; cv=none; b=a223iNBDkicbQBeXGE6o0SPQdnF8iOqr1LxT9B336vqm4DOK+0Qgf3uVEmMrMWCF4MmgbMJl3Tp9SQk+nVWa3rUB4YwZ+1Qy2X8mnQJUPHubzmpYnrqOJJCEn9u6g2BQdSxQ8iBEb3BAyRehOOHDEcF04PNkLKdfIZruoGFMVJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784766352; c=relaxed/simple; bh=YnaLPj1DA73zRROyffWInbELY8TUsYLyhe9N17zua8k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lyXTn4tpBb2S5oWuvxXui5/PMuHHak8UaN0+Zaia8Ut8eTA6EibSMirkDUCieUCb+/5FrqMa8uBu9Icj7yVB1bH5wm4WiInK1UVrQgbCYYVze/HNKVWBhQMdHNrDt8lzlafk70bGrbSjoMy/FR3dxYBcML63n3ySP+XbZ2Ik7wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ddntcYjO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ddntcYjO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 641A31F000E9; Thu, 23 Jul 2026 00:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784766350; bh=AjmV+pFTu5g/gQQSb0j7+dUZGhkEqEku71eK2pBiGFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ddntcYjOLicDsdRqgPmCRvpTN4D/1DpCsOyQTpmYu753AnHz1gwUKf8gRu7Cbce8g 3sJma6GbAsJNZ02N+60/1n4A8QFWR84kj7OOk8uS2AMcDzzh2GH8M+8ZGzLD8qVnUT FcIJfjqy2qh7GI7jWl+wr6lnwnQv4onRJ8zDfxe2FPlt8ocaDxkYXXa91o5u48qjgd KbWIuwKMdDiXMd2LTKEPj4Jgn60MvEuoMTFlRXPgJVYQhN072nH1Q7JS0By8XG3h6I VH+mxqPEueLJzjxspV1MEMSFc0V3v+eCsT17s3yH4DPcgfdZ/ZoIlCsBlbPDClhnhH HK1/+mATDbsqg== From: SJ Park To: "Lorenzo Stoakes (ARM)" Cc: SJ Park , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kees Cook , Andi Kleen , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] x86/elf: Correct comment for STACK_RND_MASK() Date: Wed, 22 Jul 2026 17:25:41 -0700 Message-ID: <20260723002542.96123-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722-fix-x86-comment-v1-1-605080af988d@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 22 Jul 2026 19:44:43 +0100 "Lorenzo Stoakes (ARM)" wrote: > Commit 913bd9060195 ("[PATCH] x86_64: Increase the variability of the > process stack on 64bit architectures"), merged in 2006, increased stack > randomisation from 8 MiB to an ostensible 1 GiB for 64-bit systems. > > However the commit actually introduced a mask of 0x3fffff * 4 KiB pages > which provides 16 GiB of randomisation, not 1 GiB. > > It appears Andi perhaps typo'd an additional 'f', as 0x3ffff would indeed > provide the stated 1 GiB. > > Since this value has been in use for 20 years it seems sensible to retain > it, so correct the comment instead. Good catch, and sounds reasonable fix to me. > > Signed-off-by: Lorenzo Stoakes (ARM) Acked-by: SJ Park Thanks, SJ [...]