From: Huang Shijie <huangsj@hygon.cn>
To: <mingo@redhat.com>, <peterz@infradead.org>,
<juri.lelli@redhat.com>, <vincent.guittot@linaro.org>
Cc: <zhongyuan@hygon.cn>, <fangbaoshun@hygon.cn>,
<yingzhiwei@hygon.cn>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<vschneid@redhat.com>, <kprateek.nayak@amd.com>,
<linux-kernel@vger.kernel.org>, Huang Shijie <huangsj@hygon.cn>
Subject: [PATCH] sched/fair: remove the wrong check is_vm_hugetlb_page
Date: Thu, 23 Jul 2026 15:34:49 +0800 [thread overview]
Message-ID: <20260723073449.1945687-1-huangsj@hygon.cn> (raw)
In vma_migratable(), we do strictly check with hugetlb mapping:
hugepage_migration_supported()
When vma_migratable() returns true, it means the hugetlb mapping
passes the hugepage_migration_supported(). So we should not
skip this hugetlb mapping.
Remove the wrong is_vm_hugetlb_page() check in task_numa_work().
Signed-off-by: Huang Shijie <huangsj@hygon.cn>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d78467ec6ee1..0582e0cfba36 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4167,7 +4167,7 @@ static void task_numa_work(struct callback_head *work)
for (; vma; vma = vma_next(&vmi)) {
if (!vma_migratable(vma) || !vma_policy_mof(vma) ||
- is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_MIXEDMAP)) {
+ (vma->vm_flags & VM_MIXEDMAP)) {
trace_sched_skip_vma_numa(mm, vma, NUMAB_SKIP_UNSUITABLE);
continue;
}
--
2.53.0
next reply other threads:[~2026-07-23 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 7:34 Huang Shijie [this message]
2026-07-23 11:30 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723073449.1945687-1-huangsj@hygon.cn \
--to=huangsj@hygon.cn \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fangbaoshun@hygon.cn \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yingzhiwei@hygon.cn \
--cc=zhongyuan@hygon.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®