From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC3E45D5EA for ; Thu, 23 Jul 2026 11:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805048; cv=none; b=BEkxJTWmbKEtD5Xczkw3o8hPgr1Aj4hbi6uNs8YcirNm4uo1pVeqo6xHzYCbmhatG7RjBgqlxMp0s6dd1S+TZq17f16A748MDc3ZEhLxLq8zyAqBg6L0JlpyfEmk/raWi3YVFX+sEfSDJN4/6B36V2EjXBJjMmdGCVXqegixdIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805048; c=relaxed/simple; bh=AFBxKIBwTyZrAmGdQnJGgzy3nM1sTvnC25r+L1MwTS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=caRdgj0RKuZgYuDCFE933wWsG+yl3kamxqmcxZVNsh7gcse3znib5+wuwSh7l33oNI5oZZ8sybx4djYDctU1Zs7XuCIdZKreSE7M+JUHQ8ESM8FUqtK+BnHfu0TgW4W6a2iANxBgSRuBb1zRzXfoFzFOt97D/361EfdZZpUhIt4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pbs8DL25; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pbs8DL25" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cee9b74ee1so3820985ad.3 for ; Thu, 23 Jul 2026 04:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805046; x=1785409846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mMkS67zlUschvqIwbn8/Rc0NE/xfd4xHXYatpnZ3xec=; b=Pbs8DL25VtrbFlGzWnytjNn6m6kGJRaPmSBl2Uw8X+l+unVYpWC2ekISjtxeKxCAYr CvChI9E9V91N/RGnULaLtql8f/W63bt0Gwb9TUSfq2Ia42JlXZ65AGaMkH23HPrZO8J/ /eyBdKj5h3v20KO0bZ/UKP94wL16qM9QZDlYiz+UhlqM8LBeadpWTjT1xzwO2allEUSw Eu21x5bLMBnaVOKzduOs6/bbZqOtspmUqIKqjLAFvqfbwKzvxtbmXCkPqq6ZoT2ckP+d IqfxRvK3e3CD8ox+S7N/eyau624AxknzJz9aWd7fyahKpjEPdimfADNGiUs8DI3R4xIv XO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805046; x=1785409846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mMkS67zlUschvqIwbn8/Rc0NE/xfd4xHXYatpnZ3xec=; b=RJh+NF3v/gga7vYVGJ8rlczrSRb3yZYsjvgO/Nuyr3nEbIqrS8An/JX/RpuabhfITb pkzM7y2RDJsEsSsVgQS1pQrPexqjBKodRgpd/up7eVtvaaZbsYr70SPrmvNGTCfNE2Af SKEGxauNRPuPOm6BDUy3CPLVHATs5h9i2fszuDitUFUIruqADFS8YnkfWr0iiElTlmvn MCz7aGbONxpJ42fp4eSj4mVovCOxsQfkoeBYWIypkk+VXC+14c0+bLVCfu/T7kWcIm/N JLTQdfJcssQ1ne6xe168cX8rWyoPfcwnQY5wP1woM2ptHWClsvhuizlhzopzQ+C8VBVu ASdA== X-Forwarded-Encrypted: i=1; AHgh+Rof1akTrIVV1zdTjOobqrCjttnseH+mB5WsNpESSOzZ5CYcxpCT7XjcEeIyx4A27heSnFV6ZOgLqLwVbBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+Oda5ePgsa/XoXGZt/A5b9W4pyWl0nhcCVgPOa3Bde34SxGTx mzRDAeYdsXVsq1rsSWJlMLWgtXUvD4lrPcd/AF+wyXBZmcCTxGeDaj6N X-Gm-Gg: AR+sD11MN8qUOJBt8GramU23g7NRo/wplm1/tJVdovreifV3n+cGQQOogpcwhzOeEXh ro+dO/2RtDxSaMWZeu7428d00lazwdKrpLV5p0/GfycA/ibNUILcLZFwgHbAl6UflVz5d1jGx4P HPThB0Et2s8eV9+Cf3lF+vExXQ8Qio9n21UrxkH6VU4qlONh2KeVzeBgaofJiAJhWkrlV4q/A2M Qo9prvCCesUzu/KuNZa/ofOAfMzEmM3Qv4vf2ipXOU8V04PwibaYNKLC8nAcEJqTlP6TwyThFtX vgdYnBH5k+6Sq7RuyTkaDrVKt6mog28ReR1kX6RPIu7+dcqMGJoCHdH2eCiejrb/ae9S/1XBDK+ fIKdlQXJ+3mcCAmj1X8tnONUR5kJ5aJd51vYCDkYzhVC7r6NSUhiW8N/9alVWKks8quPPQtfty0 EdhjrRyXmLnat6v1AhEm7LJsNgd+NGCzmAA83K X-Received: by 2002:a17:902:db01:b0:2c8:2808:3ec4 with SMTP id d9443c01a7336-2cfa748ce6amr30066565ad.24.1784805046169; Thu, 23 Jul 2026 04:10:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/4] ASoC: starfive: jh7110-pwmdac: Remove unnecessary goto Date: Thu, 23 Jul 2026 18:10:11 +0700 Message-ID: <20260723111014.54071-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The error path after jh7110_pwmdac_runtime_resume() failure only performs a single cleanup operation before returning. Remove the unnecessary goto and return directly after calling pm_runtime_disable(), simplifying the control flow without changing the behavior. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_pwmdac.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/starfive/jh7110_pwmdac.c b/sound/soc/starfive/jh7110_pwmdac.c index a603dd17931c..562936981cf0 100644 --- a/sound/soc/starfive/jh7110_pwmdac.c +++ b/sound/soc/starfive/jh7110_pwmdac.c @@ -486,16 +486,13 @@ static int jh7110_pwmdac_probe(struct platform_device *pdev) pm_runtime_enable(dev->dev); if (!pm_runtime_enabled(&pdev->dev)) { ret = jh7110_pwmdac_runtime_resume(&pdev->dev); - if (ret) - goto err_pm_disable; + if (ret) { + pm_runtime_disable(&pdev->dev); + return ret; + } } return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - - return ret; } static void jh7110_pwmdac_remove(struct platform_device *pdev) -- 2.43.0