From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 600F645BD41 for ; Thu, 23 Jul 2026 11:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805058; cv=none; b=PvD+rYsUXw62plh5xhm9VKO1Wr+PunZXLOD/bAkQzZTWtlnQdz5aXCQknUI7lQZ3mi4lorEb9zwr8kYoTofkRteE9cWxKwcWQxU5nocmU1DfwAX3EkPV1/s8cX2FX50wN2X/5m/7N2a24c7ZPzeshvNy1e6GN2969xtgXQko+FI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805058; c=relaxed/simple; bh=zWsDJ9w00PvmiL5K7NvXHakKWbnnVtjba/fbAiRXx4M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EMIhqLdsvFvtjkKKyfyrAPFcxaszHdPY3onD1Jy9SscYMMwT4TqlbSi4ug5EcDCNmmCIq01YVV3BXZIo1pdgYm49nBnBM/6LAUCfRd6r9YnJW4sGMYGVfp+ArV7WL7KPmxcoTXPBM9RwwFN4ICsZhmv7q8VdLjB+K4VlHM+OX+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VshNpWJo; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VshNpWJo" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cad8076b01so6685135ad.2 for ; Thu, 23 Jul 2026 04:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805053; x=1785409853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XYqAoIaQg5nXDhd6691kkf7D6EBBcVp7XG5jEmvNbhA=; b=VshNpWJo1YJP4Ti8m6FvJNqA21m/0ind3uXRLwM4Gw6mE1G2XkzNDqNmrABe7yj9a/ CGE6Ppa0djprnMiQrOdazuk1LoOXzMPTAYUrg4VGYEDO3+l0z1l7UC6pbGG/dIcBkXc1 6FYwp2sH2LxFXGZ0VLFyGOA3qi3IWGGA2bticpOXd/sUdSvzp7dpnEqf8osu8gZcejTh nWlVMbbGoOgIcNLHjoB83FqJY8vkKzfVindNKNd0Zlso0w7/7imKefx5zime5GiMb8Tc ASEGAUXJTm05Kkeix8iFSfbrBTzGm/Oou1MEFcjh7+yCexWUlG57DUsm+l9uwrgOaNdt 3hJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805053; x=1785409853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XYqAoIaQg5nXDhd6691kkf7D6EBBcVp7XG5jEmvNbhA=; b=iyVAczyna10nh3BPubn1eDlDMJvqetcd18SiEVOzVNDWt/Cgk3Spr7tuKOx+BIZ1qk JjErm5dDYoEhtC/Pj7jjxRB2uPY50nvPTeBaah2YJyWxrpWyGk0TaPULSnj4kaxWFLED 6sRmzWZYljW3QvHxr7+voVL/rBJPpM5XikAfmXy+nC+9pg5307XVn34yW8GpCBkFGVZ/ KZIoITVTTjOQvns7mFNToFUZRN0GzTWrLQR7us4tDF54lilfR7lWTJ0q7Cv//Dx6UQXG lqJBTQxMQx74F80RClutjPg8rlwbif22in00DinvrFvTWDvvoOZD1EyIuAWHNwWKqXE/ 3bpA== X-Forwarded-Encrypted: i=1; AHgh+RrwlPf0BP7AK5D5TJuzNpGqTJUh3CXgONiSekIChjNYc6+pBJ6P2KfvPvgt2FC4I1W9s39iX39NHa+qpGQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxaFYiogK0eKmYzW//0wajTeEC8HtLCT1y6mS2NIszuQwkndazz l8gBgpMHIyhyR8O7CVA5zAIKacTfomrien/tcNw3UNCx2PMheByy0jxA X-Gm-Gg: AR+sD12maQV0bn9PmvOOkpvbdY/BVLkjmyKoa3L00GZSmd+jMCIyqHeJ+0s2/lm0XVe njErUwq7NcBA1FsdcffZhdu/Y9tcOFLPk8a3Yw/aq9SgbIiUnrAGPe59kCbnrB4mV3KBgw40Jfb Zjoe+WTpCpQdB7GFl+JB+jMcZBj7js1Gzb8eho4s0M2Bo2wy6OSEEOtzG4rFrnThOp4CewGkUKo Sv/13LkHjAj3+8FfHlAPgfiBBOskcvjX+Kj4igbFdAEXPDtkWpogqMAH0NZFGSxFy/Gcu/V/ikk aWkveI7reC9lTn6ce/c9I+8IYQxLOgS212JVo+CvMUQoCFwfKrzrrQSBZhOyPJcueX3qQhiGHgf LD65o+ObHvQpXQygqRFBGTFULqJwO7+SCd20wc+HwBv45LjYtI4jLUWy1bLCmBVz3GH4Wae4Twu M8epSSchmBic/zJ2BhusEIxAVe1fl3gHZqy3ALhCGe9rm2l2I= X-Received: by 2002:a17:903:1250:b0:2ca:d91e:bfb4 with SMTP id d9443c01a7336-2cfa74e3b0dmr30593435ad.24.1784805052930; Thu, 23 Jul 2026 04:10:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/4] ASoC: starfive: jh7110_tdm: Remove unnecessary goto Date: Thu, 23 Jul 2026 18:10:13 +0700 Message-ID: <20260723111014.54071-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The error path after jh7110_tdm_runtime_resume() failure only performs a single cleanup operation before returning. Remove the unnecessary goto and return directly after calling pm_runtime_disable(), simplifying the control flow without changing the behavior. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_tdm.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_tdm.c index afdcde7df91a..5365ebe44471 100644 --- a/sound/soc/starfive/jh7110_tdm.c +++ b/sound/soc/starfive/jh7110_tdm.c @@ -615,16 +615,13 @@ static int jh7110_tdm_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); if (!pm_runtime_enabled(&pdev->dev)) { ret = jh7110_tdm_runtime_resume(&pdev->dev); - if (ret) - goto err_pm_disable; + if (ret) { + pm_runtime_disable(&pdev->dev); + return ret; + } } return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - - return ret; } static void jh7110_tdm_dev_remove(struct platform_device *pdev) -- 2.43.0