From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4399846AEE8 for ; Thu, 23 Jul 2026 11:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805062; cv=none; b=OtoQeZvX0MNLeocPCYo2O+F6mgaJGuCr16mdnsmburYuAVrBJZnz8APp4aiXeITT/J954yt8Iq4fje/jFmnel8kMeD9+V0XbkV/Z0N0lAtAqtJFDDOXWPVzoNyUlbTe1DAmXxKk3BXM/MC94tIHB5W/WpAxbApKD4GITLEkJKYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805062; c=relaxed/simple; bh=7N9zuuD+31Nj6KRIPVdXvkaRC6VlFeTBZCFuP4lEjtw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BG24sVkNrdBtJM3TsdeTlYC4fSAxOowhW/kvZa4XVpM2gjVE2e0hk+mp8cJR+PJ+TAHieB179n36Wul2RcplVhhpzDk73GK60ZGi5m8ZKfre8bRgY4V5iFgkeybhZWtxyEvpRhuR2u1UkVnsLnwH3cl8wIP6aEE1nCNNlQISS7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbIPrqVh; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbIPrqVh" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ceed7018c8so3827605ad.1 for ; Thu, 23 Jul 2026 04:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805056; x=1785409856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OnMHtcI+qpC3YzUAbOGiPJG/5dyoFkJTHwb+5r+sq3Q=; b=CbIPrqVhOX6/7vEeRTG/WY9OwDDGK3bWEJMrvMIrpqfdxiKReCWqsbG24Kj75EoOw4 huJI9iJ7QfNp8syla8aWhotd1D5aIFLbChSYy8KvCB+7zjLCEeJRryKtUNoReQcBawzy b2RjWKpprJTvLaQS0MzPNss7xl9h90vzurNadFuOs74E+Fi1gAWJmW8YzOo86+M5bBLM /4zV9arpMTO8YyuOOlCKZFNxQIz47rMZFEd25Xy00kkbqMl2BXuKYJYF5iSGe4JlmLuz KR3ancHz3Uym3jPgvsVwVwGcfQEfRrbyRVkj28nHXB9Abkp822LGulXcHg3GRPIrVORR aH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805056; x=1785409856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OnMHtcI+qpC3YzUAbOGiPJG/5dyoFkJTHwb+5r+sq3Q=; b=n7HPF2xjIIajHNBj9ZlgEuu53Vo9MwcMZWaxwAUmOGdf7DFwiJjRY+NwaTX6WR9DLn PCErgJphgqDASf3KN2+SsGQkJxVgub5lBdhUjcxRk3vdOOZdij07lHn4OmlntPh2gr74 CQqE586gSxmPr//IcaG4z2b+ayfElpOdFtM60JGgCw573weR7bxwIY/4mjk0Nl5PNrH/ eQWEdOVUZ+cIB19FUUcS84fhAR+1/HHJRR762eB8XxMKjoYeayel++OhPt/t8SQa9zXX I+IbGIM4Xoikz3jyzgb5fApOlpWsEM/O7g9NtSgvdhe9FEPSyayfJTQ+hZDSfEsFZie+ Jjng== X-Forwarded-Encrypted: i=1; AHgh+Rqr0ljjaf2Nn/R8K127y7BXIiqXixw49krA9g7ZKteDaXoEpor/1bw1L+fQ0AXUx/vefkpRS3HMX0nFziU=@vger.kernel.org X-Gm-Message-State: AOJu0YymW0CwgvCxi075Af3jBluajqiMd0eygBVYzj6cPppn0MECfUvU Ym38ByJTSLQerfYyak6a3/jP65KO63wHApdaHJ/104/JUCB48MplMPDR X-Gm-Gg: AR+sD12hg9gEuZJMjnqXxwyzp1v9tFeyMwj3hXpuVGcj1AkYUkz6v4lBcDSgweakSuj /BjcX7+6w4tIDHD013zmP2x27Sn1h3LhssQg793svKhEOQzw4vj/wnj1HkrHmoAuA2Odad3xtWb WVIYgAWElWX72H89CwGh5maPKnUOYMU+8eh0jFz66y6LzT74xb2gVw3pIo7aqIefOl9kodLczNs 6UrK4o2idZ3yuwLwmGdJFoSuKgObHdMOEFN9AMBmRGIinsj00z12lyC5iOb3HNu93NjIwbuGBYM g8m/CqHK4eWYhrsfKgX7/NPPRgoptakn8czDKI74fAlb7uoymwbNDGLU1psAKOTU2GiZV0gmkcS uAqB/qEVcG6CanifGvK0qaMPA1S0QmeO9NSBIDiYiEe62o/ocn6eaolm49KFxBUoqxaDJPTwoFH M0UwRNZNupkXQqkOQH41e3dYRsoX5glDKOCA96 X-Received: by 2002:a17:902:d4d2:b0:2ca:f21a:a6c5 with SMTP id d9443c01a7336-2cfa6a546bcmr31664385ad.1.1784805056158; Thu, 23 Jul 2026 04:10:56 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:55 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 4/4] ASoC: starfive: jh7110_tdm: Drop redundant error messages Date: Thu, 23 Jul 2026 18:10:14 +0700 Message-ID: <20260723111014.54071-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_tdm.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_tdm.c index 5365ebe44471..f7522bfbe8e6 100644 --- a/sound/soc/starfive/jh7110_tdm.c +++ b/sound/soc/starfive/jh7110_tdm.c @@ -559,10 +559,8 @@ static int jh7110_tdm_clk_reset_get(struct platform_device *pdev, tdm->clks[5].id = "tdm"; ret = devm_clk_bulk_get(&pdev->dev, ARRAY_SIZE(tdm->clks), tdm->clks); - if (ret) { - dev_err(&pdev->dev, "Failed to get tdm clocks\n"); + if (ret) return ret; - } tdm->resets = devm_reset_control_array_get_exclusive(&pdev->dev); if (IS_ERR(tdm->resets)) { @@ -589,28 +587,22 @@ static int jh7110_tdm_probe(struct platform_device *pdev) tdm->dev = &pdev->dev; ret = jh7110_tdm_clk_reset_get(pdev, tdm); - if (ret) { - dev_err(&pdev->dev, "Failed to enable audio-tdm clock\n"); + if (ret) return ret; - } jh7110_tdm_init_params(tdm); dev_set_drvdata(&pdev->dev, tdm); ret = devm_snd_soc_register_component(&pdev->dev, &jh7110_tdm_component, &jh7110_tdm_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register dai\n"); + if (ret) return ret; - } ret = devm_snd_dmaengine_pcm_register(&pdev->dev, &jh7110_dmaengine_pcm_config, SND_DMAENGINE_PCM_FLAG_COMPAT); - if (ret) { - dev_err(&pdev->dev, "Could not register pcm: %d\n", ret); + if (ret) return ret; - } pm_runtime_enable(&pdev->dev); if (!pm_runtime_enabled(&pdev->dev)) { -- 2.43.0