From: Jakub Kicinski <kuba@kernel.org>
To: Laurent Vivier <lvivier@redhat.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, Stefano Brivio <sbrivio@redhat.com>,
Oliver Neukum <oneukum@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH net] usbnet: cap max_mtu for drivers without bind callback
Date: Thu, 23 Jul 2026 11:42:39 -0700 [thread overview]
Message-ID: <20260723114239.709d2477@kernel.org> (raw)
In-Reply-To: <ce31de54-d46c-4738-909c-91ef229b7d9e@redhat.com>
On Thu, 23 Jul 2026 19:20:30 +0200 Laurent Vivier wrote:
> dev->hard_mtu = net->mtu + net->hard_header_len;
> net->min_mtu = 0;
> - net->max_mtu = ETH_MAX_MTU;
> + net->max_mtu = dev->hard_mtu - net->hard_header_len;
But we assigned
dev->hard_mtu = net->mtu + net->hard_header_len;
two lines earlier, so this is just:
net->max_mtu = net->mtu;
is this the expected max_mtu for most USB adapters?
I suppose so given the patch under discussion?
prev parent reply other threads:[~2026-07-23 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 15:16 Laurent Vivier
2026-07-23 15:43 ` Jakub Kicinski
2026-07-23 17:20 ` Laurent Vivier
2026-07-23 18:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723114239.709d2477@kernel.org \
--to=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=sbrivio@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®