From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BB9F45D197 for ; Thu, 23 Jul 2026 15:23:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784820213; cv=none; b=Kz5NdMqHN8jZFXggMcvzr1PpZcFo/tOPT8OSKOZ7jQ9arluwL4zi+6m1ZWj/jtXWrc46iWuE6qEY49pfhxhNl06toLEA2coc94FrLo7unoqfOr87ys6Lu21Q8Wcvwdv41bfbvgsa/eWieVxDy/mXG2QXVoDrZoOCrNOrMklXt1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784820213; c=relaxed/simple; bh=EHwnDfpKTHBKLjDbOg7K1zPk+bXLu9KD+RIz9v6ndpU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LRMldcI45ppaySYIjFhDzhH0x2DxFHQElSeTriva9Icoav1A1N+hgtyC/wXX4qzsYuKQtx30atBrY8EA2NP0+2x7BP7Mw33QLMmgMghvAtnLlisQI1okBv8z51T90b++P8aNfVBSXAgjjyHreL1dr2Wnpmg+slpcVi1BgbGt8aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mide.dk; spf=none smtp.mailfrom=mide.dk; dkim=pass (2048-bit key) header.d=mide-dk.20251104.gappssmtp.com header.i=@mide-dk.20251104.gappssmtp.com header.b=mVp2XUGF; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mide.dk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mide.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mide-dk.20251104.gappssmtp.com header.i=@mide-dk.20251104.gappssmtp.com header.b="mVp2XUGF" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-c1691e4ec40so106699566b.3 for ; Thu, 23 Jul 2026 08:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mide-dk.20251104.gappssmtp.com; s=20251104; t=1784820208; x=1785425008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xCeah5PtaC40w3m+OfjkHtjZGFO19xRp2kS9i0vWTUw=; b=mVp2XUGFv1NFknNCn4OSAbQnAR5Pk8yMSabtXk0GJ+8C56m3pa2hc/vHl8kVVF18bt OPQDybw8s9nDm7apHdvbhjEYq+EIHEY7KUpFzoMGXmxtOCZRiOn5iMAocbEZkOGvNVVB o8T0BJ/kfIlhbdNYWp9hhJfHh9Z12IAcvx+53QAKH40lQo+9Y+KGAbDjnZldBObUJK6w JLwZ8sSyMOyTelca7rdOfQefyB0nHSb95oDQVNpTvLOdfShPjaLWLh0IhmdQStwuBVu0 ArKK8tcGedvBUIftDLXlqZ8vLpKqu7V+rmadcvxYLFNbxilVxGR9p5EAsAtyg9fbZM6G TiUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784820208; x=1785425008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xCeah5PtaC40w3m+OfjkHtjZGFO19xRp2kS9i0vWTUw=; b=s36FiwtM0FvpBejHYeAUq5ijKW5v1Pio7FwAM9K1xgIIKvTRCGT17s1QgdJFffEOM4 CtOGUwg7D2uVROHm21QWzLc7Wo9wY0T0qgyHrayLTMuGC4HBQCqtViiwVgHxz/xLv42Z S7neaz5gKFqoMMlv9ANoGhRBtPTI/vuWsw9S/8cHLgGyd6jAFZ6Z/uWF1PsWyKniGV8+ 563hCEnRGvnwzWMyI27dNSkQzcgm9KJiDVwsWa/4D9opDlyuxFWWvEBOFZvxVcFDFtpy ohLfvAvDOsEBqysvwvTysrwhCPdTa5+8NtB0H2CnRDQslNc1oSyP3XjT8wSIQcEP7BGO 1FHA== X-Forwarded-Encrypted: i=1; AHgh+RoB8VyJKvCZHxNVGi05AiwuOwKvQPqhLE1T71kek6T4WmBcxIjY+nMYFdLO8iRbTNa/d8J25R8WNwyr65Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyfpXTtSJesjwxavwPavRbaBNT506uaTS0lzLS1ubAMf1EdF2Kg TfAwnPHfqvc8UY//6Hsm0lql0LBXzfG3dLQZlMztDCr+IC4KCG8HVn24q+Qk7WqsTA== X-Gm-Gg: AR+sD10MFfQeIkAd+skhaWUsUieSGgTMtxAFwlqLl/vWfAKjCtq1xOOB8b8fddrm/jb vl9fd0MxMRVjCGB1108I9wblpk3rf4xnuLmVv/EItp+xc4mOyno145738hd9tLzqqhwxrWQGHW/ tT/5TuoURQfzgwo2onEey9DNVsJg6MFOk7SEA/zmalzSLb361Ep/W7PE6smgKS/V51645wmoUlO dFNxIMzwNSv56P80Qgfvv0IAkn/hjIGcBDZhQFNZCMxrHUsWJFX4hTmiM11oHn0Syk117XogbLh xhqAyu8ZsODuUODIz5lYXdavxW6AfVRncMoQZaMfONfQ8Cv/04kwSkA3+xi1XnuZr4siqBB2AUa XYf7YDzDHYEU/5BvZRFpb+e1ietYtR6mlrMpU32o0pJVYPyfEprRGZRGqjOGqh+z4+TyQ2v+EIu 8S2/XMROGTEz7X9Q6Ycu8wJ8wCzT/ZQbdqsKHqGSCWVZcuZryCkKScqN74E3Wvx/u+S+niMOhvp GPH/2VNlFAuVULF+nS5sea0m0A+hEIozLoASEIF23tMSjkAuNA5 X-Received: by 2002:a17:907:741:b0:c12:4c93:852b with SMTP id a640c23a62f3a-c1c50b42321mr166886666b.13.1784820207907; Thu, 23 Jul 2026 08:23:27 -0700 (PDT) Received: from localhost.localdomain (2a06.4004.215b.0000.2aa0.6bff.feb3.5b8c.static6.kviknet.net. [2a06:4004:215b:0:2aa0:6bff:feb3:5b8c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32ebb385sm250749666b.52.2026.07.23.08.23.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 08:23:27 -0700 (PDT) From: Kristian Mide To: dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Kristian Mide Subject: [PATCH v3 2/3] Input: ilitek_ts: handle short I2C transfers Date: Thu, 23 Jul 2026 17:22:43 +0200 Message-ID: <20260723152244.11252-3-kristian@mide.dk> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260723152244.11252-1-kristian@mide.dk> References: <20260709182602.7308-1-kristian@mide.dk> <20260723152244.11252-1-kristian@mide.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Check that i2c_transfer() returns the expected number of messages in ilitek_i2c_write_and_read(). Short transfers were previously treated as success, allowing callers to continue with partially filled buffers. In the report path that can expose uninitialized stack data through debugging output and can also confuse packet parsing. Signed-off-by: Kristian Mide --- drivers/input/touchscreen/ilitek_ts_i2c.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/touchscreen/ilitek_ts_i2c.c b/drivers/input/touchscreen/ilitek_ts_i2c.c index 86975fa9a..a184d024d 100644 --- a/drivers/input/touchscreen/ilitek_ts_i2c.c +++ b/drivers/input/touchscreen/ilitek_ts_i2c.c @@ -131,11 +131,15 @@ static int ilitek_i2c_write_and_read(struct ilitek_ts_data *ts, error = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs)); if (error < 0) return error; + if (error != ARRAY_SIZE(msgs)) + return -EIO; } else { if (write_len > 0) { error = i2c_transfer(client->adapter, msgs, 1); if (error < 0) return error; + if (error != 1) + return -EIO; } if (delay > 0) fsleep(delay * 1000); @@ -144,6 +148,8 @@ static int ilitek_i2c_write_and_read(struct ilitek_ts_data *ts, error = i2c_transfer(client->adapter, msgs + 1, 1); if (error < 0) return error; + if (error != 1) + return -EIO; } } -- 2.54.0