mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	Brendan Jackman <jackmanb@google.com>, Zi Yan <ziy@nvidia.com>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R . Howlett" <liam@infradead.org>,
	Mike Rapoport <rppt@kernel.org>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 4/4] mm: page_alloc: fix non-movable reclaim storm in defrag_mode
Date: Thu, 23 Jul 2026 17:02:49 -0700	[thread overview]
Message-ID: <20260723170249.98d83bd68698fff2629391c4@linux-foundation.org> (raw)
In-Reply-To: <00bb7fd0-998b-49f0-9941-cc4d796a8751@kernel.org>

On Thu, 23 Jul 2026 16:17:51 +0200 "Vlastimil Babka (SUSE)" <vbabka@kernel.org> wrote:

> > 2/4 actually came after 4/4 during development. Without it, compaction
> > cannot make sufficient forward progress on the promoted non-movable
> > requests. So it is a hard functional requirement.
> 
> So that's the tricky part then. If it's a hard functional requirement for
> 4/4 and yet leaving it out results in no conflicts when applying 3/4 and 4/4
> (as it indeed seems so, based on my local test), then it's quite possible
> stable folks will figure out themselves they need 3/4 as a stable-dep-off:
> 4/4 but won't backport 2/4, unless you act quickly enough on their mails.
> 
> > Whether it deserves an independent Fixes: depends on how many
> > GFP_KERNEL pageblock_order requests we have :-) I'm guessing not many.
> 
> I don't know how else to indicate it though. It's kind of a co-fix with 4/4?
> 
> >> > (An alternative would be to put cc:stable on all four patches.  That's
> >> > a bit abusive but we do it rarely).
> >> 
> >> I don't think it's necessary, the stable team are quite capable of figuring
> >> out the deps and backporting them with a Stable-dep-off: tag. IIRC the
> >> "fake" tagging is discouraged? Maybe they can clarify.
> > 
> > Yes, I *think* it should work with tagging just 4/4.
> > 
> > It won't apply cleanly or build without 3/4. So I'd assume if that
> > dependency is lost, the automated backport will bounce and I can send
> > a backport series by hand.
> 
> The way I see if often happen is that Greg sends a mail that it bounced and
> soon after Sasha replies with fixed up version/series. Which could very
> easily be 3/4 + 4/4 without 2/4.

My brain hurts.  I'll include

Fixes: e3aa7df331bc ("mm: page_alloc: defrag_mode")
Cc: <stable@vger.kernel.org>

in all four patches.

  reply	other threads:[~2026-07-24  0:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 14:56 [PATCH v2 0/4] mm: fix reclaim storms " Johannes Weiner
2026-07-22 14:56 ` [PATCH v2 1/4] mm: page_alloc: __GFP_FS lockdep annotation for direct compaction Johannes Weiner
2026-07-22 14:56 ` [PATCH v2 2/4] mm: compaction: support non-movable compaction for pageblock requests Johannes Weiner
2026-07-22 16:23   ` Gregory Price
2026-07-22 14:56 ` [PATCH v2 3/4] mm: page_alloc: move capture_control to the page allocator Johannes Weiner
2026-07-22 16:59   ` Gregory Price
2026-07-22 14:56 ` [PATCH v2 4/4] mm: page_alloc: fix non-movable reclaim storm in defrag_mode Johannes Weiner
2026-07-22 17:10   ` Brendan Jackman
2026-07-22 23:22   ` Andrew Morton
2026-07-23 10:22     ` Vlastimil Babka (SUSE)
2026-07-23 14:08       ` Johannes Weiner
2026-07-23 14:17         ` Vlastimil Babka (SUSE)
2026-07-24  0:02           ` Andrew Morton [this message]
2026-07-24  5:58             ` Greg Kroah-Hartman
2026-07-24  0:00       ` Andrew Morton
2026-07-23 15:13   ` Vlastimil Babka (SUSE)
2026-07-24 15:09   ` Brendan Jackman
2026-07-24 18:07     ` Johannes Weiner
2026-07-25 12:34   ` Brendan Jackman
2026-07-27 16:50     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723170249.98d83bd68698fff2629391c4@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=sashal@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome